Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co()

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/1621840854-105978-1-git-send-email-zou_wei@huawei.com

authored by

Zou Wei and committed by
Maxime Ripard
5e4322a8 a596fcd9

+1 -1
+1 -1
drivers/gpu/drm/vc4/vc4_hdmi.c
··· 901 901 unsigned long bvb_rate, pixel_rate, hsm_rate; 902 902 int ret; 903 903 904 - ret = pm_runtime_get_sync(&vc4_hdmi->pdev->dev); 904 + ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); 905 905 if (ret < 0) { 906 906 DRM_ERROR("Failed to retain power domain: %d\n", ret); 907 907 return;