Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: iio: meter: remove fixme comment on device remove

This comment was in place in the original drafts of these drivers
when the remove function did a whole lot of work: flushed queues,
unregistered interrupts, uninitialized rings, unconfigured rings,
and a few kfree's.

The remove functions have since been reduced to unregistering and
stopping the device. This is the inverse of what was done during
probe and is correct. Time to remove the comment.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Alison Schofield and committed by
Greg Kroah-Hartman
5e3d1d52 b0263382

-3
-1
drivers/staging/iio/meter/ade7753.c
··· 528 528 return iio_device_register(indio_dev); 529 529 } 530 530 531 - /* fixme, confirm ordering in this function */ 532 531 static int ade7753_remove(struct spi_device *spi) 533 532 { 534 533 struct iio_dev *indio_dev = spi_get_drvdata(spi);
-1
drivers/staging/iio/meter/ade7754.c
··· 558 558 return ret; 559 559 } 560 560 561 - /* fixme, confirm ordering in this function */ 562 561 static int ade7754_remove(struct spi_device *spi) 563 562 { 564 563 struct iio_dev *indio_dev = spi_get_drvdata(spi);
-1
drivers/staging/iio/meter/ade7759.c
··· 476 476 return iio_device_register(indio_dev); 477 477 } 478 478 479 - /* fixme, confirm ordering in this function */ 480 479 static int ade7759_remove(struct spi_device *spi) 481 480 { 482 481 struct iio_dev *indio_dev = spi_get_drvdata(spi);