Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: lpfc: Fix a possible null pointer dereference

In function lpfc_xcvr_data_show, the memory allocation with kmalloc might
fail, thereby making rdp_context a null pointer. In the following context
and functions that use this pointer, there are dereferencing operations,
leading to null pointer dereference.

To fix this issue, a null pointer check should be added. If it is null,
use scnprintf to notify the user and return len.

Fixes: 479b0917e447 ("scsi: lpfc: Create a sysfs entry called lpfc_xcvr_data for transceiver info")
Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
Link: https://lore.kernel.org/r/20240621082545.449170-1-qq810974084@gmail.com
Reviewed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Huai-Yuan Liu and committed by
Martin K. Petersen
5e0bf3e8 14d38356

+5
+5
drivers/scsi/lpfc/lpfc_attr.c
··· 1907 1907 1908 1908 /* Get transceiver information */ 1909 1909 rdp_context = kmalloc(sizeof(*rdp_context), GFP_KERNEL); 1910 + if (!rdp_context) { 1911 + len = scnprintf(buf, PAGE_SIZE - len, 1912 + "SPF info NA: alloc failure\n"); 1913 + return len; 1914 + } 1910 1915 1911 1916 rc = lpfc_get_sfp_info_wait(phba, rdp_context); 1912 1917 if (rc) {