Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: free compound page with correct order

Compound page should be freed by put_page() or free_pages() with correct
order. Not doing so will cause tail pages leaked.

The compound order can be obtained by compound_order() or use
HPAGE_PMD_ORDER in our case. Some people would argue the latter is
faster but I prefer the former which is more general.

This bug was observed not just on our servers (the worst case we saw is
11G leaked on a 48G machine) but also on our workstations running Ubuntu
based distro.

$ cat /proc/vmstat | grep thp_zero_page_alloc
thp_zero_page_alloc 55
thp_zero_page_alloc_failed 0

This means there is (thp_zero_page_alloc - 1) * (2M - 4K) memory leaked.

Fixes: 97ae17497e99 ("thp: implement refcounting for huge zero page")
Signed-off-by: Yu Zhao <yuzhao@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: David Rientjes <rientjes@google.com>
Cc: Bob Liu <lliubbo@gmail.com>
Cc: <stable@vger.kernel.org> [3.8+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Yu Zhao and committed by
Linus Torvalds
5ddacbe9 f601de20

+2 -2
+2 -2
mm/huge_memory.c
··· 200 200 preempt_disable(); 201 201 if (cmpxchg(&huge_zero_page, NULL, zero_page)) { 202 202 preempt_enable(); 203 - __free_page(zero_page); 203 + __free_pages(zero_page, compound_order(zero_page)); 204 204 goto retry; 205 205 } 206 206 ··· 232 232 if (atomic_cmpxchg(&huge_zero_refcount, 1, 0) == 1) { 233 233 struct page *zero_page = xchg(&huge_zero_page, NULL); 234 234 BUG_ON(zero_page == NULL); 235 - __free_page(zero_page); 235 + __free_pages(zero_page, compound_order(zero_page)); 236 236 return HPAGE_PMD_NR; 237 237 } 238 238