Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326054217.93492-1-harperchen1110@gmail.com

authored by

Wei Chen and committed by
Kalle Valo
5dbe1f8e 905a9241

+3 -3
+3 -3
drivers/net/wireless/realtek/rtlwifi/debug.c
··· 278 278 279 279 tmp_len = (count > sizeof(tmp) - 1 ? sizeof(tmp) - 1 : count); 280 280 281 - if (!buffer || copy_from_user(tmp, buffer, tmp_len)) 282 - return count; 281 + if (copy_from_user(tmp, buffer, tmp_len)) 282 + return -EFAULT; 283 283 284 284 tmp[tmp_len] = '\0'; 285 285 ··· 287 287 num = sscanf(tmp, "%x %x %x", &addr, &val, &len); 288 288 289 289 if (num != 3) 290 - return count; 290 + return -EINVAL; 291 291 292 292 switch (len) { 293 293 case 1: