Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/qxl: replace idr_init() by idr_init_base()

idr_init() uses base 0 which is an invalid identifier for this driver.
The idr_alloc for this driver uses 1 as start value for ID range. The
new function idr_init_base allows IDR to set the ID lookup from base 1.
This avoids all lookups that otherwise starts from 0 since 0 is always
unused / available.

References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20201105185016.GA71797@localhost
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

authored by

Deepak R Varma and committed by
Gerd Hoffmann
5d4c1edf 44510939

+2 -2
+2 -2
drivers/gpu/drm/qxl/qxl_kms.c
··· 231 231 goto cursor_ring_free; 232 232 } 233 233 234 - idr_init(&qdev->release_idr); 234 + idr_init_base(&qdev->release_idr, 1); 235 235 spin_lock_init(&qdev->release_idr_lock); 236 236 spin_lock_init(&qdev->release_lock); 237 237 238 - idr_init(&qdev->surf_id_idr); 238 + idr_init_base(&qdev->surf_id_idr, 1); 239 239 spin_lock_init(&qdev->surf_id_idr_lock); 240 240 241 241 mutex_init(&qdev->async_io_mutex);