Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'firewire-updates-6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394

Pull firewire updates from Takashi Sakamoto:
"A few updates for the 6.13 kernel, including some typo corrections in
the software stack and some fixes for tools. Additionally, it includes
a change resulting from the deprecation of a kernel API in the PCI
subsystem"

* tag 'firewire-updates-6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394:
tools/firewire: Fix several incorrect format specifiers
firewire: ohci: Replace deprecated PCI functions
firewire: Correct some typos

+11 -12
+1 -1
drivers/firewire/core-topology.c
··· 56 56 * two cases: either the path goes through this node, in which case 57 57 * the hop count is the sum of the two biggest child depths plus 2. 58 58 * Or it could be the case that the max hop path is entirely 59 - * containted in a child tree, in which case the max hop count is just 59 + * contained in a child tree, in which case the max hop count is just 60 60 * the max hop count of this child. 61 61 */ 62 62 static void update_hop_count(struct fw_node *node)
+1 -1
drivers/firewire/core.h
··· 80 80 /* 81 81 * Allow the specified node ID to do direct DMA out and in of 82 82 * host memory. The card will disable this for all node when 83 - * a bus reset happens, so driver need to reenable this after 83 + * a bus reset happens, so driver need to re-enable this after 84 84 * bus reset. Returns 0 on success, -ENODEV if the card 85 85 * doesn't support this, -ESTALE if the generation doesn't 86 86 * match.
+5 -6
drivers/firewire/ohci.c
··· 1384 1384 }; 1385 1385 1386 1386 /* 1387 - * This function apppends a packet to the DMA queue for transmission. 1387 + * This function appends a packet to the DMA queue for transmission. 1388 1388 * Must always be called with the ochi->lock held to ensure proper 1389 1389 * generation handling and locking around packet queue manipulation. 1390 1390 */ ··· 2213 2213 2214 2214 if (unlikely(param_debug > 0)) { 2215 2215 dev_notice_ratelimited(ohci->card.device, 2216 - "The debug parameter is superceded by tracepoints events, and deprecated."); 2216 + "The debug parameter is superseded by tracepoints events, and deprecated."); 2217 2217 } 2218 2218 2219 2219 /* ··· 2614 2614 * ConfigRomHeader and BusOptions doesn't honor the 2615 2615 * noByteSwapData bit, so with a be32 config rom, the 2616 2616 * controller will load be32 values in to these registers 2617 - * during the atomic update, even on litte endian 2617 + * during the atomic update, even on little endian 2618 2618 * architectures. The workaround we use is to put a 0 in the 2619 2619 * header quadlet; 0 is endian agnostic and means that the 2620 2620 * config rom isn't ready yet. In the bus reset tasklet we ··· 3726 3726 return -ENXIO; 3727 3727 } 3728 3728 3729 - err = pcim_iomap_regions(dev, 1 << 0, ohci_driver_name); 3730 - if (err) { 3729 + ohci->registers = pcim_iomap_region(dev, 0, ohci_driver_name); 3730 + if (IS_ERR(ohci->registers)) { 3731 3731 ohci_err(ohci, "request and map MMIO resource unavailable\n"); 3732 3732 return -ENXIO; 3733 3733 } 3734 - ohci->registers = pcim_iomap_table(dev)[0]; 3735 3734 3736 3735 for (i = 0; i < ARRAY_SIZE(ohci_quirks); i++) 3737 3736 if ((ohci_quirks[i].vendor == dev->vendor) &&
+1 -1
tools/firewire/decode-fcp.c
··· 160 160 name = info->name; 161 161 } 162 162 163 - printf("av/c %s, subunit_type=%s, subunit_id=%d, opcode=%s", 163 + printf("av/c %s, subunit_type=%s, subunit_id=%u, opcode=%s", 164 164 ctype_names[frame->ctype], subunit_type_names[frame->subunit_type], 165 165 frame->subunit_id, name); 166 166
+3 -3
tools/firewire/nosy-dump.c
··· 771 771 if (pp->phy_config.set_root) 772 772 printf(" set_root_id=%02x", pp->phy_config.root_id); 773 773 if (pp->phy_config.set_gap_count) 774 - printf(" set_gap_count=%d", pp->phy_config.gap_count); 774 + printf(" set_gap_count=%u", pp->phy_config.gap_count); 775 775 } 776 776 break; 777 777 ··· 781 781 782 782 case PHY_PACKET_SELF_ID: 783 783 if (pp->self_id.extended) { 784 - printf("extended self id: phy_id=%02x, seq=%d", 784 + printf("extended self id: phy_id=%02x, seq=%u", 785 785 pp->ext_self_id.phy_id, pp->ext_self_id.sequence); 786 786 } else { 787 787 static const char * const speed_names[] = { 788 788 "S100", "S200", "S400", "BETA" 789 789 }; 790 - printf("self id: phy_id=%02x, link %s, gap_count=%d, speed=%s%s%s", 790 + printf("self id: phy_id=%02x, link %s, gap_count=%u speed=%s%s%s", 791 791 pp->self_id.phy_id, 792 792 (pp->self_id.link_active ? "active" : "not active"), 793 793 pp->self_id.gap_count,