Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

9p: Reduce object size with CONFIG_NET_9P_DEBUG

Reduce object size by deduplicating formats.

Use vsprintf extension %pV.
Rename P9_DPRINTK uses to p9_debug, align arguments.
Add function for _p9_debug and macro to add __func__.
Add missing "\n"s to p9_debug uses.
Remove embedded function names as p9_debug adds it.
Remove P9_EPRINTK macro and convert use to pr_<level>.
Add and use pr_fmt and pr_<level>.

$ size fs/9p/built-in.o*
text data bss dec hex filename
62133 984 16000 79117 1350d fs/9p/built-in.o.new
67342 984 16928 85254 14d06 fs/9p/built-in.o.old
$ size net/9p/built-in.o*
text data bss dec hex filename
88792 4148 22024 114964 1c114 net/9p/built-in.o.new
94072 4148 23232 121452 1da6c net/9p/built-in.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>

authored by

Joe Perches and committed by
Eric Van Hensbergen
5d385153 a0ea787b

+452 -439
+32 -32
fs/9p/cache.c
··· 62 62 uint16_t klen = 0; 63 63 64 64 v9ses = (struct v9fs_session_info *)cookie_netfs_data; 65 - P9_DPRINTK(P9_DEBUG_FSC, "session %p buf %p size %u", v9ses, 66 - buffer, bufmax); 65 + p9_debug(P9_DEBUG_FSC, "session %p buf %p size %u\n", 66 + v9ses, buffer, bufmax); 67 67 68 68 if (v9ses->cachetag) 69 69 klen = strlen(v9ses->cachetag); ··· 72 72 return 0; 73 73 74 74 memcpy(buffer, v9ses->cachetag, klen); 75 - P9_DPRINTK(P9_DEBUG_FSC, "cache session tag %s", v9ses->cachetag); 75 + p9_debug(P9_DEBUG_FSC, "cache session tag %s\n", v9ses->cachetag); 76 76 return klen; 77 77 } 78 78 ··· 91 91 v9ses->fscache = fscache_acquire_cookie(v9fs_cache_netfs.primary_index, 92 92 &v9fs_cache_session_index_def, 93 93 v9ses); 94 - P9_DPRINTK(P9_DEBUG_FSC, "session %p get cookie %p", v9ses, 95 - v9ses->fscache); 94 + p9_debug(P9_DEBUG_FSC, "session %p get cookie %p\n", 95 + v9ses, v9ses->fscache); 96 96 } 97 97 98 98 void v9fs_cache_session_put_cookie(struct v9fs_session_info *v9ses) 99 99 { 100 - P9_DPRINTK(P9_DEBUG_FSC, "session %p put cookie %p", v9ses, 101 - v9ses->fscache); 100 + p9_debug(P9_DEBUG_FSC, "session %p put cookie %p\n", 101 + v9ses, v9ses->fscache); 102 102 fscache_relinquish_cookie(v9ses->fscache, 0); 103 103 v9ses->fscache = NULL; 104 104 } ··· 109 109 { 110 110 const struct v9fs_inode *v9inode = cookie_netfs_data; 111 111 memcpy(buffer, &v9inode->qid.path, sizeof(v9inode->qid.path)); 112 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p get key %llu", &v9inode->vfs_inode, 113 - v9inode->qid.path); 112 + p9_debug(P9_DEBUG_FSC, "inode %p get key %llu\n", 113 + &v9inode->vfs_inode, v9inode->qid.path); 114 114 return sizeof(v9inode->qid.path); 115 115 } 116 116 ··· 120 120 const struct v9fs_inode *v9inode = cookie_netfs_data; 121 121 *size = i_size_read(&v9inode->vfs_inode); 122 122 123 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p get attr %llu", &v9inode->vfs_inode, 124 - *size); 123 + p9_debug(P9_DEBUG_FSC, "inode %p get attr %llu\n", 124 + &v9inode->vfs_inode, *size); 125 125 } 126 126 127 127 static uint16_t v9fs_cache_inode_get_aux(const void *cookie_netfs_data, ··· 129 129 { 130 130 const struct v9fs_inode *v9inode = cookie_netfs_data; 131 131 memcpy(buffer, &v9inode->qid.version, sizeof(v9inode->qid.version)); 132 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p get aux %u", &v9inode->vfs_inode, 133 - v9inode->qid.version); 132 + p9_debug(P9_DEBUG_FSC, "inode %p get aux %u\n", 133 + &v9inode->vfs_inode, v9inode->qid.version); 134 134 return sizeof(v9inode->qid.version); 135 135 } 136 136 ··· 206 206 &v9fs_cache_inode_index_def, 207 207 v9inode); 208 208 209 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p get cookie %p", inode, 210 - v9inode->fscache); 209 + p9_debug(P9_DEBUG_FSC, "inode %p get cookie %p\n", 210 + inode, v9inode->fscache); 211 211 } 212 212 213 213 void v9fs_cache_inode_put_cookie(struct inode *inode) ··· 216 216 217 217 if (!v9inode->fscache) 218 218 return; 219 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p put cookie %p", inode, 220 - v9inode->fscache); 219 + p9_debug(P9_DEBUG_FSC, "inode %p put cookie %p\n", 220 + inode, v9inode->fscache); 221 221 222 222 fscache_relinquish_cookie(v9inode->fscache, 0); 223 223 v9inode->fscache = NULL; ··· 229 229 230 230 if (!v9inode->fscache) 231 231 return; 232 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p flush cookie %p", inode, 233 - v9inode->fscache); 232 + p9_debug(P9_DEBUG_FSC, "inode %p flush cookie %p\n", 233 + inode, v9inode->fscache); 234 234 235 235 fscache_relinquish_cookie(v9inode->fscache, 1); 236 236 v9inode->fscache = NULL; ··· 272 272 v9inode->fscache = fscache_acquire_cookie(v9ses->fscache, 273 273 &v9fs_cache_inode_index_def, 274 274 v9inode); 275 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p revalidating cookie old %p new %p", 276 - inode, old, v9inode->fscache); 275 + p9_debug(P9_DEBUG_FSC, "inode %p revalidating cookie old %p new %p\n", 276 + inode, old, v9inode->fscache); 277 277 278 278 spin_unlock(&v9inode->fscache_lock); 279 279 } ··· 323 323 int ret; 324 324 const struct v9fs_inode *v9inode = V9FS_I(inode); 325 325 326 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p page %p", inode, page); 326 + p9_debug(P9_DEBUG_FSC, "inode %p page %p\n", inode, page); 327 327 if (!v9inode->fscache) 328 328 return -ENOBUFS; 329 329 ··· 335 335 switch (ret) { 336 336 case -ENOBUFS: 337 337 case -ENODATA: 338 - P9_DPRINTK(P9_DEBUG_FSC, "page/inode not in cache %d", ret); 338 + p9_debug(P9_DEBUG_FSC, "page/inode not in cache %d\n", ret); 339 339 return 1; 340 340 case 0: 341 - P9_DPRINTK(P9_DEBUG_FSC, "BIO submitted"); 341 + p9_debug(P9_DEBUG_FSC, "BIO submitted\n"); 342 342 return ret; 343 343 default: 344 - P9_DPRINTK(P9_DEBUG_FSC, "ret %d", ret); 344 + p9_debug(P9_DEBUG_FSC, "ret %d\n", ret); 345 345 return ret; 346 346 } 347 347 } ··· 361 361 int ret; 362 362 const struct v9fs_inode *v9inode = V9FS_I(inode); 363 363 364 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p pages %u", inode, *nr_pages); 364 + p9_debug(P9_DEBUG_FSC, "inode %p pages %u\n", inode, *nr_pages); 365 365 if (!v9inode->fscache) 366 366 return -ENOBUFS; 367 367 ··· 373 373 switch (ret) { 374 374 case -ENOBUFS: 375 375 case -ENODATA: 376 - P9_DPRINTK(P9_DEBUG_FSC, "pages/inodes not in cache %d", ret); 376 + p9_debug(P9_DEBUG_FSC, "pages/inodes not in cache %d\n", ret); 377 377 return 1; 378 378 case 0: 379 379 BUG_ON(!list_empty(pages)); 380 380 BUG_ON(*nr_pages != 0); 381 - P9_DPRINTK(P9_DEBUG_FSC, "BIO submitted"); 381 + p9_debug(P9_DEBUG_FSC, "BIO submitted\n"); 382 382 return ret; 383 383 default: 384 - P9_DPRINTK(P9_DEBUG_FSC, "ret %d", ret); 384 + p9_debug(P9_DEBUG_FSC, "ret %d\n", ret); 385 385 return ret; 386 386 } 387 387 } ··· 396 396 int ret; 397 397 const struct v9fs_inode *v9inode = V9FS_I(inode); 398 398 399 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p page %p", inode, page); 399 + p9_debug(P9_DEBUG_FSC, "inode %p page %p\n", inode, page); 400 400 ret = fscache_write_page(v9inode->fscache, page, GFP_KERNEL); 401 - P9_DPRINTK(P9_DEBUG_FSC, "ret = %d", ret); 401 + p9_debug(P9_DEBUG_FSC, "ret = %d\n", ret); 402 402 if (ret != 0) 403 403 v9fs_uncache_page(inode, page); 404 404 } ··· 409 409 void __v9fs_fscache_wait_on_page_write(struct inode *inode, struct page *page) 410 410 { 411 411 const struct v9fs_inode *v9inode = V9FS_I(inode); 412 - P9_DPRINTK(P9_DEBUG_FSC, "inode %p page %p", inode, page); 412 + p9_debug(P9_DEBUG_FSC, "inode %p page %p\n", inode, page); 413 413 if (PageFsCache(page)) 414 414 fscache_wait_on_page_write(v9inode->fscache, page); 415 415 }
+4 -4
fs/9p/fid.c
··· 45 45 { 46 46 struct v9fs_dentry *dent; 47 47 48 - P9_DPRINTK(P9_DEBUG_VFS, "fid %d dentry %s\n", 49 - fid->fid, dentry->d_name.name); 48 + p9_debug(P9_DEBUG_VFS, "fid %d dentry %s\n", 49 + fid->fid, dentry->d_name.name); 50 50 51 51 dent = dentry->d_fsdata; 52 52 if (!dent) { ··· 79 79 struct v9fs_dentry *dent; 80 80 struct p9_fid *fid, *ret; 81 81 82 - P9_DPRINTK(P9_DEBUG_VFS, " dentry: %s (%p) uid %d any %d\n", 83 - dentry->d_name.name, dentry, uid, any); 82 + p9_debug(P9_DEBUG_VFS, " dentry: %s (%p) uid %d any %d\n", 83 + dentry->d_name.name, dentry, uid, any); 84 84 dent = (struct v9fs_dentry *) dentry->d_fsdata; 85 85 ret = NULL; 86 86 if (dent) {
+30 -29
fs/9p/v9fs.c
··· 23 23 * 24 24 */ 25 25 26 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 27 + 26 28 #include <linux/module.h> 27 29 #include <linux/errno.h> 28 30 #include <linux/fs.h> ··· 87 85 88 86 if (!strcmp(s, "loose")) { 89 87 version = CACHE_LOOSE; 90 - P9_DPRINTK(P9_DEBUG_9P, "Cache mode: loose\n"); 88 + p9_debug(P9_DEBUG_9P, "Cache mode: loose\n"); 91 89 } else if (!strcmp(s, "fscache")) { 92 90 version = CACHE_FSCACHE; 93 - P9_DPRINTK(P9_DEBUG_9P, "Cache mode: fscache\n"); 91 + p9_debug(P9_DEBUG_9P, "Cache mode: fscache\n"); 94 92 } else if (!strcmp(s, "none")) { 95 93 version = CACHE_NONE; 96 - P9_DPRINTK(P9_DEBUG_9P, "Cache mode: none\n"); 94 + p9_debug(P9_DEBUG_9P, "Cache mode: none\n"); 97 95 } else 98 - printk(KERN_INFO "9p: Unknown Cache mode %s.\n", s); 96 + pr_info("Unknown Cache mode %s\n", s); 99 97 return version; 100 98 } 101 99 ··· 142 140 case Opt_debug: 143 141 r = match_int(&args[0], &option); 144 142 if (r < 0) { 145 - P9_DPRINTK(P9_DEBUG_ERROR, 146 - "integer field, but no integer?\n"); 143 + p9_debug(P9_DEBUG_ERROR, 144 + "integer field, but no integer?\n"); 147 145 ret = r; 148 146 continue; 149 147 } ··· 156 154 case Opt_dfltuid: 157 155 r = match_int(&args[0], &option); 158 156 if (r < 0) { 159 - P9_DPRINTK(P9_DEBUG_ERROR, 160 - "integer field, but no integer?\n"); 157 + p9_debug(P9_DEBUG_ERROR, 158 + "integer field, but no integer?\n"); 161 159 ret = r; 162 160 continue; 163 161 } ··· 166 164 case Opt_dfltgid: 167 165 r = match_int(&args[0], &option); 168 166 if (r < 0) { 169 - P9_DPRINTK(P9_DEBUG_ERROR, 170 - "integer field, but no integer?\n"); 167 + p9_debug(P9_DEBUG_ERROR, 168 + "integer field, but no integer?\n"); 171 169 ret = r; 172 170 continue; 173 171 } ··· 176 174 case Opt_afid: 177 175 r = match_int(&args[0], &option); 178 176 if (r < 0) { 179 - P9_DPRINTK(P9_DEBUG_ERROR, 180 - "integer field, but no integer?\n"); 177 + p9_debug(P9_DEBUG_ERROR, 178 + "integer field, but no integer?\n"); 181 179 ret = r; 182 180 continue; 183 181 } ··· 207 205 s = match_strdup(&args[0]); 208 206 if (!s) { 209 207 ret = -ENOMEM; 210 - P9_DPRINTK(P9_DEBUG_ERROR, 211 - "problem allocating copy of cache arg\n"); 208 + p9_debug(P9_DEBUG_ERROR, 209 + "problem allocating copy of cache arg\n"); 212 210 goto free_and_return; 213 211 } 214 212 ret = get_cache_mode(s); ··· 225 223 s = match_strdup(&args[0]); 226 224 if (!s) { 227 225 ret = -ENOMEM; 228 - P9_DPRINTK(P9_DEBUG_ERROR, 229 - "problem allocating copy of access arg\n"); 226 + p9_debug(P9_DEBUG_ERROR, 227 + "problem allocating copy of access arg\n"); 230 228 goto free_and_return; 231 229 } 232 230 ··· 242 240 v9ses->uid = simple_strtoul(s, &e, 10); 243 241 if (*e != '\0') { 244 242 ret = -EINVAL; 245 - printk(KERN_INFO "9p: Unknown access " 246 - "argument %s.\n", s); 243 + pr_info("Unknown access argument %s\n", 244 + s); 247 245 kfree(s); 248 246 goto free_and_return; 249 247 } ··· 256 254 #ifdef CONFIG_9P_FS_POSIX_ACL 257 255 v9ses->flags |= V9FS_POSIX_ACL; 258 256 #else 259 - P9_DPRINTK(P9_DEBUG_ERROR, 260 - "Not defined CONFIG_9P_FS_POSIX_ACL. " 261 - "Ignoring posixacl option\n"); 257 + p9_debug(P9_DEBUG_ERROR, 258 + "Not defined CONFIG_9P_FS_POSIX_ACL. Ignoring posixacl option\n"); 262 259 #endif 263 260 break; 264 261 ··· 319 318 if (IS_ERR(v9ses->clnt)) { 320 319 retval = PTR_ERR(v9ses->clnt); 321 320 v9ses->clnt = NULL; 322 - P9_DPRINTK(P9_DEBUG_ERROR, "problem initializing 9p client\n"); 321 + p9_debug(P9_DEBUG_ERROR, "problem initializing 9p client\n"); 323 322 goto error; 324 323 } 325 324 ··· 372 371 if (IS_ERR(fid)) { 373 372 retval = PTR_ERR(fid); 374 373 fid = NULL; 375 - P9_DPRINTK(P9_DEBUG_ERROR, "cannot attach\n"); 374 + p9_debug(P9_DEBUG_ERROR, "cannot attach\n"); 376 375 goto error; 377 376 } 378 377 ··· 430 429 */ 431 430 432 431 void v9fs_session_cancel(struct v9fs_session_info *v9ses) { 433 - P9_DPRINTK(P9_DEBUG_ERROR, "cancel session %p\n", v9ses); 432 + p9_debug(P9_DEBUG_ERROR, "cancel session %p\n", v9ses); 434 433 p9_client_disconnect(v9ses->clnt); 435 434 } 436 435 ··· 443 442 444 443 void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses) 445 444 { 446 - P9_DPRINTK(P9_DEBUG_ERROR, "begin cancel session %p\n", v9ses); 445 + p9_debug(P9_DEBUG_ERROR, "begin cancel session %p\n", v9ses); 447 446 p9_client_begin_disconnect(v9ses->clnt); 448 447 } 449 448 ··· 592 591 static int __init init_v9fs(void) 593 592 { 594 593 int err; 595 - printk(KERN_INFO "Installing v9fs 9p2000 file system support\n"); 594 + pr_info("Installing v9fs 9p2000 file system support\n"); 596 595 /* TODO: Setup list of registered trasnport modules */ 597 596 err = register_filesystem(&v9fs_fs_type); 598 597 if (err < 0) { 599 - printk(KERN_ERR "Failed to register filesystem\n"); 598 + pr_err("Failed to register filesystem\n"); 600 599 return err; 601 600 } 602 601 603 602 err = v9fs_cache_register(); 604 603 if (err < 0) { 605 - printk(KERN_ERR "Failed to register v9fs for caching\n"); 604 + pr_err("Failed to register v9fs for caching\n"); 606 605 goto out_fs_unreg; 607 606 } 608 607 609 608 err = v9fs_sysfs_init(); 610 609 if (err < 0) { 611 - printk(KERN_ERR "Failed to register with sysfs\n"); 610 + pr_err("Failed to register with sysfs\n"); 612 611 goto out_sysfs_cleanup; 613 612 } 614 613
+6 -7
fs/9p/vfs_addr.c
··· 56 56 struct inode *inode; 57 57 58 58 inode = page->mapping->host; 59 - P9_DPRINTK(P9_DEBUG_VFS, "\n"); 59 + p9_debug(P9_DEBUG_VFS, "\n"); 60 60 61 61 BUG_ON(!PageLocked(page)); 62 62 ··· 116 116 struct inode *inode; 117 117 118 118 inode = mapping->host; 119 - P9_DPRINTK(P9_DEBUG_VFS, "inode: %p file: %p\n", inode, filp); 119 + p9_debug(P9_DEBUG_VFS, "inode: %p file: %p\n", inode, filp); 120 120 121 121 ret = v9fs_readpages_from_fscache(inode, mapping, pages, &nr_pages); 122 122 if (ret == 0) 123 123 return ret; 124 124 125 125 ret = read_cache_pages(mapping, pages, (void *)v9fs_vfs_readpage, filp); 126 - P9_DPRINTK(P9_DEBUG_VFS, " = %d\n", ret); 126 + p9_debug(P9_DEBUG_VFS, " = %d\n", ret); 127 127 return ret; 128 128 } 129 129 ··· 263 263 * Now that we do caching with cache mode enabled, We need 264 264 * to support direct IO 265 265 */ 266 - P9_DPRINTK(P9_DEBUG_VFS, "v9fs_direct_IO: v9fs_direct_IO (%s) " 267 - "off/no(%lld/%lu) EINVAL\n", 268 - iocb->ki_filp->f_path.dentry->d_name.name, 269 - (long long) pos, nr_segs); 266 + p9_debug(P9_DEBUG_VFS, "v9fs_direct_IO: v9fs_direct_IO (%s) off/no(%lld/%lu) EINVAL\n", 267 + iocb->ki_filp->f_path.dentry->d_name.name, 268 + (long long)pos, nr_segs); 270 269 271 270 return -EINVAL; 272 271 }
+6 -6
fs/9p/vfs_dentry.c
··· 53 53 54 54 static int v9fs_dentry_delete(const struct dentry *dentry) 55 55 { 56 - P9_DPRINTK(P9_DEBUG_VFS, " dentry: %s (%p)\n", dentry->d_name.name, 57 - dentry); 56 + p9_debug(P9_DEBUG_VFS, " dentry: %s (%p)\n", 57 + dentry->d_name.name, dentry); 58 58 59 59 return 1; 60 60 } ··· 66 66 */ 67 67 static int v9fs_cached_dentry_delete(const struct dentry *dentry) 68 68 { 69 - P9_DPRINTK(P9_DEBUG_VFS, " dentry: %s (%p)\n", 70 - dentry->d_name.name, dentry); 69 + p9_debug(P9_DEBUG_VFS, " dentry: %s (%p)\n", 70 + dentry->d_name.name, dentry); 71 71 72 72 /* Don't cache negative dentries */ 73 73 if (!dentry->d_inode) ··· 86 86 struct v9fs_dentry *dent; 87 87 struct p9_fid *temp, *current_fid; 88 88 89 - P9_DPRINTK(P9_DEBUG_VFS, " dentry: %s (%p)\n", dentry->d_name.name, 90 - dentry); 89 + p9_debug(P9_DEBUG_VFS, " dentry: %s (%p)\n", 90 + dentry->d_name.name, dentry); 91 91 dent = dentry->d_fsdata; 92 92 if (dent) { 93 93 list_for_each_entry_safe(current_fid, temp, &dent->fidlist,
+6 -7
fs/9p/vfs_dir.c
··· 140 140 int reclen = 0; 141 141 struct p9_rdir *rdir; 142 142 143 - P9_DPRINTK(P9_DEBUG_VFS, "name %s\n", filp->f_path.dentry->d_name.name); 143 + p9_debug(P9_DEBUG_VFS, "name %s\n", filp->f_path.dentry->d_name.name); 144 144 fid = filp->private_data; 145 145 146 146 buflen = fid->clnt->msize - P9_IOHDRSZ; ··· 168 168 err = p9stat_read(fid->clnt, rdir->buf + rdir->head, 169 169 rdir->tail - rdir->head, &st); 170 170 if (err) { 171 - P9_DPRINTK(P9_DEBUG_VFS, "returned %d\n", err); 171 + p9_debug(P9_DEBUG_VFS, "returned %d\n", err); 172 172 err = -EIO; 173 173 p9stat_free(&st); 174 174 goto unlock_and_exit; ··· 213 213 struct p9_dirent curdirent; 214 214 u64 oldoffset = 0; 215 215 216 - P9_DPRINTK(P9_DEBUG_VFS, "name %s\n", filp->f_path.dentry->d_name.name); 216 + p9_debug(P9_DEBUG_VFS, "name %s\n", filp->f_path.dentry->d_name.name); 217 217 fid = filp->private_data; 218 218 219 219 buflen = fid->clnt->msize - P9_READDIRHDRSZ; ··· 244 244 rdir->tail - rdir->head, 245 245 &curdirent); 246 246 if (err < 0) { 247 - P9_DPRINTK(P9_DEBUG_VFS, "returned %d\n", err); 247 + p9_debug(P9_DEBUG_VFS, "returned %d\n", err); 248 248 err = -EIO; 249 249 goto unlock_and_exit; 250 250 } ··· 290 290 struct p9_fid *fid; 291 291 292 292 fid = filp->private_data; 293 - P9_DPRINTK(P9_DEBUG_VFS, 294 - "v9fs_dir_release: inode: %p filp: %p fid: %d\n", 295 - inode, filp, fid ? fid->fid : -1); 293 + p9_debug(P9_DEBUG_VFS, "inode: %p filp: %p fid: %d\n", 294 + inode, filp, fid ? fid->fid : -1); 296 295 if (fid) 297 296 p9_client_clunk(fid); 298 297 return 0;
+15 -16
fs/9p/vfs_file.c
··· 61 61 struct p9_fid *fid; 62 62 int omode; 63 63 64 - P9_DPRINTK(P9_DEBUG_VFS, "inode: %p file: %p\n", inode, file); 64 + p9_debug(P9_DEBUG_VFS, "inode: %p file: %p\n", inode, file); 65 65 v9inode = V9FS_I(inode); 66 66 v9ses = v9fs_inode2v9ses(inode); 67 67 if (v9fs_proto_dotl(v9ses)) ··· 135 135 int res = 0; 136 136 struct inode *inode = filp->f_path.dentry->d_inode; 137 137 138 - P9_DPRINTK(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl); 138 + p9_debug(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl); 139 139 140 140 /* No mandatory locks */ 141 141 if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK) ··· 305 305 struct inode *inode = filp->f_path.dentry->d_inode; 306 306 int ret = -ENOLCK; 307 307 308 - P9_DPRINTK(P9_DEBUG_VFS, "filp: %p cmd:%d lock: %p name: %s\n", filp, 309 - cmd, fl, filp->f_path.dentry->d_name.name); 308 + p9_debug(P9_DEBUG_VFS, "filp: %p cmd:%d lock: %p name: %s\n", 309 + filp, cmd, fl, filp->f_path.dentry->d_name.name); 310 310 311 311 /* No mandatory locks */ 312 312 if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK) ··· 341 341 struct inode *inode = filp->f_path.dentry->d_inode; 342 342 int ret = -ENOLCK; 343 343 344 - P9_DPRINTK(P9_DEBUG_VFS, "filp: %p cmd:%d lock: %p name: %s\n", filp, 345 - cmd, fl, filp->f_path.dentry->d_name.name); 344 + p9_debug(P9_DEBUG_VFS, "filp: %p cmd:%d lock: %p name: %s\n", 345 + filp, cmd, fl, filp->f_path.dentry->d_name.name); 346 346 347 347 /* No mandatory locks */ 348 348 if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK) ··· 385 385 { 386 386 int n, total, size; 387 387 388 - P9_DPRINTK(P9_DEBUG_VFS, "fid %d offset %llu count %d\n", fid->fid, 389 - (long long unsigned) offset, count); 388 + p9_debug(P9_DEBUG_VFS, "fid %d offset %llu count %d\n", 389 + fid->fid, (long long unsigned)offset, count); 390 390 n = 0; 391 391 total = 0; 392 392 size = fid->iounit ? fid->iounit : fid->clnt->msize - P9_IOHDRSZ; ··· 444 444 struct p9_fid *fid; 445 445 size_t size; 446 446 447 - P9_DPRINTK(P9_DEBUG_VFS, "count %zu offset %lld\n", count, *offset); 447 + p9_debug(P9_DEBUG_VFS, "count %zu offset %lld\n", count, *offset); 448 448 fid = filp->private_data; 449 449 450 450 size = fid->iounit ? fid->iounit : fid->clnt->msize - P9_IOHDRSZ; ··· 471 471 loff_t origin = *offset; 472 472 unsigned long pg_start, pg_end; 473 473 474 - P9_DPRINTK(P9_DEBUG_VFS, "data %p count %d offset %x\n", data, 475 - (int)count, (int)*offset); 474 + p9_debug(P9_DEBUG_VFS, "data %p count %d offset %x\n", 475 + data, (int)count, (int)*offset); 476 476 477 477 clnt = fid->clnt; 478 478 do { ··· 553 553 return retval; 554 554 555 555 mutex_lock(&inode->i_mutex); 556 - P9_DPRINTK(P9_DEBUG_VFS, "filp %p datasync %x\n", filp, datasync); 556 + p9_debug(P9_DEBUG_VFS, "filp %p datasync %x\n", filp, datasync); 557 557 558 558 fid = filp->private_data; 559 559 v9fs_blank_wstat(&wstat); ··· 576 576 return retval; 577 577 578 578 mutex_lock(&inode->i_mutex); 579 - P9_DPRINTK(P9_DEBUG_VFS, "v9fs_file_fsync_dotl: filp %p datasync %x\n", 580 - filp, datasync); 579 + p9_debug(P9_DEBUG_VFS, "filp %p datasync %x\n", filp, datasync); 581 580 582 581 fid = filp->private_data; 583 582 ··· 607 608 struct inode *inode = filp->f_path.dentry->d_inode; 608 609 609 610 610 - P9_DPRINTK(P9_DEBUG_VFS, "page %p fid %lx\n", 611 - page, (unsigned long)filp->private_data); 611 + p9_debug(P9_DEBUG_VFS, "page %p fid %lx\n", 612 + page, (unsigned long)filp->private_data); 612 613 613 614 v9inode = V9FS_I(inode); 614 615 /* make sure the cache has finished storing the page */
+43 -43
fs/9p/vfs_inode.c
··· 23 23 * 24 24 */ 25 25 26 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 27 + 26 28 #include <linux/module.h> 27 29 #include <linux/errno.h> 28 30 #include <linux/fs.h> ··· 135 133 res |= S_IFBLK; 136 134 break; 137 135 default: 138 - P9_DPRINTK(P9_DEBUG_ERROR, 139 - "Unknown special type %c %s\n", type, 140 - stat->extension); 136 + p9_debug(P9_DEBUG_ERROR, "Unknown special type %c %s\n", 137 + type, stat->extension); 141 138 }; 142 139 *rdev = MKDEV(major, minor); 143 140 } else ··· 282 281 } else if (v9fs_proto_dotu(v9ses)) { 283 282 inode->i_op = &v9fs_file_inode_operations; 284 283 } else { 285 - P9_DPRINTK(P9_DEBUG_ERROR, 286 - "special files without extended mode\n"); 284 + p9_debug(P9_DEBUG_ERROR, 285 + "special files without extended mode\n"); 287 286 err = -EINVAL; 288 287 goto error; 289 288 } ··· 308 307 break; 309 308 case S_IFLNK: 310 309 if (!v9fs_proto_dotu(v9ses) && !v9fs_proto_dotl(v9ses)) { 311 - P9_DPRINTK(P9_DEBUG_ERROR, "extended modes used with " 312 - "legacy protocol.\n"); 310 + p9_debug(P9_DEBUG_ERROR, 311 + "extended modes used with legacy protocol\n"); 313 312 err = -EINVAL; 314 313 goto error; 315 314 } ··· 336 335 337 336 break; 338 337 default: 339 - P9_DPRINTK(P9_DEBUG_ERROR, "BAD mode 0x%x S_IFMT 0x%x\n", 340 - mode, mode & S_IFMT); 338 + p9_debug(P9_DEBUG_ERROR, "BAD mode 0x%x S_IFMT 0x%x\n", 339 + mode, mode & S_IFMT); 341 340 err = -EINVAL; 342 341 goto error; 343 342 } ··· 359 358 struct inode *inode; 360 359 struct v9fs_session_info *v9ses = sb->s_fs_info; 361 360 362 - P9_DPRINTK(P9_DEBUG_VFS, "super block: %p mode: %o\n", sb, mode); 361 + p9_debug(P9_DEBUG_VFS, "super block: %p mode: %o\n", sb, mode); 363 362 364 363 inode = new_inode(sb); 365 364 if (!inode) { 366 - P9_EPRINTK(KERN_WARNING, "Problem allocating inode\n"); 365 + pr_warn("%s (%d): Problem allocating inode\n", 366 + __func__, task_pid_nr(current)); 367 367 return ERR_PTR(-ENOMEM); 368 368 } 369 369 err = v9fs_init_inode(v9ses, inode, mode, rdev); ··· 580 578 struct p9_fid *v9fid, *dfid; 581 579 struct v9fs_session_info *v9ses; 582 580 583 - P9_DPRINTK(P9_DEBUG_VFS, "inode: %p dentry: %p rmdir: %x\n", 584 - dir, dentry, flags); 581 + p9_debug(P9_DEBUG_VFS, "inode: %p dentry: %p rmdir: %x\n", 582 + dir, dentry, flags); 585 583 586 584 v9ses = v9fs_inode2v9ses(dir); 587 585 inode = dentry->d_inode; 588 586 dfid = v9fs_fid_lookup(dentry->d_parent); 589 587 if (IS_ERR(dfid)) { 590 588 retval = PTR_ERR(dfid); 591 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", retval); 589 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", retval); 592 590 return retval; 593 591 } 594 592 if (v9fs_proto_dotl(v9ses)) ··· 637 635 struct p9_fid *dfid, *ofid, *fid; 638 636 struct inode *inode; 639 637 640 - P9_DPRINTK(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 638 + p9_debug(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 641 639 642 640 err = 0; 643 641 ofid = NULL; ··· 646 644 dfid = v9fs_fid_lookup(dentry->d_parent); 647 645 if (IS_ERR(dfid)) { 648 646 err = PTR_ERR(dfid); 649 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 647 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 650 648 return ERR_PTR(err); 651 649 } 652 650 ··· 654 652 ofid = p9_client_walk(dfid, 0, NULL, 1); 655 653 if (IS_ERR(ofid)) { 656 654 err = PTR_ERR(ofid); 657 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 655 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 658 656 return ERR_PTR(err); 659 657 } 660 658 661 659 err = p9_client_fcreate(ofid, name, perm, mode, extension); 662 660 if (err < 0) { 663 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_fcreate failed %d\n", err); 661 + p9_debug(P9_DEBUG_VFS, "p9_client_fcreate failed %d\n", err); 664 662 goto error; 665 663 } 666 664 ··· 668 666 fid = p9_client_walk(dfid, 1, &name, 1); 669 667 if (IS_ERR(fid)) { 670 668 err = PTR_ERR(fid); 671 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 669 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 672 670 fid = NULL; 673 671 goto error; 674 672 } ··· 677 675 inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); 678 676 if (IS_ERR(inode)) { 679 677 err = PTR_ERR(inode); 680 - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", err); 678 + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", err); 681 679 goto error; 682 680 } 683 681 err = v9fs_fid_add(dentry, fid); ··· 795 793 struct p9_fid *fid; 796 794 struct v9fs_session_info *v9ses; 797 795 798 - P9_DPRINTK(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 796 + p9_debug(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 799 797 err = 0; 800 798 v9ses = v9fs_inode2v9ses(dir); 801 799 perm = unixmode2p9mode(v9ses, mode | S_IFDIR); ··· 833 831 char *name; 834 832 int result = 0; 835 833 836 - P9_DPRINTK(P9_DEBUG_VFS, "dir: %p dentry: (%s) %p nameidata: %p\n", 837 - dir, dentry->d_name.name, dentry, nameidata); 834 + p9_debug(P9_DEBUG_VFS, "dir: %p dentry: (%s) %p nameidata: %p\n", 835 + dir, dentry->d_name.name, dentry, nameidata); 838 836 839 837 if (dentry->d_name.len > NAME_MAX) 840 838 return ERR_PTR(-ENAMETOOLONG); ··· 940 938 struct p9_fid *newdirfid; 941 939 struct p9_wstat wstat; 942 940 943 - P9_DPRINTK(P9_DEBUG_VFS, "\n"); 941 + p9_debug(P9_DEBUG_VFS, "\n"); 944 942 retval = 0; 945 943 old_inode = old_dentry->d_inode; 946 944 new_inode = new_dentry->d_inode; ··· 976 974 * 9P .u can only handle file rename in the same directory 977 975 */ 978 976 979 - P9_DPRINTK(P9_DEBUG_ERROR, 980 - "old dir and new dir are different\n"); 977 + p9_debug(P9_DEBUG_ERROR, "old dir and new dir are different\n"); 981 978 retval = -EXDEV; 982 979 goto clunk_newdir; 983 980 } ··· 1032 1031 struct p9_fid *fid; 1033 1032 struct p9_wstat *st; 1034 1033 1035 - P9_DPRINTK(P9_DEBUG_VFS, "dentry: %p\n", dentry); 1034 + p9_debug(P9_DEBUG_VFS, "dentry: %p\n", dentry); 1036 1035 err = -EPERM; 1037 1036 v9ses = v9fs_dentry2v9ses(dentry); 1038 1037 if (v9ses->cache == CACHE_LOOSE || v9ses->cache == CACHE_FSCACHE) { ··· 1069 1068 struct p9_fid *fid; 1070 1069 struct p9_wstat wstat; 1071 1070 1072 - P9_DPRINTK(P9_DEBUG_VFS, "\n"); 1071 + p9_debug(P9_DEBUG_VFS, "\n"); 1073 1072 retval = inode_change_ok(dentry->d_inode, iattr); 1074 1073 if (retval) 1075 1074 return retval; ··· 1214 1213 struct p9_fid *fid; 1215 1214 struct p9_wstat *st; 1216 1215 1217 - P9_DPRINTK(P9_DEBUG_VFS, " %s\n", dentry->d_name.name); 1216 + p9_debug(P9_DEBUG_VFS, " %s\n", dentry->d_name.name); 1218 1217 retval = -EPERM; 1219 1218 v9ses = v9fs_dentry2v9ses(dentry); 1220 1219 fid = v9fs_fid_lookup(dentry); ··· 1236 1235 /* copy extension buffer into buffer */ 1237 1236 strncpy(buffer, st->extension, buflen); 1238 1237 1239 - P9_DPRINTK(P9_DEBUG_VFS, 1240 - "%s -> %s (%s)\n", dentry->d_name.name, st->extension, buffer); 1238 + p9_debug(P9_DEBUG_VFS, "%s -> %s (%s)\n", 1239 + dentry->d_name.name, st->extension, buffer); 1241 1240 1242 1241 retval = strnlen(buffer, buflen); 1243 1242 done: ··· 1258 1257 int len = 0; 1259 1258 char *link = __getname(); 1260 1259 1261 - P9_DPRINTK(P9_DEBUG_VFS, "%s n", dentry->d_name.name); 1260 + p9_debug(P9_DEBUG_VFS, "%s\n", dentry->d_name.name); 1262 1261 1263 1262 if (!link) 1264 1263 link = ERR_PTR(-ENOMEM); ··· 1289 1288 { 1290 1289 char *s = nd_get_link(nd); 1291 1290 1292 - P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, 1293 - IS_ERR(s) ? "<error>" : s); 1291 + p9_debug(P9_DEBUG_VFS, " %s %s\n", 1292 + dentry->d_name.name, IS_ERR(s) ? "<error>" : s); 1294 1293 if (!IS_ERR(s)) 1295 1294 __putname(s); 1296 1295 } ··· 1313 1312 1314 1313 v9ses = v9fs_inode2v9ses(dir); 1315 1314 if (!v9fs_proto_dotu(v9ses)) { 1316 - P9_DPRINTK(P9_DEBUG_ERROR, "not extended\n"); 1315 + p9_debug(P9_DEBUG_ERROR, "not extended\n"); 1317 1316 return -EPERM; 1318 1317 } 1319 1318 ··· 1341 1340 static int 1342 1341 v9fs_vfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname) 1343 1342 { 1344 - P9_DPRINTK(P9_DEBUG_VFS, " %lu,%s,%s\n", dir->i_ino, 1345 - dentry->d_name.name, symname); 1343 + p9_debug(P9_DEBUG_VFS, " %lu,%s,%s\n", 1344 + dir->i_ino, dentry->d_name.name, symname); 1346 1345 1347 1346 return v9fs_vfs_mkspecial(dir, dentry, S_IFLNK, symname); 1348 1347 } ··· 1363 1362 char *name; 1364 1363 struct p9_fid *oldfid; 1365 1364 1366 - P9_DPRINTK(P9_DEBUG_VFS, 1367 - " %lu,%s,%s\n", dir->i_ino, dentry->d_name.name, 1368 - old_dentry->d_name.name); 1365 + p9_debug(P9_DEBUG_VFS, " %lu,%s,%s\n", 1366 + dir->i_ino, dentry->d_name.name, old_dentry->d_name.name); 1369 1367 1370 1368 oldfid = v9fs_fid_clone(old_dentry); 1371 1369 if (IS_ERR(oldfid)) ··· 1403 1403 int retval; 1404 1404 char *name; 1405 1405 1406 - P9_DPRINTK(P9_DEBUG_VFS, 1407 - " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", dir->i_ino, 1408 - dentry->d_name.name, mode, MAJOR(rdev), MINOR(rdev)); 1406 + p9_debug(P9_DEBUG_VFS, " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", 1407 + dir->i_ino, dentry->d_name.name, mode, 1408 + MAJOR(rdev), MINOR(rdev)); 1409 1409 1410 1410 if (!new_valid_dev(rdev)) 1411 1411 return -EINVAL;
+41 -44
fs/9p/vfs_inode_dotl.c
··· 283 283 } 284 284 285 285 name = (char *) dentry->d_name.name; 286 - P9_DPRINTK(P9_DEBUG_VFS, "v9fs_vfs_create_dotl: name:%s flags:0x%x " 287 - "mode:0x%x\n", name, flags, omode); 286 + p9_debug(P9_DEBUG_VFS, "name:%s flags:0x%x mode:0x%x\n", 287 + name, flags, omode); 288 288 289 289 dfid = v9fs_fid_lookup(dentry->d_parent); 290 290 if (IS_ERR(dfid)) { 291 291 err = PTR_ERR(dfid); 292 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 292 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 293 293 return err; 294 294 } 295 295 ··· 297 297 ofid = p9_client_walk(dfid, 0, NULL, 1); 298 298 if (IS_ERR(ofid)) { 299 299 err = PTR_ERR(ofid); 300 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 300 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 301 301 return err; 302 302 } 303 303 ··· 307 307 /* Update mode based on ACL value */ 308 308 err = v9fs_acl_mode(dir, &mode, &dacl, &pacl); 309 309 if (err) { 310 - P9_DPRINTK(P9_DEBUG_VFS, 311 - "Failed to get acl values in creat %d\n", err); 310 + p9_debug(P9_DEBUG_VFS, "Failed to get acl values in creat %d\n", 311 + err); 312 312 goto error; 313 313 } 314 314 err = p9_client_create_dotl(ofid, name, v9fs_open_to_dotl_flags(flags), 315 315 mode, gid, &qid); 316 316 if (err < 0) { 317 - P9_DPRINTK(P9_DEBUG_VFS, 318 - "p9_client_open_dotl failed in creat %d\n", 319 - err); 317 + p9_debug(P9_DEBUG_VFS, "p9_client_open_dotl failed in creat %d\n", 318 + err); 320 319 goto error; 321 320 } 322 321 v9fs_invalidate_inode_attr(dir); ··· 324 325 fid = p9_client_walk(dfid, 1, &name, 1); 325 326 if (IS_ERR(fid)) { 326 327 err = PTR_ERR(fid); 327 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 328 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); 328 329 fid = NULL; 329 330 goto error; 330 331 } 331 332 inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); 332 333 if (IS_ERR(inode)) { 333 334 err = PTR_ERR(inode); 334 - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", err); 335 + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", err); 335 336 goto error; 336 337 } 337 338 err = v9fs_fid_add(dentry, fid); ··· 407 408 struct dentry *dir_dentry; 408 409 struct posix_acl *dacl = NULL, *pacl = NULL; 409 410 410 - P9_DPRINTK(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 411 + p9_debug(P9_DEBUG_VFS, "name %s\n", dentry->d_name.name); 411 412 err = 0; 412 413 v9ses = v9fs_inode2v9ses(dir); 413 414 ··· 419 420 dfid = v9fs_fid_lookup(dir_dentry); 420 421 if (IS_ERR(dfid)) { 421 422 err = PTR_ERR(dfid); 422 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 423 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 423 424 dfid = NULL; 424 425 goto error; 425 426 } ··· 429 430 /* Update mode based on ACL value */ 430 431 err = v9fs_acl_mode(dir, &mode, &dacl, &pacl); 431 432 if (err) { 432 - P9_DPRINTK(P9_DEBUG_VFS, 433 - "Failed to get acl values in mkdir %d\n", err); 433 + p9_debug(P9_DEBUG_VFS, "Failed to get acl values in mkdir %d\n", 434 + err); 434 435 goto error; 435 436 } 436 437 name = (char *) dentry->d_name.name; ··· 443 444 fid = p9_client_walk(dfid, 1, &name, 1); 444 445 if (IS_ERR(fid)) { 445 446 err = PTR_ERR(fid); 446 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 447 - err); 447 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 448 + err); 448 449 fid = NULL; 449 450 goto error; 450 451 } ··· 452 453 inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); 453 454 if (IS_ERR(inode)) { 454 455 err = PTR_ERR(inode); 455 - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", 456 - err); 456 + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", 457 + err); 457 458 goto error; 458 459 } 459 460 err = v9fs_fid_add(dentry, fid); ··· 494 495 struct p9_fid *fid; 495 496 struct p9_stat_dotl *st; 496 497 497 - P9_DPRINTK(P9_DEBUG_VFS, "dentry: %p\n", dentry); 498 + p9_debug(P9_DEBUG_VFS, "dentry: %p\n", dentry); 498 499 err = -EPERM; 499 500 v9ses = v9fs_dentry2v9ses(dentry); 500 501 if (v9ses->cache == CACHE_LOOSE || v9ses->cache == CACHE_FSCACHE) { ··· 536 537 struct p9_fid *fid; 537 538 struct p9_iattr_dotl p9attr; 538 539 539 - P9_DPRINTK(P9_DEBUG_VFS, "\n"); 540 + p9_debug(P9_DEBUG_VFS, "\n"); 540 541 541 542 retval = inode_change_ok(dentry->d_inode, iattr); 542 543 if (retval) ··· 669 670 struct v9fs_session_info *v9ses; 670 671 671 672 name = (char *) dentry->d_name.name; 672 - P9_DPRINTK(P9_DEBUG_VFS, "v9fs_vfs_symlink_dotl : %lu,%s,%s\n", 673 - dir->i_ino, name, symname); 673 + p9_debug(P9_DEBUG_VFS, "%lu,%s,%s\n", dir->i_ino, name, symname); 674 674 v9ses = v9fs_inode2v9ses(dir); 675 675 676 676 dfid = v9fs_fid_lookup(dentry->d_parent); 677 677 if (IS_ERR(dfid)) { 678 678 err = PTR_ERR(dfid); 679 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 679 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 680 680 return err; 681 681 } 682 682 ··· 685 687 err = p9_client_symlink(dfid, name, (char *)symname, gid, &qid); 686 688 687 689 if (err < 0) { 688 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_symlink failed %d\n", err); 690 + p9_debug(P9_DEBUG_VFS, "p9_client_symlink failed %d\n", err); 689 691 goto error; 690 692 } 691 693 ··· 695 697 fid = p9_client_walk(dfid, 1, &name, 1); 696 698 if (IS_ERR(fid)) { 697 699 err = PTR_ERR(fid); 698 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 699 - err); 700 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 701 + err); 700 702 fid = NULL; 701 703 goto error; 702 704 } ··· 705 707 inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); 706 708 if (IS_ERR(inode)) { 707 709 err = PTR_ERR(inode); 708 - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", 709 - err); 710 + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", 711 + err); 710 712 goto error; 711 713 } 712 714 err = v9fs_fid_add(dentry, fid); ··· 749 751 struct p9_fid *dfid, *oldfid; 750 752 struct v9fs_session_info *v9ses; 751 753 752 - P9_DPRINTK(P9_DEBUG_VFS, "dir ino: %lu, old_name: %s, new_name: %s\n", 753 - dir->i_ino, old_dentry->d_name.name, 754 - dentry->d_name.name); 754 + p9_debug(P9_DEBUG_VFS, "dir ino: %lu, old_name: %s, new_name: %s\n", 755 + dir->i_ino, old_dentry->d_name.name, dentry->d_name.name); 755 756 756 757 v9ses = v9fs_inode2v9ses(dir); 757 758 dir_dentry = v9fs_dentry_from_dir_inode(dir); ··· 767 770 err = p9_client_link(dfid, oldfid, (char *)dentry->d_name.name); 768 771 769 772 if (err < 0) { 770 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_link failed %d\n", err); 773 + p9_debug(P9_DEBUG_VFS, "p9_client_link failed %d\n", err); 771 774 return err; 772 775 } 773 776 ··· 810 813 struct dentry *dir_dentry; 811 814 struct posix_acl *dacl = NULL, *pacl = NULL; 812 815 813 - P9_DPRINTK(P9_DEBUG_VFS, 814 - " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", dir->i_ino, 815 - dentry->d_name.name, omode, MAJOR(rdev), MINOR(rdev)); 816 + p9_debug(P9_DEBUG_VFS, " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", 817 + dir->i_ino, dentry->d_name.name, omode, 818 + MAJOR(rdev), MINOR(rdev)); 816 819 817 820 if (!new_valid_dev(rdev)) 818 821 return -EINVAL; ··· 822 825 dfid = v9fs_fid_lookup(dir_dentry); 823 826 if (IS_ERR(dfid)) { 824 827 err = PTR_ERR(dfid); 825 - P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 828 + p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); 826 829 dfid = NULL; 827 830 goto error; 828 831 } ··· 832 835 /* Update mode based on ACL value */ 833 836 err = v9fs_acl_mode(dir, &mode, &dacl, &pacl); 834 837 if (err) { 835 - P9_DPRINTK(P9_DEBUG_VFS, 836 - "Failed to get acl values in mknod %d\n", err); 838 + p9_debug(P9_DEBUG_VFS, "Failed to get acl values in mknod %d\n", 839 + err); 837 840 goto error; 838 841 } 839 842 name = (char *) dentry->d_name.name; ··· 848 851 fid = p9_client_walk(dfid, 1, &name, 1); 849 852 if (IS_ERR(fid)) { 850 853 err = PTR_ERR(fid); 851 - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 852 - err); 854 + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", 855 + err); 853 856 fid = NULL; 854 857 goto error; 855 858 } ··· 857 860 inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); 858 861 if (IS_ERR(inode)) { 859 862 err = PTR_ERR(inode); 860 - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", 861 - err); 863 + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", 864 + err); 862 865 goto error; 863 866 } 864 867 err = v9fs_fid_add(dentry, fid); ··· 902 905 char *link = __getname(); 903 906 char *target; 904 907 905 - P9_DPRINTK(P9_DEBUG_VFS, "%s\n", dentry->d_name.name); 908 + p9_debug(P9_DEBUG_VFS, "%s\n", dentry->d_name.name); 906 909 907 910 if (!link) { 908 911 link = ERR_PTR(-ENOMEM);
+6 -6
fs/9p/vfs_super.c
··· 121 121 struct p9_fid *fid; 122 122 int retval = 0; 123 123 124 - P9_DPRINTK(P9_DEBUG_VFS, " \n"); 124 + p9_debug(P9_DEBUG_VFS, "\n"); 125 125 126 126 v9ses = kzalloc(sizeof(struct v9fs_session_info), GFP_KERNEL); 127 127 if (!v9ses) ··· 191 191 goto release_sb; 192 192 v9fs_fid_add(root, fid); 193 193 194 - P9_DPRINTK(P9_DEBUG_VFS, " simple set mount, return 0\n"); 194 + p9_debug(P9_DEBUG_VFS, " simple set mount, return 0\n"); 195 195 return dget(sb->s_root); 196 196 197 197 clunk_fid: ··· 223 223 { 224 224 struct v9fs_session_info *v9ses = s->s_fs_info; 225 225 226 - P9_DPRINTK(P9_DEBUG_VFS, " %p\n", s); 226 + p9_debug(P9_DEBUG_VFS, " %p\n", s); 227 227 228 228 kill_anon_super(s); 229 229 ··· 231 231 v9fs_session_close(v9ses); 232 232 kfree(v9ses); 233 233 s->s_fs_info = NULL; 234 - P9_DPRINTK(P9_DEBUG_VFS, "exiting kill_super\n"); 234 + p9_debug(P9_DEBUG_VFS, "exiting kill_super\n"); 235 235 } 236 236 237 237 static void ··· 303 303 * send an fsync request to server irrespective of 304 304 * wbc->sync_mode. 305 305 */ 306 - P9_DPRINTK(P9_DEBUG_VFS, "%s: inode %p\n", __func__, inode); 306 + p9_debug(P9_DEBUG_VFS, "%s: inode %p\n", __func__, inode); 307 307 v9inode = V9FS_I(inode); 308 308 if (!v9inode->writeback_fid) 309 309 return 0; ··· 326 326 * send an fsync request to server irrespective of 327 327 * wbc->sync_mode. 328 328 */ 329 - P9_DPRINTK(P9_DEBUG_VFS, "%s: inode %p\n", __func__, inode); 329 + p9_debug(P9_DEBUG_VFS, "%s: inode %p\n", __func__, inode); 330 330 v9inode = V9FS_I(inode); 331 331 if (!v9inode->writeback_fid) 332 332 return 0;
+8 -8
fs/9p/xattr.c
··· 32 32 attr_fid = p9_client_xattrwalk(fid, name, &attr_size); 33 33 if (IS_ERR(attr_fid)) { 34 34 retval = PTR_ERR(attr_fid); 35 - P9_DPRINTK(P9_DEBUG_VFS, 36 - "p9_client_attrwalk failed %zd\n", retval); 35 + p9_debug(P9_DEBUG_VFS, "p9_client_attrwalk failed %zd\n", 36 + retval); 37 37 attr_fid = NULL; 38 38 goto error; 39 39 } ··· 87 87 { 88 88 struct p9_fid *fid; 89 89 90 - P9_DPRINTK(P9_DEBUG_VFS, "%s: name = %s value_len = %zu\n", 91 - __func__, name, buffer_size); 90 + p9_debug(P9_DEBUG_VFS, "name = %s value_len = %zu\n", 91 + name, buffer_size); 92 92 fid = v9fs_fid_lookup(dentry); 93 93 if (IS_ERR(fid)) 94 94 return PTR_ERR(fid); ··· 115 115 int retval, msize, write_count; 116 116 struct p9_fid *fid = NULL; 117 117 118 - P9_DPRINTK(P9_DEBUG_VFS, "%s: name = %s value_len = %zu flags = %d\n", 119 - __func__, name, value_len, flags); 118 + p9_debug(P9_DEBUG_VFS, "name = %s value_len = %zu flags = %d\n", 119 + name, value_len, flags); 120 120 121 121 fid = v9fs_fid_clone(dentry); 122 122 if (IS_ERR(fid)) { ··· 129 129 */ 130 130 retval = p9_client_xattrcreate(fid, name, value_len, flags); 131 131 if (retval < 0) { 132 - P9_DPRINTK(P9_DEBUG_VFS, 133 - "p9_client_xattrcreate failed %d\n", retval); 132 + p9_debug(P9_DEBUG_VFS, "p9_client_xattrcreate failed %d\n", 133 + retval); 134 134 goto error; 135 135 } 136 136 msize = fid->clnt->msize;
+7 -21
include/net/9p/9p.h
··· 63 63 64 64 #ifdef CONFIG_NET_9P_DEBUG 65 65 extern unsigned int p9_debug_level; 66 - 67 - #define P9_DPRINTK(level, format, arg...) \ 68 - do { \ 69 - if ((p9_debug_level & level) == level) {\ 70 - if (level == P9_DEBUG_9P) \ 71 - printk(KERN_NOTICE "(%8.8d) " \ 72 - format , task_pid_nr(current) , ## arg); \ 73 - else \ 74 - printk(KERN_NOTICE "-- %s (%d): " \ 75 - format , __func__, task_pid_nr(current) , ## arg); \ 76 - } \ 77 - } while (0) 78 - 66 + __printf(3, 4) 67 + void _p9_debug(enum p9_debug_flags level, const char *func, 68 + const char *fmt, ...); 69 + #define p9_debug(level, fmt, ...) \ 70 + _p9_debug(level, __func__, fmt, ##__VA_ARGS__) 79 71 #else 80 - #define P9_DPRINTK(level, format, arg...) do { } while (0) 72 + #define p9_debug(level, fmt, ...) \ 73 + no_printk(fmt, ##__VA_ARGS__) 81 74 #endif 82 - 83 - 84 - #define P9_EPRINTK(level, format, arg...) \ 85 - do { \ 86 - printk(level "9p: %s (%d): " \ 87 - format , __func__, task_pid_nr(current), ## arg); \ 88 - } while (0) 89 75 90 76 /** 91 77 * enum p9_msg_t - 9P message types
+121 -121
net/9p/client.c
··· 23 23 * 24 24 */ 25 25 26 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 27 + 26 28 #include <linux/module.h> 27 29 #include <linux/errno.h> 28 30 #include <linux/fs.h> ··· 83 81 84 82 if (!strcmp(s, "9p2000")) { 85 83 version = p9_proto_legacy; 86 - P9_DPRINTK(P9_DEBUG_9P, "Protocol version: Legacy\n"); 84 + p9_debug(P9_DEBUG_9P, "Protocol version: Legacy\n"); 87 85 } else if (!strcmp(s, "9p2000.u")) { 88 86 version = p9_proto_2000u; 89 - P9_DPRINTK(P9_DEBUG_9P, "Protocol version: 9P2000.u\n"); 87 + p9_debug(P9_DEBUG_9P, "Protocol version: 9P2000.u\n"); 90 88 } else if (!strcmp(s, "9p2000.L")) { 91 89 version = p9_proto_2000L; 92 - P9_DPRINTK(P9_DEBUG_9P, "Protocol version: 9P2000.L\n"); 90 + p9_debug(P9_DEBUG_9P, "Protocol version: 9P2000.L\n"); 93 91 } else 94 - printk(KERN_INFO "9p: Unknown protocol version %s.\n", s); 92 + pr_info("Unknown protocol version %s\n", s); 95 93 96 94 return version; 97 95 } ··· 121 119 122 120 tmp_options = kstrdup(opts, GFP_KERNEL); 123 121 if (!tmp_options) { 124 - P9_DPRINTK(P9_DEBUG_ERROR, 125 - "failed to allocate copy of option string\n"); 122 + p9_debug(P9_DEBUG_ERROR, 123 + "failed to allocate copy of option string\n"); 126 124 return -ENOMEM; 127 125 } 128 126 options = tmp_options; ··· 136 134 case Opt_msize: 137 135 r = match_int(&args[0], &option); 138 136 if (r < 0) { 139 - P9_DPRINTK(P9_DEBUG_ERROR, 140 - "integer field, but no integer?\n"); 137 + p9_debug(P9_DEBUG_ERROR, 138 + "integer field, but no integer?\n"); 141 139 ret = r; 142 140 continue; 143 141 } ··· 147 145 s = match_strdup(&args[0]); 148 146 if (!s) { 149 147 ret = -ENOMEM; 150 - P9_DPRINTK(P9_DEBUG_ERROR, 151 - "problem allocating copy of trans arg\n"); 148 + p9_debug(P9_DEBUG_ERROR, 149 + "problem allocating copy of trans arg\n"); 152 150 goto free_and_return; 153 151 } 154 152 clnt->trans_mod = v9fs_get_trans_by_name(s); 155 153 if (clnt->trans_mod == NULL) { 156 - printk(KERN_INFO 157 - "9p: Could not find " 158 - "request transport: %s\n", s); 154 + pr_info("Could not find request transport: %s\n", 155 + s); 159 156 ret = -EINVAL; 160 157 kfree(s); 161 158 goto free_and_return; ··· 168 167 s = match_strdup(&args[0]); 169 168 if (!s) { 170 169 ret = -ENOMEM; 171 - P9_DPRINTK(P9_DEBUG_ERROR, 172 - "problem allocating copy of version arg\n"); 170 + p9_debug(P9_DEBUG_ERROR, 171 + "problem allocating copy of version arg\n"); 173 172 goto free_and_return; 174 173 } 175 174 ret = get_protocol_version(s); ··· 226 225 sizeof(struct p9_req_t), GFP_ATOMIC); 227 226 228 227 if (!c->reqs[row]) { 229 - printk(KERN_ERR "Couldn't grow tag array\n"); 228 + pr_err("Couldn't grow tag array\n"); 230 229 spin_unlock_irqrestore(&c->lock, flags); 231 230 return ERR_PTR(-ENOMEM); 232 231 } ··· 245 244 if (!req->tc) { 246 245 req->wq = kmalloc(sizeof(wait_queue_head_t), GFP_NOFS); 247 246 if (!req->wq) { 248 - printk(KERN_ERR "Couldn't grow tag array\n"); 247 + pr_err("Couldn't grow tag array\n"); 249 248 return ERR_PTR(-ENOMEM); 250 249 } 251 250 init_waitqueue_head(req->wq); ··· 254 253 req->rc = kmalloc(sizeof(struct p9_fcall) + alloc_msize, 255 254 GFP_NOFS); 256 255 if ((!req->tc) || (!req->rc)) { 257 - printk(KERN_ERR "Couldn't grow tag array\n"); 256 + pr_err("Couldn't grow tag array\n"); 258 257 kfree(req->tc); 259 258 kfree(req->rc); 260 259 kfree(req->wq); ··· 344 343 for (row = 0; row < (c->max_tag/P9_ROW_MAXTAG); row++) { 345 344 for (col = 0; col < P9_ROW_MAXTAG; col++) { 346 345 if (c->reqs[row][col].status != REQ_STATUS_IDLE) { 347 - P9_DPRINTK(P9_DEBUG_MUX, 348 - "Attempting to cleanup non-free tag %d,%d\n", 349 - row, col); 346 + p9_debug(P9_DEBUG_MUX, 347 + "Attempting to cleanup non-free tag %d,%d\n", 348 + row, col); 350 349 /* TODO: delay execution of cleanup */ 351 350 return; 352 351 } ··· 380 379 static void p9_free_req(struct p9_client *c, struct p9_req_t *r) 381 380 { 382 381 int tag = r->tc->tag; 383 - P9_DPRINTK(P9_DEBUG_MUX, "clnt %p req %p tag: %d\n", c, r, tag); 382 + p9_debug(P9_DEBUG_MUX, "clnt %p req %p tag: %d\n", c, r, tag); 384 383 385 384 r->status = REQ_STATUS_IDLE; 386 385 if (tag != P9_NOTAG && p9_idpool_check(tag, c->tagpool)) ··· 395 394 */ 396 395 void p9_client_cb(struct p9_client *c, struct p9_req_t *req) 397 396 { 398 - P9_DPRINTK(P9_DEBUG_MUX, " tag %d\n", req->tc->tag); 397 + p9_debug(P9_DEBUG_MUX, " tag %d\n", req->tc->tag); 399 398 wake_up(req->wq); 400 - P9_DPRINTK(P9_DEBUG_MUX, "wakeup: %d\n", req->tc->tag); 399 + p9_debug(P9_DEBUG_MUX, "wakeup: %d\n", req->tc->tag); 401 400 } 402 401 EXPORT_SYMBOL(p9_client_cb); 403 402 ··· 432 431 pdu->id = r_type; 433 432 pdu->tag = r_tag; 434 433 435 - P9_DPRINTK(P9_DEBUG_9P, "<<< size=%d type: %d tag: %d\n", pdu->size, 436 - pdu->id, pdu->tag); 434 + p9_debug(P9_DEBUG_9P, "<<< size=%d type: %d tag: %d\n", 435 + pdu->size, pdu->id, pdu->tag); 437 436 438 437 if (type) 439 438 *type = r_type; ··· 474 473 */ 475 474 trace_9p_protocol_dump(c, req->rc); 476 475 if (err) { 477 - P9_DPRINTK(P9_DEBUG_ERROR, "couldn't parse header %d\n", err); 476 + p9_debug(P9_DEBUG_ERROR, "couldn't parse header %d\n", err); 478 477 return err; 479 478 } 480 479 if (type != P9_RERROR && type != P9_RLERROR) ··· 493 492 if (!err || !IS_ERR_VALUE(err)) { 494 493 err = p9_errstr2errno(ename, strlen(ename)); 495 494 496 - P9_DPRINTK(P9_DEBUG_9P, "<<< RERROR (%d) %s\n", 497 - -ecode, ename); 495 + p9_debug(P9_DEBUG_9P, "<<< RERROR (%d) %s\n", 496 + -ecode, ename); 498 497 } 499 498 kfree(ename); 500 499 } else { 501 500 err = p9pdu_readf(req->rc, c->proto_version, "d", &ecode); 502 501 err = -ecode; 503 502 504 - P9_DPRINTK(P9_DEBUG_9P, "<<< RLERROR (%d)\n", -ecode); 503 + p9_debug(P9_DEBUG_9P, "<<< RLERROR (%d)\n", -ecode); 505 504 } 506 505 507 506 return err; 508 507 509 508 out_err: 510 - P9_DPRINTK(P9_DEBUG_ERROR, "couldn't parse error%d\n", err); 509 + p9_debug(P9_DEBUG_ERROR, "couldn't parse error%d\n", err); 511 510 512 511 return err; 513 512 } ··· 539 538 */ 540 539 trace_9p_protocol_dump(c, req->rc); 541 540 if (err) { 542 - P9_DPRINTK(P9_DEBUG_ERROR, "couldn't parse header %d\n", err); 541 + p9_debug(P9_DEBUG_ERROR, "couldn't parse header %d\n", err); 543 542 return err; 544 543 } 545 544 ··· 602 601 if (!err || !IS_ERR_VALUE(err)) { 603 602 err = p9_errstr2errno(ename, strlen(ename)); 604 603 605 - P9_DPRINTK(P9_DEBUG_9P, "<<< RERROR (%d) %s\n", 606 - -ecode, ename); 604 + p9_debug(P9_DEBUG_9P, "<<< RERROR (%d) %s\n", 605 + -ecode, ename); 607 606 } 608 607 kfree(ename); 609 608 } else { 610 609 err = p9pdu_readf(req->rc, c->proto_version, "d", &ecode); 611 610 err = -ecode; 612 611 613 - P9_DPRINTK(P9_DEBUG_9P, "<<< RLERROR (%d)\n", -ecode); 612 + p9_debug(P9_DEBUG_9P, "<<< RLERROR (%d)\n", -ecode); 614 613 } 615 614 return err; 616 615 617 616 out_free: 618 617 kfree(ename); 619 618 out_err: 620 - P9_DPRINTK(P9_DEBUG_ERROR, "couldn't parse error%d\n", err); 619 + p9_debug(P9_DEBUG_ERROR, "couldn't parse error%d\n", err); 621 620 return err; 622 621 } 623 622 ··· 646 645 if (err) 647 646 return err; 648 647 649 - P9_DPRINTK(P9_DEBUG_9P, ">>> TFLUSH tag %d\n", oldtag); 648 + p9_debug(P9_DEBUG_9P, ">>> TFLUSH tag %d\n", oldtag); 650 649 651 650 req = p9_client_rpc(c, P9_TFLUSH, "w", oldtag); 652 651 if (IS_ERR(req)) ··· 671 670 int tag, err; 672 671 struct p9_req_t *req; 673 672 674 - P9_DPRINTK(P9_DEBUG_MUX, "client %p op %d\n", c, type); 673 + p9_debug(P9_DEBUG_MUX, "client %p op %d\n", c, type); 675 674 676 675 /* we allow for any status other than disconnected */ 677 676 if (c->status == Disconnected) ··· 745 744 req->status >= REQ_STATUS_RCVD); 746 745 747 746 if (req->status == REQ_STATUS_ERROR) { 748 - P9_DPRINTK(P9_DEBUG_ERROR, "req_status error %d\n", req->t_err); 747 + p9_debug(P9_DEBUG_ERROR, "req_status error %d\n", req->t_err); 749 748 err = req->t_err; 750 749 } 751 750 if ((err == -ERESTARTSYS) && (c->status == Connected)) { 752 - P9_DPRINTK(P9_DEBUG_MUX, "flushing\n"); 751 + p9_debug(P9_DEBUG_MUX, "flushing\n"); 753 752 sigpending = 1; 754 753 clear_thread_flag(TIF_SIGPENDING); 755 754 ··· 828 827 goto reterr; 829 828 } 830 829 if (req->status == REQ_STATUS_ERROR) { 831 - P9_DPRINTK(P9_DEBUG_ERROR, "req_status error %d\n", req->t_err); 830 + p9_debug(P9_DEBUG_ERROR, "req_status error %d\n", req->t_err); 832 831 err = req->t_err; 833 832 } 834 833 if ((err == -ERESTARTSYS) && (c->status == Connected)) { 835 - P9_DPRINTK(P9_DEBUG_MUX, "flushing\n"); 834 + p9_debug(P9_DEBUG_MUX, "flushing\n"); 836 835 sigpending = 1; 837 836 clear_thread_flag(TIF_SIGPENDING); 838 837 ··· 866 865 struct p9_fid *fid; 867 866 unsigned long flags; 868 867 869 - P9_DPRINTK(P9_DEBUG_FID, "clnt %p\n", clnt); 868 + p9_debug(P9_DEBUG_FID, "clnt %p\n", clnt); 870 869 fid = kmalloc(sizeof(struct p9_fid), GFP_KERNEL); 871 870 if (!fid) 872 871 return ERR_PTR(-ENOMEM); ··· 899 898 struct p9_client *clnt; 900 899 unsigned long flags; 901 900 902 - P9_DPRINTK(P9_DEBUG_FID, "fid %d\n", fid->fid); 901 + p9_debug(P9_DEBUG_FID, "fid %d\n", fid->fid); 903 902 clnt = fid->clnt; 904 903 p9_idpool_put(fid->fid, clnt->fidpool); 905 904 spin_lock_irqsave(&clnt->lock, flags); ··· 916 915 char *version; 917 916 int msize; 918 917 919 - P9_DPRINTK(P9_DEBUG_9P, ">>> TVERSION msize %d protocol %d\n", 920 - c->msize, c->proto_version); 918 + p9_debug(P9_DEBUG_9P, ">>> TVERSION msize %d protocol %d\n", 919 + c->msize, c->proto_version); 921 920 922 921 switch (c->proto_version) { 923 922 case p9_proto_2000L: ··· 942 941 943 942 err = p9pdu_readf(req->rc, c->proto_version, "ds", &msize, &version); 944 943 if (err) { 945 - P9_DPRINTK(P9_DEBUG_9P, "version error %d\n", err); 944 + p9_debug(P9_DEBUG_9P, "version error %d\n", err); 946 945 trace_9p_protocol_dump(c, req->rc); 947 946 goto error; 948 947 } 949 948 950 - P9_DPRINTK(P9_DEBUG_9P, "<<< RVERSION msize %d %s\n", msize, version); 949 + p9_debug(P9_DEBUG_9P, "<<< RVERSION msize %d %s\n", msize, version); 951 950 if (!strncmp(version, "9P2000.L", 8)) 952 951 c->proto_version = p9_proto_2000L; 953 952 else if (!strncmp(version, "9P2000.u", 8)) ··· 997 996 998 997 if (clnt->trans_mod == NULL) { 999 998 err = -EPROTONOSUPPORT; 1000 - P9_DPRINTK(P9_DEBUG_ERROR, 1001 - "No transport defined or default transport\n"); 999 + p9_debug(P9_DEBUG_ERROR, 1000 + "No transport defined or default transport\n"); 1002 1001 goto destroy_tagpool; 1003 1002 } 1004 1003 ··· 1008 1007 goto put_trans; 1009 1008 } 1010 1009 1011 - P9_DPRINTK(P9_DEBUG_MUX, "clnt %p trans %p msize %d protocol %d\n", 1012 - clnt, clnt->trans_mod, clnt->msize, clnt->proto_version); 1010 + p9_debug(P9_DEBUG_MUX, "clnt %p trans %p msize %d protocol %d\n", 1011 + clnt, clnt->trans_mod, clnt->msize, clnt->proto_version); 1013 1012 1014 1013 err = clnt->trans_mod->create(clnt, dev_name, options); 1015 1014 if (err) ··· 1042 1041 { 1043 1042 struct p9_fid *fid, *fidptr; 1044 1043 1045 - P9_DPRINTK(P9_DEBUG_MUX, "clnt %p\n", clnt); 1044 + p9_debug(P9_DEBUG_MUX, "clnt %p\n", clnt); 1046 1045 1047 1046 if (clnt->trans_mod) 1048 1047 clnt->trans_mod->close(clnt); ··· 1050 1049 v9fs_put_trans(clnt->trans_mod); 1051 1050 1052 1051 list_for_each_entry_safe(fid, fidptr, &clnt->fidlist, flist) { 1053 - printk(KERN_INFO "Found fid %d not clunked\n", fid->fid); 1052 + pr_info("Found fid %d not clunked\n", fid->fid); 1054 1053 p9_fid_destroy(fid); 1055 1054 } 1056 1055 ··· 1065 1064 1066 1065 void p9_client_disconnect(struct p9_client *clnt) 1067 1066 { 1068 - P9_DPRINTK(P9_DEBUG_9P, "clnt %p\n", clnt); 1067 + p9_debug(P9_DEBUG_9P, "clnt %p\n", clnt); 1069 1068 clnt->status = Disconnected; 1070 1069 } 1071 1070 EXPORT_SYMBOL(p9_client_disconnect); 1072 1071 1073 1072 void p9_client_begin_disconnect(struct p9_client *clnt) 1074 1073 { 1075 - P9_DPRINTK(P9_DEBUG_9P, "clnt %p\n", clnt); 1074 + p9_debug(P9_DEBUG_9P, "clnt %p\n", clnt); 1076 1075 clnt->status = BeginDisconnect; 1077 1076 } 1078 1077 EXPORT_SYMBOL(p9_client_begin_disconnect); ··· 1086 1085 struct p9_qid qid; 1087 1086 1088 1087 1089 - P9_DPRINTK(P9_DEBUG_9P, ">>> TATTACH afid %d uname %s aname %s\n", 1090 - afid ? afid->fid : -1, uname, aname); 1088 + p9_debug(P9_DEBUG_9P, ">>> TATTACH afid %d uname %s aname %s\n", 1089 + afid ? afid->fid : -1, uname, aname); 1091 1090 fid = p9_fid_create(clnt); 1092 1091 if (IS_ERR(fid)) { 1093 1092 err = PTR_ERR(fid); ··· 1109 1108 goto error; 1110 1109 } 1111 1110 1112 - P9_DPRINTK(P9_DEBUG_9P, "<<< RATTACH qid %x.%llx.%x\n", 1113 - qid.type, 1114 - (unsigned long long)qid.path, 1115 - qid.version); 1111 + p9_debug(P9_DEBUG_9P, "<<< RATTACH qid %x.%llx.%x\n", 1112 + qid.type, (unsigned long long)qid.path, qid.version); 1116 1113 1117 1114 memmove(&fid->qid, &qid, sizeof(struct p9_qid)); 1118 1115 ··· 1150 1151 fid = oldfid; 1151 1152 1152 1153 1153 - P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n", 1154 - oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL); 1154 + p9_debug(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n", 1155 + oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL); 1155 1156 1156 1157 req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid, 1157 1158 nwname, wnames); ··· 1168 1169 } 1169 1170 p9_free_req(clnt, req); 1170 1171 1171 - P9_DPRINTK(P9_DEBUG_9P, "<<< RWALK nwqid %d:\n", nwqids); 1172 + p9_debug(P9_DEBUG_9P, "<<< RWALK nwqid %d:\n", nwqids); 1172 1173 1173 1174 if (nwqids != nwname) { 1174 1175 err = -ENOENT; ··· 1176 1177 } 1177 1178 1178 1179 for (count = 0; count < nwqids; count++) 1179 - P9_DPRINTK(P9_DEBUG_9P, "<<< [%d] %x.%llx.%x\n", 1180 + p9_debug(P9_DEBUG_9P, "<<< [%d] %x.%llx.%x\n", 1180 1181 count, wqids[count].type, 1181 1182 (unsigned long long)wqids[count].path, 1182 1183 wqids[count].version); ··· 1211 1212 int iounit; 1212 1213 1213 1214 clnt = fid->clnt; 1214 - P9_DPRINTK(P9_DEBUG_9P, ">>> %s fid %d mode %d\n", 1215 + p9_debug(P9_DEBUG_9P, ">>> %s fid %d mode %d\n", 1215 1216 p9_is_proto_dotl(clnt) ? "TLOPEN" : "TOPEN", fid->fid, mode); 1216 1217 err = 0; 1217 1218 ··· 1233 1234 goto free_and_error; 1234 1235 } 1235 1236 1236 - P9_DPRINTK(P9_DEBUG_9P, "<<< %s qid %x.%llx.%x iounit %x\n", 1237 + p9_debug(P9_DEBUG_9P, "<<< %s qid %x.%llx.%x iounit %x\n", 1237 1238 p9_is_proto_dotl(clnt) ? "RLOPEN" : "ROPEN", qid.type, 1238 1239 (unsigned long long)qid.path, qid.version, iounit); 1239 1240 ··· 1255 1256 struct p9_req_t *req; 1256 1257 int iounit; 1257 1258 1258 - P9_DPRINTK(P9_DEBUG_9P, 1259 + p9_debug(P9_DEBUG_9P, 1259 1260 ">>> TLCREATE fid %d name %s flags %d mode %d gid %d\n", 1260 1261 ofid->fid, name, flags, mode, gid); 1261 1262 clnt = ofid->clnt; ··· 1276 1277 goto free_and_error; 1277 1278 } 1278 1279 1279 - P9_DPRINTK(P9_DEBUG_9P, "<<< RLCREATE qid %x.%llx.%x iounit %x\n", 1280 + p9_debug(P9_DEBUG_9P, "<<< RLCREATE qid %x.%llx.%x iounit %x\n", 1280 1281 qid->type, 1281 1282 (unsigned long long)qid->path, 1282 1283 qid->version, iounit); ··· 1300 1301 struct p9_qid qid; 1301 1302 int iounit; 1302 1303 1303 - P9_DPRINTK(P9_DEBUG_9P, ">>> TCREATE fid %d name %s perm %d mode %d\n", 1304 + p9_debug(P9_DEBUG_9P, ">>> TCREATE fid %d name %s perm %d mode %d\n", 1304 1305 fid->fid, name, perm, mode); 1305 1306 err = 0; 1306 1307 clnt = fid->clnt; ··· 1321 1322 goto free_and_error; 1322 1323 } 1323 1324 1324 - P9_DPRINTK(P9_DEBUG_9P, "<<< RCREATE qid %x.%llx.%x iounit %x\n", 1325 + p9_debug(P9_DEBUG_9P, "<<< RCREATE qid %x.%llx.%x iounit %x\n", 1325 1326 qid.type, 1326 1327 (unsigned long long)qid.path, 1327 1328 qid.version, iounit); ··· 1343 1344 struct p9_client *clnt; 1344 1345 struct p9_req_t *req; 1345 1346 1346 - P9_DPRINTK(P9_DEBUG_9P, ">>> TSYMLINK dfid %d name %s symtgt %s\n", 1347 + p9_debug(P9_DEBUG_9P, ">>> TSYMLINK dfid %d name %s symtgt %s\n", 1347 1348 dfid->fid, name, symtgt); 1348 1349 clnt = dfid->clnt; 1349 1350 ··· 1360 1361 goto free_and_error; 1361 1362 } 1362 1363 1363 - P9_DPRINTK(P9_DEBUG_9P, "<<< RSYMLINK qid %x.%llx.%x\n", 1364 + p9_debug(P9_DEBUG_9P, "<<< RSYMLINK qid %x.%llx.%x\n", 1364 1365 qid->type, (unsigned long long)qid->path, qid->version); 1365 1366 1366 1367 free_and_error: ··· 1375 1376 struct p9_client *clnt; 1376 1377 struct p9_req_t *req; 1377 1378 1378 - P9_DPRINTK(P9_DEBUG_9P, ">>> TLINK dfid %d oldfid %d newname %s\n", 1379 + p9_debug(P9_DEBUG_9P, ">>> TLINK dfid %d oldfid %d newname %s\n", 1379 1380 dfid->fid, oldfid->fid, newname); 1380 1381 clnt = dfid->clnt; 1381 1382 req = p9_client_rpc(clnt, P9_TLINK, "dds", dfid->fid, oldfid->fid, ··· 1383 1384 if (IS_ERR(req)) 1384 1385 return PTR_ERR(req); 1385 1386 1386 - P9_DPRINTK(P9_DEBUG_9P, "<<< RLINK\n"); 1387 + p9_debug(P9_DEBUG_9P, "<<< RLINK\n"); 1387 1388 p9_free_req(clnt, req); 1388 1389 return 0; 1389 1390 } ··· 1395 1396 struct p9_client *clnt; 1396 1397 struct p9_req_t *req; 1397 1398 1398 - P9_DPRINTK(P9_DEBUG_9P, ">>> TFSYNC fid %d datasync:%d\n", 1399 + p9_debug(P9_DEBUG_9P, ">>> TFSYNC fid %d datasync:%d\n", 1399 1400 fid->fid, datasync); 1400 1401 err = 0; 1401 1402 clnt = fid->clnt; ··· 1406 1407 goto error; 1407 1408 } 1408 1409 1409 - P9_DPRINTK(P9_DEBUG_9P, "<<< RFSYNC fid %d\n", fid->fid); 1410 + p9_debug(P9_DEBUG_9P, "<<< RFSYNC fid %d\n", fid->fid); 1410 1411 1411 1412 p9_free_req(clnt, req); 1412 1413 ··· 1422 1423 struct p9_req_t *req; 1423 1424 1424 1425 if (!fid) { 1425 - P9_EPRINTK(KERN_WARNING, "Trying to clunk with NULL fid\n"); 1426 + pr_warn("%s (%d): Trying to clunk with NULL fid\n", 1427 + __func__, task_pid_nr(current)); 1426 1428 dump_stack(); 1427 1429 return 0; 1428 1430 } 1429 1431 1430 - P9_DPRINTK(P9_DEBUG_9P, ">>> TCLUNK fid %d\n", fid->fid); 1432 + p9_debug(P9_DEBUG_9P, ">>> TCLUNK fid %d\n", fid->fid); 1431 1433 err = 0; 1432 1434 clnt = fid->clnt; 1433 1435 ··· 1438 1438 goto error; 1439 1439 } 1440 1440 1441 - P9_DPRINTK(P9_DEBUG_9P, "<<< RCLUNK fid %d\n", fid->fid); 1441 + p9_debug(P9_DEBUG_9P, "<<< RCLUNK fid %d\n", fid->fid); 1442 1442 1443 1443 p9_free_req(clnt, req); 1444 1444 error: ··· 1456 1456 struct p9_client *clnt; 1457 1457 struct p9_req_t *req; 1458 1458 1459 - P9_DPRINTK(P9_DEBUG_9P, ">>> TREMOVE fid %d\n", fid->fid); 1459 + p9_debug(P9_DEBUG_9P, ">>> TREMOVE fid %d\n", fid->fid); 1460 1460 err = 0; 1461 1461 clnt = fid->clnt; 1462 1462 ··· 1466 1466 goto error; 1467 1467 } 1468 1468 1469 - P9_DPRINTK(P9_DEBUG_9P, "<<< RREMOVE fid %d\n", fid->fid); 1469 + p9_debug(P9_DEBUG_9P, "<<< RREMOVE fid %d\n", fid->fid); 1470 1470 1471 1471 p9_free_req(clnt, req); 1472 1472 error: ··· 1481 1481 struct p9_req_t *req; 1482 1482 struct p9_client *clnt; 1483 1483 1484 - P9_DPRINTK(P9_DEBUG_9P, ">>> TUNLINKAT fid %d %s %d\n", 1484 + p9_debug(P9_DEBUG_9P, ">>> TUNLINKAT fid %d %s %d\n", 1485 1485 dfid->fid, name, flags); 1486 1486 1487 1487 clnt = dfid->clnt; ··· 1490 1490 err = PTR_ERR(req); 1491 1491 goto error; 1492 1492 } 1493 - P9_DPRINTK(P9_DEBUG_9P, "<<< RUNLINKAT fid %d %s\n", dfid->fid, name); 1493 + p9_debug(P9_DEBUG_9P, "<<< RUNLINKAT fid %d %s\n", dfid->fid, name); 1494 1494 1495 1495 p9_free_req(clnt, req); 1496 1496 error: ··· 1509 1509 int err, rsize, non_zc = 0; 1510 1510 1511 1511 1512 - P9_DPRINTK(P9_DEBUG_9P, ">>> TREAD fid %d offset %llu %d\n", 1512 + p9_debug(P9_DEBUG_9P, ">>> TREAD fid %d offset %llu %d\n", 1513 1513 fid->fid, (long long unsigned) offset, count); 1514 1514 err = 0; 1515 1515 clnt = fid->clnt; ··· 1552 1552 goto free_and_error; 1553 1553 } 1554 1554 1555 - P9_DPRINTK(P9_DEBUG_9P, "<<< RREAD count %d\n", count); 1555 + p9_debug(P9_DEBUG_9P, "<<< RREAD count %d\n", count); 1556 1556 1557 1557 if (non_zc) { 1558 1558 if (data) { ··· 1584 1584 struct p9_client *clnt; 1585 1585 struct p9_req_t *req; 1586 1586 1587 - P9_DPRINTK(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu count %d\n", 1587 + p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu count %d\n", 1588 1588 fid->fid, (long long unsigned) offset, count); 1589 1589 err = 0; 1590 1590 clnt = fid->clnt; ··· 1626 1626 goto free_and_error; 1627 1627 } 1628 1628 1629 - P9_DPRINTK(P9_DEBUG_9P, "<<< RWRITE count %d\n", count); 1629 + p9_debug(P9_DEBUG_9P, "<<< RWRITE count %d\n", count); 1630 1630 1631 1631 p9_free_req(clnt, req); 1632 1632 return count; ··· 1646 1646 struct p9_req_t *req; 1647 1647 u16 ignored; 1648 1648 1649 - P9_DPRINTK(P9_DEBUG_9P, ">>> TSTAT fid %d\n", fid->fid); 1649 + p9_debug(P9_DEBUG_9P, ">>> TSTAT fid %d\n", fid->fid); 1650 1650 1651 1651 if (!ret) 1652 1652 return ERR_PTR(-ENOMEM); ··· 1667 1667 goto error; 1668 1668 } 1669 1669 1670 - P9_DPRINTK(P9_DEBUG_9P, 1670 + p9_debug(P9_DEBUG_9P, 1671 1671 "<<< RSTAT sz=%x type=%x dev=%x qid=%x.%llx.%x\n" 1672 1672 "<<< mode=%8.8x atime=%8.8x mtime=%8.8x length=%llx\n" 1673 1673 "<<< name=%s uid=%s gid=%s muid=%s extension=(%s)\n" ··· 1696 1696 GFP_KERNEL); 1697 1697 struct p9_req_t *req; 1698 1698 1699 - P9_DPRINTK(P9_DEBUG_9P, ">>> TGETATTR fid %d, request_mask %lld\n", 1699 + p9_debug(P9_DEBUG_9P, ">>> TGETATTR fid %d, request_mask %lld\n", 1700 1700 fid->fid, request_mask); 1701 1701 1702 1702 if (!ret) ··· 1718 1718 goto error; 1719 1719 } 1720 1720 1721 - P9_DPRINTK(P9_DEBUG_9P, 1721 + p9_debug(P9_DEBUG_9P, 1722 1722 "<<< RGETATTR st_result_mask=%lld\n" 1723 1723 "<<< qid=%x.%llx.%x\n" 1724 1724 "<<< st_mode=%8.8x st_nlink=%llu\n" ··· 1784 1784 err = 0; 1785 1785 clnt = fid->clnt; 1786 1786 wst->size = p9_client_statsize(wst, clnt->proto_version); 1787 - P9_DPRINTK(P9_DEBUG_9P, ">>> TWSTAT fid %d\n", fid->fid); 1788 - P9_DPRINTK(P9_DEBUG_9P, 1787 + p9_debug(P9_DEBUG_9P, ">>> TWSTAT fid %d\n", fid->fid); 1788 + p9_debug(P9_DEBUG_9P, 1789 1789 " sz=%x type=%x dev=%x qid=%x.%llx.%x\n" 1790 1790 " mode=%8.8x atime=%8.8x mtime=%8.8x length=%llx\n" 1791 1791 " name=%s uid=%s gid=%s muid=%s extension=(%s)\n" ··· 1802 1802 goto error; 1803 1803 } 1804 1804 1805 - P9_DPRINTK(P9_DEBUG_9P, "<<< RWSTAT fid %d\n", fid->fid); 1805 + p9_debug(P9_DEBUG_9P, "<<< RWSTAT fid %d\n", fid->fid); 1806 1806 1807 1807 p9_free_req(clnt, req); 1808 1808 error: ··· 1818 1818 1819 1819 err = 0; 1820 1820 clnt = fid->clnt; 1821 - P9_DPRINTK(P9_DEBUG_9P, ">>> TSETATTR fid %d\n", fid->fid); 1822 - P9_DPRINTK(P9_DEBUG_9P, 1821 + p9_debug(P9_DEBUG_9P, ">>> TSETATTR fid %d\n", fid->fid); 1822 + p9_debug(P9_DEBUG_9P, 1823 1823 " valid=%x mode=%x uid=%d gid=%d size=%lld\n" 1824 1824 " atime_sec=%lld atime_nsec=%lld\n" 1825 1825 " mtime_sec=%lld mtime_nsec=%lld\n", ··· 1833 1833 err = PTR_ERR(req); 1834 1834 goto error; 1835 1835 } 1836 - P9_DPRINTK(P9_DEBUG_9P, "<<< RSETATTR fid %d\n", fid->fid); 1836 + p9_debug(P9_DEBUG_9P, "<<< RSETATTR fid %d\n", fid->fid); 1837 1837 p9_free_req(clnt, req); 1838 1838 error: 1839 1839 return err; ··· 1849 1849 err = 0; 1850 1850 clnt = fid->clnt; 1851 1851 1852 - P9_DPRINTK(P9_DEBUG_9P, ">>> TSTATFS fid %d\n", fid->fid); 1852 + p9_debug(P9_DEBUG_9P, ">>> TSTATFS fid %d\n", fid->fid); 1853 1853 1854 1854 req = p9_client_rpc(clnt, P9_TSTATFS, "d", fid->fid); 1855 1855 if (IS_ERR(req)) { ··· 1866 1866 goto error; 1867 1867 } 1868 1868 1869 - P9_DPRINTK(P9_DEBUG_9P, "<<< RSTATFS fid %d type 0x%lx bsize %ld " 1869 + p9_debug(P9_DEBUG_9P, "<<< RSTATFS fid %d type 0x%lx bsize %ld " 1870 1870 "blocks %llu bfree %llu bavail %llu files %llu ffree %llu " 1871 1871 "fsid %llu namelen %ld\n", 1872 1872 fid->fid, (long unsigned int)sb->type, (long int)sb->bsize, ··· 1889 1889 err = 0; 1890 1890 clnt = fid->clnt; 1891 1891 1892 - P9_DPRINTK(P9_DEBUG_9P, ">>> TRENAME fid %d newdirfid %d name %s\n", 1892 + p9_debug(P9_DEBUG_9P, ">>> TRENAME fid %d newdirfid %d name %s\n", 1893 1893 fid->fid, newdirfid->fid, name); 1894 1894 1895 1895 req = p9_client_rpc(clnt, P9_TRENAME, "dds", fid->fid, ··· 1899 1899 goto error; 1900 1900 } 1901 1901 1902 - P9_DPRINTK(P9_DEBUG_9P, "<<< RRENAME fid %d\n", fid->fid); 1902 + p9_debug(P9_DEBUG_9P, "<<< RRENAME fid %d\n", fid->fid); 1903 1903 1904 1904 p9_free_req(clnt, req); 1905 1905 error: ··· 1917 1917 err = 0; 1918 1918 clnt = olddirfid->clnt; 1919 1919 1920 - P9_DPRINTK(P9_DEBUG_9P, ">>> TRENAMEAT olddirfid %d old name %s" 1920 + p9_debug(P9_DEBUG_9P, ">>> TRENAMEAT olddirfid %d old name %s" 1921 1921 " newdirfid %d new name %s\n", olddirfid->fid, old_name, 1922 1922 newdirfid->fid, new_name); 1923 1923 ··· 1928 1928 goto error; 1929 1929 } 1930 1930 1931 - P9_DPRINTK(P9_DEBUG_9P, "<<< RRENAMEAT newdirfid %d new name %s\n", 1931 + p9_debug(P9_DEBUG_9P, "<<< RRENAMEAT newdirfid %d new name %s\n", 1932 1932 newdirfid->fid, new_name); 1933 1933 1934 1934 p9_free_req(clnt, req); ··· 1956 1956 attr_fid = NULL; 1957 1957 goto error; 1958 1958 } 1959 - P9_DPRINTK(P9_DEBUG_9P, 1959 + p9_debug(P9_DEBUG_9P, 1960 1960 ">>> TXATTRWALK file_fid %d, attr_fid %d name %s\n", 1961 1961 file_fid->fid, attr_fid->fid, attr_name); 1962 1962 ··· 1973 1973 goto clunk_fid; 1974 1974 } 1975 1975 p9_free_req(clnt, req); 1976 - P9_DPRINTK(P9_DEBUG_9P, "<<< RXATTRWALK fid %d size %llu\n", 1976 + p9_debug(P9_DEBUG_9P, "<<< RXATTRWALK fid %d size %llu\n", 1977 1977 attr_fid->fid, *attr_size); 1978 1978 return attr_fid; 1979 1979 clunk_fid: ··· 1994 1994 struct p9_req_t *req; 1995 1995 struct p9_client *clnt; 1996 1996 1997 - P9_DPRINTK(P9_DEBUG_9P, 1997 + p9_debug(P9_DEBUG_9P, 1998 1998 ">>> TXATTRCREATE fid %d name %s size %lld flag %d\n", 1999 1999 fid->fid, name, (long long)attr_size, flags); 2000 2000 err = 0; ··· 2005 2005 err = PTR_ERR(req); 2006 2006 goto error; 2007 2007 } 2008 - P9_DPRINTK(P9_DEBUG_9P, "<<< RXATTRCREATE fid %d\n", fid->fid); 2008 + p9_debug(P9_DEBUG_9P, "<<< RXATTRCREATE fid %d\n", fid->fid); 2009 2009 p9_free_req(clnt, req); 2010 2010 error: 2011 2011 return err; ··· 2019 2019 struct p9_req_t *req; 2020 2020 char *dataptr; 2021 2021 2022 - P9_DPRINTK(P9_DEBUG_9P, ">>> TREADDIR fid %d offset %llu count %d\n", 2022 + p9_debug(P9_DEBUG_9P, ">>> TREADDIR fid %d offset %llu count %d\n", 2023 2023 fid->fid, (long long unsigned) offset, count); 2024 2024 2025 2025 err = 0; ··· 2056 2056 goto free_and_error; 2057 2057 } 2058 2058 2059 - P9_DPRINTK(P9_DEBUG_9P, "<<< RREADDIR count %d\n", count); 2059 + p9_debug(P9_DEBUG_9P, "<<< RREADDIR count %d\n", count); 2060 2060 2061 2061 if (non_zc) 2062 2062 memmove(data, dataptr, count); ··· 2080 2080 2081 2081 err = 0; 2082 2082 clnt = fid->clnt; 2083 - P9_DPRINTK(P9_DEBUG_9P, ">>> TMKNOD fid %d name %s mode %d major %d " 2083 + p9_debug(P9_DEBUG_9P, ">>> TMKNOD fid %d name %s mode %d major %d " 2084 2084 "minor %d\n", fid->fid, name, mode, MAJOR(rdev), MINOR(rdev)); 2085 2085 req = p9_client_rpc(clnt, P9_TMKNOD, "dsdddd", fid->fid, name, mode, 2086 2086 MAJOR(rdev), MINOR(rdev), gid); ··· 2092 2092 trace_9p_protocol_dump(clnt, req->rc); 2093 2093 goto error; 2094 2094 } 2095 - P9_DPRINTK(P9_DEBUG_9P, "<<< RMKNOD qid %x.%llx.%x\n", qid->type, 2095 + p9_debug(P9_DEBUG_9P, "<<< RMKNOD qid %x.%llx.%x\n", qid->type, 2096 2096 (unsigned long long)qid->path, qid->version); 2097 2097 2098 2098 error: ··· 2111 2111 2112 2112 err = 0; 2113 2113 clnt = fid->clnt; 2114 - P9_DPRINTK(P9_DEBUG_9P, ">>> TMKDIR fid %d name %s mode %d gid %d\n", 2114 + p9_debug(P9_DEBUG_9P, ">>> TMKDIR fid %d name %s mode %d gid %d\n", 2115 2115 fid->fid, name, mode, gid); 2116 2116 req = p9_client_rpc(clnt, P9_TMKDIR, "dsdd", fid->fid, name, mode, 2117 2117 gid); ··· 2123 2123 trace_9p_protocol_dump(clnt, req->rc); 2124 2124 goto error; 2125 2125 } 2126 - P9_DPRINTK(P9_DEBUG_9P, "<<< RMKDIR qid %x.%llx.%x\n", qid->type, 2126 + p9_debug(P9_DEBUG_9P, "<<< RMKDIR qid %x.%llx.%x\n", qid->type, 2127 2127 (unsigned long long)qid->path, qid->version); 2128 2128 2129 2129 error: ··· 2141 2141 2142 2142 err = 0; 2143 2143 clnt = fid->clnt; 2144 - P9_DPRINTK(P9_DEBUG_9P, ">>> TLOCK fid %d type %i flags %d " 2144 + p9_debug(P9_DEBUG_9P, ">>> TLOCK fid %d type %i flags %d " 2145 2145 "start %lld length %lld proc_id %d client_id %s\n", 2146 2146 fid->fid, flock->type, flock->flags, flock->start, 2147 2147 flock->length, flock->proc_id, flock->client_id); ··· 2158 2158 trace_9p_protocol_dump(clnt, req->rc); 2159 2159 goto error; 2160 2160 } 2161 - P9_DPRINTK(P9_DEBUG_9P, "<<< RLOCK status %i\n", *status); 2161 + p9_debug(P9_DEBUG_9P, "<<< RLOCK status %i\n", *status); 2162 2162 error: 2163 2163 p9_free_req(clnt, req); 2164 2164 return err; ··· 2174 2174 2175 2175 err = 0; 2176 2176 clnt = fid->clnt; 2177 - P9_DPRINTK(P9_DEBUG_9P, ">>> TGETLOCK fid %d, type %i start %lld " 2177 + p9_debug(P9_DEBUG_9P, ">>> TGETLOCK fid %d, type %i start %lld " 2178 2178 "length %lld proc_id %d client_id %s\n", fid->fid, glock->type, 2179 2179 glock->start, glock->length, glock->proc_id, glock->client_id); 2180 2180 ··· 2191 2191 trace_9p_protocol_dump(clnt, req->rc); 2192 2192 goto error; 2193 2193 } 2194 - P9_DPRINTK(P9_DEBUG_9P, "<<< RGETLOCK type %i start %lld length %lld " 2194 + p9_debug(P9_DEBUG_9P, "<<< RGETLOCK type %i start %lld length %lld " 2195 2195 "proc_id %d client_id %s\n", glock->type, glock->start, 2196 2196 glock->length, glock->proc_id, glock->client_id); 2197 2197 error: ··· 2208 2208 2209 2209 err = 0; 2210 2210 clnt = fid->clnt; 2211 - P9_DPRINTK(P9_DEBUG_9P, ">>> TREADLINK fid %d\n", fid->fid); 2211 + p9_debug(P9_DEBUG_9P, ">>> TREADLINK fid %d\n", fid->fid); 2212 2212 2213 2213 req = p9_client_rpc(clnt, P9_TREADLINK, "d", fid->fid); 2214 2214 if (IS_ERR(req)) ··· 2219 2219 trace_9p_protocol_dump(clnt, req->rc); 2220 2220 goto error; 2221 2221 } 2222 - P9_DPRINTK(P9_DEBUG_9P, "<<< RREADLINK target %s\n", *target); 2222 + p9_debug(P9_DEBUG_9P, "<<< RREADLINK target %s\n", *target); 2223 2223 error: 2224 2224 p9_free_req(clnt, req); 2225 2225 return err;
+4 -2
net/9p/error.c
··· 27 27 * 28 28 */ 29 29 30 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 31 + 30 32 #include <linux/module.h> 31 33 #include <linux/list.h> 32 34 #include <linux/jhash.h> ··· 239 237 if (errno == 0) { 240 238 /* TODO: if error isn't found, add it dynamically */ 241 239 errstr[len] = 0; 242 - printk(KERN_ERR "%s: server reported unknown error %s\n", 243 - __func__, errstr); 240 + pr_err("%s: server reported unknown error %s\n", 241 + __func__, errstr); 244 242 errno = ESERVERFAULT; 245 243 } 246 244
+29 -2
net/9p/mod.c
··· 24 24 * 25 25 */ 26 26 27 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 28 + 27 29 #include <linux/module.h> 30 + #include <linux/errno.h> 31 + #include <linux/sched.h> 28 32 #include <linux/moduleparam.h> 29 33 #include <net/9p/9p.h> 30 34 #include <linux/fs.h> ··· 43 39 EXPORT_SYMBOL(p9_debug_level); 44 40 module_param_named(debug, p9_debug_level, uint, 0); 45 41 MODULE_PARM_DESC(debug, "9P debugging level"); 42 + 43 + void _p9_debug(enum p9_debug_flags level, const char *func, 44 + const char *fmt, ...) 45 + { 46 + struct va_format vaf; 47 + va_list args; 48 + 49 + if ((p9_debug_level & level) != level) 50 + return; 51 + 52 + va_start(args, fmt); 53 + 54 + vaf.fmt = fmt; 55 + vaf.va = &args; 56 + 57 + if (level == P9_DEBUG_9P) 58 + pr_notice("(%8.8d) %pV", task_pid_nr(current), &vaf); 59 + else 60 + pr_notice("-- %s (%d): %pV", func, task_pid_nr(current), &vaf); 61 + 62 + va_end(args); 63 + } 64 + EXPORT_SYMBOL(_p9_debug); 46 65 #endif 47 66 48 67 /* ··· 174 147 int ret = 0; 175 148 176 149 p9_error_init(); 177 - printk(KERN_INFO "Installing 9P2000 support\n"); 150 + pr_info("Installing 9P2000 support\n"); 178 151 p9_trans_fd_init(); 179 152 180 153 return ret; ··· 187 160 188 161 static void __exit exit_p9(void) 189 162 { 190 - printk(KERN_INFO "Unloading 9P2000 support\n"); 163 + pr_info("Unloading 9P2000 support\n"); 191 164 192 165 p9_trans_fd_exit(); 193 166 }
+4 -4
net/9p/protocol.c
··· 534 534 535 535 ret = p9pdu_readf(&fake_pdu, clnt->proto_version, "S", st); 536 536 if (ret) { 537 - P9_DPRINTK(P9_DEBUG_9P, "<<< p9stat_read failed: %d\n", ret); 537 + p9_debug(P9_DEBUG_9P, "<<< p9stat_read failed: %d\n", ret); 538 538 trace_9p_protocol_dump(clnt, &fake_pdu); 539 539 } 540 540 ··· 558 558 pdu->size = size; 559 559 560 560 trace_9p_protocol_dump(clnt, pdu); 561 - P9_DPRINTK(P9_DEBUG_9P, ">>> size=%d type: %d tag: %d\n", pdu->size, 562 - pdu->id, pdu->tag); 561 + p9_debug(P9_DEBUG_9P, ">>> size=%d type: %d tag: %d\n", 562 + pdu->size, pdu->id, pdu->tag); 563 563 564 564 return err; 565 565 } ··· 585 585 ret = p9pdu_readf(&fake_pdu, clnt->proto_version, "Qqbs", &dirent->qid, 586 586 &dirent->d_off, &dirent->d_type, &nameptr); 587 587 if (ret) { 588 - P9_DPRINTK(P9_DEBUG_9P, "<<< p9dirent_read failed: %d\n", ret); 588 + p9_debug(P9_DEBUG_9P, "<<< p9dirent_read failed: %d\n", ret); 589 589 trace_9p_protocol_dump(clnt, &fake_pdu); 590 590 goto out; 591 591 }
+58 -55
net/9p/trans_fd.c
··· 25 25 * 26 26 */ 27 27 28 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 29 + 28 30 #include <linux/in.h> 29 31 #include <linux/module.h> 30 32 #include <linux/net.h> ··· 193 191 unsigned long flags; 194 192 LIST_HEAD(cancel_list); 195 193 196 - P9_DPRINTK(P9_DEBUG_ERROR, "mux %p err %d\n", m, err); 194 + p9_debug(P9_DEBUG_ERROR, "mux %p err %d\n", m, err); 197 195 198 196 spin_lock_irqsave(&m->client->lock, flags); 199 197 ··· 219 217 spin_unlock_irqrestore(&m->client->lock, flags); 220 218 221 219 list_for_each_entry_safe(req, rtmp, &cancel_list, req_list) { 222 - P9_DPRINTK(P9_DEBUG_ERROR, "call back req %p\n", req); 220 + p9_debug(P9_DEBUG_ERROR, "call back req %p\n", req); 223 221 list_del(&req->req_list); 224 222 p9_client_cb(m->client, req); 225 223 } ··· 277 275 return -EREMOTEIO; 278 276 279 277 if (!(ts->rd->f_flags & O_NONBLOCK)) 280 - P9_DPRINTK(P9_DEBUG_ERROR, "blocking read ...\n"); 278 + p9_debug(P9_DEBUG_ERROR, "blocking read ...\n"); 281 279 282 280 ret = kernel_read(ts->rd, ts->rd->f_pos, v, len); 283 281 if (ret <= 0 && ret != -ERESTARTSYS && ret != -EAGAIN) ··· 301 299 if (m->err < 0) 302 300 return; 303 301 304 - P9_DPRINTK(P9_DEBUG_TRANS, "start mux %p pos %d\n", m, m->rpos); 302 + p9_debug(P9_DEBUG_TRANS, "start mux %p pos %d\n", m, m->rpos); 305 303 306 304 if (!m->rbuf) { 307 305 m->rbuf = m->tmp_buf; ··· 310 308 } 311 309 312 310 clear_bit(Rpending, &m->wsched); 313 - P9_DPRINTK(P9_DEBUG_TRANS, "read mux %p pos %d size: %d = %d\n", m, 314 - m->rpos, m->rsize, m->rsize-m->rpos); 311 + p9_debug(P9_DEBUG_TRANS, "read mux %p pos %d size: %d = %d\n", 312 + m, m->rpos, m->rsize, m->rsize-m->rpos); 315 313 err = p9_fd_read(m->client, m->rbuf + m->rpos, 316 314 m->rsize - m->rpos); 317 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p got %d bytes\n", m, err); 315 + p9_debug(P9_DEBUG_TRANS, "mux %p got %d bytes\n", m, err); 318 316 if (err == -EAGAIN) { 319 317 clear_bit(Rworksched, &m->wsched); 320 318 return; ··· 327 325 328 326 if ((!m->req) && (m->rpos == m->rsize)) { /* header read in */ 329 327 u16 tag; 330 - P9_DPRINTK(P9_DEBUG_TRANS, "got new header\n"); 328 + p9_debug(P9_DEBUG_TRANS, "got new header\n"); 331 329 332 330 n = le32_to_cpu(*(__le32 *) m->rbuf); /* read packet size */ 333 331 if (n >= m->client->msize) { 334 - P9_DPRINTK(P9_DEBUG_ERROR, 335 - "requested packet size too big: %d\n", n); 332 + p9_debug(P9_DEBUG_ERROR, 333 + "requested packet size too big: %d\n", n); 336 334 err = -EIO; 337 335 goto error; 338 336 } 339 337 340 338 tag = le16_to_cpu(*(__le16 *) (m->rbuf+5)); /* read tag */ 341 - P9_DPRINTK(P9_DEBUG_TRANS, 342 - "mux %p pkt: size: %d bytes tag: %d\n", m, n, tag); 339 + p9_debug(P9_DEBUG_TRANS, 340 + "mux %p pkt: size: %d bytes tag: %d\n", m, n, tag); 343 341 344 342 m->req = p9_tag_lookup(m->client, tag); 345 343 if (!m->req || (m->req->status != REQ_STATUS_SENT && 346 344 m->req->status != REQ_STATUS_FLSH)) { 347 - P9_DPRINTK(P9_DEBUG_ERROR, "Unexpected packet tag %d\n", 348 - tag); 345 + p9_debug(P9_DEBUG_ERROR, "Unexpected packet tag %d\n", 346 + tag); 349 347 err = -EIO; 350 348 goto error; 351 349 } ··· 366 364 367 365 /* not an else because some packets (like clunk) have no payload */ 368 366 if ((m->req) && (m->rpos == m->rsize)) { /* packet is read in */ 369 - P9_DPRINTK(P9_DEBUG_TRANS, "got new packet\n"); 367 + p9_debug(P9_DEBUG_TRANS, "got new packet\n"); 370 368 spin_lock(&m->client->lock); 371 369 if (m->req->status != REQ_STATUS_ERROR) 372 370 m->req->status = REQ_STATUS_RCVD; ··· 386 384 n = p9_fd_poll(m->client, NULL); 387 385 388 386 if (n & POLLIN) { 389 - P9_DPRINTK(P9_DEBUG_TRANS, "sched read work %p\n", m); 387 + p9_debug(P9_DEBUG_TRANS, "sched read work %p\n", m); 390 388 schedule_work(&m->rq); 391 389 } else 392 390 clear_bit(Rworksched, &m->wsched); ··· 420 418 return -EREMOTEIO; 421 419 422 420 if (!(ts->wr->f_flags & O_NONBLOCK)) 423 - P9_DPRINTK(P9_DEBUG_ERROR, "blocking write ...\n"); 421 + p9_debug(P9_DEBUG_ERROR, "blocking write ...\n"); 424 422 425 423 oldfs = get_fs(); 426 424 set_fs(get_ds()); ··· 462 460 req = list_entry(m->unsent_req_list.next, struct p9_req_t, 463 461 req_list); 464 462 req->status = REQ_STATUS_SENT; 465 - P9_DPRINTK(P9_DEBUG_TRANS, "move req %p\n", req); 463 + p9_debug(P9_DEBUG_TRANS, "move req %p\n", req); 466 464 list_move_tail(&req->req_list, &m->req_list); 467 465 468 466 m->wbuf = req->tc->sdata; ··· 471 469 spin_unlock(&m->client->lock); 472 470 } 473 471 474 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p pos %d size %d\n", m, m->wpos, 475 - m->wsize); 472 + p9_debug(P9_DEBUG_TRANS, "mux %p pos %d size %d\n", 473 + m, m->wpos, m->wsize); 476 474 clear_bit(Wpending, &m->wsched); 477 475 err = p9_fd_write(m->client, m->wbuf + m->wpos, m->wsize - m->wpos); 478 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p sent %d bytes\n", m, err); 476 + p9_debug(P9_DEBUG_TRANS, "mux %p sent %d bytes\n", m, err); 479 477 if (err == -EAGAIN) { 480 478 clear_bit(Wworksched, &m->wsched); 481 479 return; ··· 499 497 n = p9_fd_poll(m->client, NULL); 500 498 501 499 if (n & POLLOUT) { 502 - P9_DPRINTK(P9_DEBUG_TRANS, "sched write work %p\n", m); 500 + p9_debug(P9_DEBUG_TRANS, "sched write work %p\n", m); 503 501 schedule_work(&m->wq); 504 502 } else 505 503 clear_bit(Wworksched, &m->wsched); ··· 553 551 } 554 552 555 553 if (!pwait) { 556 - P9_DPRINTK(P9_DEBUG_ERROR, "not enough wait_address slots\n"); 554 + p9_debug(P9_DEBUG_ERROR, "not enough wait_address slots\n"); 557 555 return; 558 556 } 559 557 ··· 575 573 int n; 576 574 struct p9_conn *m; 577 575 578 - P9_DPRINTK(P9_DEBUG_TRANS, "client %p msize %d\n", client, 579 - client->msize); 576 + p9_debug(P9_DEBUG_TRANS, "client %p msize %d\n", client, client->msize); 580 577 m = kzalloc(sizeof(struct p9_conn), GFP_KERNEL); 581 578 if (!m) 582 579 return ERR_PTR(-ENOMEM); ··· 592 591 593 592 n = p9_fd_poll(client, &m->pt); 594 593 if (n & POLLIN) { 595 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p can read\n", m); 594 + p9_debug(P9_DEBUG_TRANS, "mux %p can read\n", m); 596 595 set_bit(Rpending, &m->wsched); 597 596 } 598 597 599 598 if (n & POLLOUT) { 600 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p can write\n", m); 599 + p9_debug(P9_DEBUG_TRANS, "mux %p can write\n", m); 601 600 set_bit(Wpending, &m->wsched); 602 601 } 603 602 ··· 619 618 620 619 n = p9_fd_poll(m->client, NULL); 621 620 if (n < 0 || n & (POLLERR | POLLHUP | POLLNVAL)) { 622 - P9_DPRINTK(P9_DEBUG_TRANS, "error mux %p err %d\n", m, n); 621 + p9_debug(P9_DEBUG_TRANS, "error mux %p err %d\n", m, n); 623 622 if (n >= 0) 624 623 n = -ECONNRESET; 625 624 p9_conn_cancel(m, n); ··· 627 626 628 627 if (n & POLLIN) { 629 628 set_bit(Rpending, &m->wsched); 630 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p can read\n", m); 629 + p9_debug(P9_DEBUG_TRANS, "mux %p can read\n", m); 631 630 if (!test_and_set_bit(Rworksched, &m->wsched)) { 632 - P9_DPRINTK(P9_DEBUG_TRANS, "sched read work %p\n", m); 631 + p9_debug(P9_DEBUG_TRANS, "sched read work %p\n", m); 633 632 schedule_work(&m->rq); 634 633 } 635 634 } 636 635 637 636 if (n & POLLOUT) { 638 637 set_bit(Wpending, &m->wsched); 639 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p can write\n", m); 638 + p9_debug(P9_DEBUG_TRANS, "mux %p can write\n", m); 640 639 if ((m->wsize || !list_empty(&m->unsent_req_list)) && 641 640 !test_and_set_bit(Wworksched, &m->wsched)) { 642 - P9_DPRINTK(P9_DEBUG_TRANS, "sched write work %p\n", m); 641 + p9_debug(P9_DEBUG_TRANS, "sched write work %p\n", m); 643 642 schedule_work(&m->wq); 644 643 } 645 644 } ··· 662 661 struct p9_trans_fd *ts = client->trans; 663 662 struct p9_conn *m = ts->conn; 664 663 665 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p task %p tcall %p id %d\n", m, 666 - current, req->tc, req->tc->id); 664 + p9_debug(P9_DEBUG_TRANS, "mux %p task %p tcall %p id %d\n", 665 + m, current, req->tc, req->tc->id); 667 666 if (m->err < 0) 668 667 return m->err; 669 668 ··· 687 686 { 688 687 int ret = 1; 689 688 690 - P9_DPRINTK(P9_DEBUG_TRANS, "client %p req %p\n", client, req); 689 + p9_debug(P9_DEBUG_TRANS, "client %p req %p\n", client, req); 691 690 692 691 spin_lock(&client->lock); 693 692 ··· 727 726 728 727 tmp_options = kstrdup(params, GFP_KERNEL); 729 728 if (!tmp_options) { 730 - P9_DPRINTK(P9_DEBUG_ERROR, 731 - "failed to allocate copy of option string\n"); 729 + p9_debug(P9_DEBUG_ERROR, 730 + "failed to allocate copy of option string\n"); 732 731 return -ENOMEM; 733 732 } 734 733 options = tmp_options; ··· 742 741 if (token != Opt_err) { 743 742 r = match_int(&args[0], &option); 744 743 if (r < 0) { 745 - P9_DPRINTK(P9_DEBUG_ERROR, 746 - "integer field, but no integer?\n"); 744 + p9_debug(P9_DEBUG_ERROR, 745 + "integer field, but no integer?\n"); 747 746 continue; 748 747 } 749 748 } ··· 802 801 csocket->sk->sk_allocation = GFP_NOIO; 803 802 fd = sock_map_fd(csocket, 0); 804 803 if (fd < 0) { 805 - P9_EPRINTK(KERN_ERR, "p9_socket_open: failed to map fd\n"); 804 + pr_err("%s (%d): failed to map fd\n", 805 + __func__, task_pid_nr(current)); 806 806 sock_release(csocket); 807 807 kfree(p); 808 808 return fd; ··· 839 837 840 838 static void p9_conn_destroy(struct p9_conn *m) 841 839 { 842 - P9_DPRINTK(P9_DEBUG_TRANS, "mux %p prev %p next %p\n", m, 843 - m->mux_list.prev, m->mux_list.next); 840 + p9_debug(P9_DEBUG_TRANS, "mux %p prev %p next %p\n", 841 + m, m->mux_list.prev, m->mux_list.next); 844 842 845 843 p9_mux_poll_stop(m); 846 844 cancel_work_sync(&m->rq); ··· 921 919 err = __sock_create(read_pnet(&current->nsproxy->net_ns), PF_INET, 922 920 SOCK_STREAM, IPPROTO_TCP, &csocket, 1); 923 921 if (err) { 924 - P9_EPRINTK(KERN_ERR, "p9_trans_tcp: problem creating socket\n"); 922 + pr_err("%s (%d): problem creating socket\n", 923 + __func__, task_pid_nr(current)); 925 924 return err; 926 925 } 927 926 ··· 930 927 (struct sockaddr *)&sin_server, 931 928 sizeof(struct sockaddr_in), 0); 932 929 if (err < 0) { 933 - P9_EPRINTK(KERN_ERR, 934 - "p9_trans_tcp: problem connecting socket to %s\n", 935 - addr); 930 + pr_err("%s (%d): problem connecting socket to %s\n", 931 + __func__, task_pid_nr(current), addr); 936 932 sock_release(csocket); 937 933 return err; 938 934 } ··· 949 947 csocket = NULL; 950 948 951 949 if (strlen(addr) >= UNIX_PATH_MAX) { 952 - P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", 953 - addr); 950 + pr_err("%s (%d): address too long: %s\n", 951 + __func__, task_pid_nr(current), addr); 954 952 return -ENAMETOOLONG; 955 953 } 956 954 ··· 959 957 err = __sock_create(read_pnet(&current->nsproxy->net_ns), PF_UNIX, 960 958 SOCK_STREAM, 0, &csocket, 1); 961 959 if (err < 0) { 962 - P9_EPRINTK(KERN_ERR, "p9_trans_unix: problem creating socket\n"); 960 + pr_err("%s (%d): problem creating socket\n", 961 + __func__, task_pid_nr(current)); 962 + 963 963 return err; 964 964 } 965 965 err = csocket->ops->connect(csocket, (struct sockaddr *)&sun_server, 966 966 sizeof(struct sockaddr_un) - 1, 0); 967 967 if (err < 0) { 968 - P9_EPRINTK(KERN_ERR, 969 - "p9_trans_unix: problem connecting socket: %s: %d\n", 970 - addr, err); 968 + pr_err("%s (%d): problem connecting socket: %s: %d\n", 969 + __func__, task_pid_nr(current), addr, err); 971 970 sock_release(csocket); 972 971 return err; 973 972 } ··· 986 983 parse_opts(args, &opts); 987 984 988 985 if (opts.rfd == ~0 || opts.wfd == ~0) { 989 - printk(KERN_ERR "v9fs: Insufficient options for proto=fd\n"); 986 + pr_err("Insufficient options for proto=fd\n"); 990 987 return -ENOPROTOOPT; 991 988 } 992 989 ··· 1053 1050 { 1054 1051 unsigned long flags; 1055 1052 1056 - P9_DPRINTK(P9_DEBUG_TRANS, "start %p\n", current); 1053 + p9_debug(P9_DEBUG_TRANS, "start %p\n", current); 1057 1054 1058 1055 spin_lock_irqsave(&p9_poll_lock, flags); 1059 1056 while (!list_empty(&p9_poll_pending_list)) { ··· 1069 1066 } 1070 1067 spin_unlock_irqrestore(&p9_poll_lock, flags); 1071 1068 1072 - P9_DPRINTK(P9_DEBUG_TRANS, "finish\n"); 1069 + p9_debug(P9_DEBUG_TRANS, "finish\n"); 1073 1070 } 1074 1071 1075 1072 int p9_trans_fd_init(void)
+13 -13
net/9p/trans_rdma.c
··· 26 26 * 27 27 */ 28 28 29 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 30 + 29 31 #include <linux/in.h> 30 32 #include <linux/module.h> 31 33 #include <linux/net.h> ··· 180 178 181 179 tmp_options = kstrdup(params, GFP_KERNEL); 182 180 if (!tmp_options) { 183 - P9_DPRINTK(P9_DEBUG_ERROR, 184 - "failed to allocate copy of option string\n"); 181 + p9_debug(P9_DEBUG_ERROR, 182 + "failed to allocate copy of option string\n"); 185 183 return -ENOMEM; 186 184 } 187 185 options = tmp_options; ··· 194 192 token = match_token(p, tokens, args); 195 193 r = match_int(&args[0], &option); 196 194 if (r < 0) { 197 - P9_DPRINTK(P9_DEBUG_ERROR, 198 - "integer field, but no integer?\n"); 195 + p9_debug(P9_DEBUG_ERROR, 196 + "integer field, but no integer?\n"); 199 197 continue; 200 198 } 201 199 switch (token) { ··· 303 301 return; 304 302 305 303 err_out: 306 - P9_DPRINTK(P9_DEBUG_ERROR, "req %p err %d status %d\n", 307 - req, err, status); 304 + p9_debug(P9_DEBUG_ERROR, "req %p err %d status %d\n", req, err, status); 308 305 rdma->state = P9_RDMA_FLUSHING; 309 306 client->status = Disconnected; 310 307 } ··· 319 318 320 319 static void qp_event_handler(struct ib_event *event, void *context) 321 320 { 322 - P9_DPRINTK(P9_DEBUG_ERROR, "QP event %d context %p\n", event->event, 323 - context); 321 + p9_debug(P9_DEBUG_ERROR, "QP event %d context %p\n", 322 + event->event, context); 324 323 } 325 324 326 325 static void cq_comp_handler(struct ib_cq *cq, void *cq_context) ··· 346 345 break; 347 346 348 347 default: 349 - printk(KERN_ERR "9prdma: unexpected completion type, " 350 - "c->wc_op=%d, wc.opcode=%d, status=%d\n", 348 + pr_err("unexpected completion type, c->wc_op=%d, wc.opcode=%d, status=%d\n", 351 349 c->wc_op, wc.opcode, wc.status); 352 350 break; 353 351 } ··· 356 356 357 357 static void cq_event_handler(struct ib_event *e, void *v) 358 358 { 359 - P9_DPRINTK(P9_DEBUG_ERROR, "CQ event %d context %p\n", e->event, v); 359 + p9_debug(P9_DEBUG_ERROR, "CQ event %d context %p\n", e->event, v); 360 360 } 361 361 362 362 static void rdma_destroy_trans(struct p9_trans_rdma *rdma) ··· 407 407 return ib_post_recv(rdma->qp, &wr, &bad_wr); 408 408 409 409 error: 410 - P9_DPRINTK(P9_DEBUG_ERROR, "EIO\n"); 410 + p9_debug(P9_DEBUG_ERROR, "EIO\n"); 411 411 return -EIO; 412 412 } 413 413 ··· 500 500 kfree(c); 501 501 kfree(rpl_context->rc); 502 502 kfree(rpl_context); 503 - P9_DPRINTK(P9_DEBUG_ERROR, "EIO\n"); 503 + p9_debug(P9_DEBUG_ERROR, "EIO\n"); 504 504 return -EIO; 505 505 err_free1: 506 506 kfree(rpl_context->rc);
+17 -17
net/9p/trans_virtio.c
··· 26 26 * 27 27 */ 28 28 29 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 30 + 29 31 #include <linux/in.h> 30 32 #include <linux/module.h> 31 33 #include <linux/net.h> ··· 147 145 struct p9_req_t *req; 148 146 unsigned long flags; 149 147 150 - P9_DPRINTK(P9_DEBUG_TRANS, ": request done\n"); 148 + p9_debug(P9_DEBUG_TRANS, ": request done\n"); 151 149 152 150 while (1) { 153 151 spin_lock_irqsave(&chan->lock, flags); ··· 160 158 spin_unlock_irqrestore(&chan->lock, flags); 161 159 /* Wakeup if anyone waiting for VirtIO ring space. */ 162 160 wake_up(chan->vc_wq); 163 - P9_DPRINTK(P9_DEBUG_TRANS, ": rc %p\n", rc); 164 - P9_DPRINTK(P9_DEBUG_TRANS, ": lookup tag %d\n", rc->tag); 161 + p9_debug(P9_DEBUG_TRANS, ": rc %p\n", rc); 162 + p9_debug(P9_DEBUG_TRANS, ": lookup tag %d\n", rc->tag); 165 163 req = p9_tag_lookup(chan->client, rc->tag); 166 164 req->status = REQ_STATUS_RCVD; 167 165 p9_client_cb(chan->client, req); ··· 259 257 unsigned long flags; 260 258 struct virtio_chan *chan = client->trans; 261 259 262 - P9_DPRINTK(P9_DEBUG_TRANS, "9p debug: virtio request\n"); 260 + p9_debug(P9_DEBUG_TRANS, "9p debug: virtio request\n"); 263 261 264 262 req->status = REQ_STATUS_SENT; 265 263 req_retry: ··· 282 280 if (err == -ERESTARTSYS) 283 281 return err; 284 282 285 - P9_DPRINTK(P9_DEBUG_TRANS, "9p:Retry virtio request\n"); 283 + p9_debug(P9_DEBUG_TRANS, "Retry virtio request\n"); 286 284 goto req_retry; 287 285 } else { 288 286 spin_unlock_irqrestore(&chan->lock, flags); 289 - P9_DPRINTK(P9_DEBUG_TRANS, 290 - "9p debug: " 291 - "virtio rpc add_buf returned failure"); 287 + p9_debug(P9_DEBUG_TRANS, 288 + "virtio rpc add_buf returned failure\n"); 292 289 return -EIO; 293 290 } 294 291 } 295 292 virtqueue_kick(chan->vq); 296 293 spin_unlock_irqrestore(&chan->lock, flags); 297 294 298 - P9_DPRINTK(P9_DEBUG_TRANS, "9p debug: virtio request kicked\n"); 295 + p9_debug(P9_DEBUG_TRANS, "virtio request kicked\n"); 299 296 return 0; 300 297 } 301 298 ··· 355 354 struct page **in_pages = NULL, **out_pages = NULL; 356 355 struct virtio_chan *chan = client->trans; 357 356 358 - P9_DPRINTK(P9_DEBUG_TRANS, "9p debug: virtio request\n"); 357 + p9_debug(P9_DEBUG_TRANS, "virtio request\n"); 359 358 360 359 if (uodata) { 361 360 out_nr_pages = p9_nr_pages(uodata, outlen); ··· 424 423 if (err == -ERESTARTSYS) 425 424 goto err_out; 426 425 427 - P9_DPRINTK(P9_DEBUG_TRANS, "9p:Retry virtio request\n"); 426 + p9_debug(P9_DEBUG_TRANS, "Retry virtio request\n"); 428 427 goto req_retry_pinned; 429 428 } else { 430 429 spin_unlock_irqrestore(&chan->lock, flags); 431 - P9_DPRINTK(P9_DEBUG_TRANS, 432 - "9p debug: " 433 - "virtio rpc add_buf returned failure"); 430 + p9_debug(P9_DEBUG_TRANS, 431 + "virtio rpc add_buf returned failure\n"); 434 432 err = -EIO; 435 433 goto err_out; 436 434 } 437 435 } 438 436 virtqueue_kick(chan->vq); 439 437 spin_unlock_irqrestore(&chan->lock, flags); 440 - P9_DPRINTK(P9_DEBUG_TRANS, "9p debug: virtio request kicked\n"); 438 + p9_debug(P9_DEBUG_TRANS, "virtio request kicked\n"); 441 439 err = wait_event_interruptible(*req->wq, 442 440 req->status >= REQ_STATUS_RCVD); 443 441 /* ··· 491 491 492 492 chan = kmalloc(sizeof(struct virtio_chan), GFP_KERNEL); 493 493 if (!chan) { 494 - printk(KERN_ERR "9p: Failed to allocate virtio 9P channel\n"); 494 + pr_err("Failed to allocate virtio 9P channel\n"); 495 495 err = -ENOMEM; 496 496 goto fail; 497 497 } ··· 592 592 mutex_unlock(&virtio_9p_lock); 593 593 594 594 if (!found) { 595 - printk(KERN_ERR "9p: no channels available\n"); 595 + pr_err("no channels available\n"); 596 596 return ret; 597 597 } 598 598
+2 -2
net/9p/util.c
··· 106 106 else if (error) 107 107 return -1; 108 108 109 - P9_DPRINTK(P9_DEBUG_MUX, " id %d pool %p\n", i, p); 109 + p9_debug(P9_DEBUG_MUX, " id %d pool %p\n", i, p); 110 110 return i; 111 111 } 112 112 EXPORT_SYMBOL(p9_idpool_get); ··· 124 124 { 125 125 unsigned long flags; 126 126 127 - P9_DPRINTK(P9_DEBUG_MUX, " id %d pool %p\n", id, p); 127 + p9_debug(P9_DEBUG_MUX, " id %d pool %p\n", id, p); 128 128 129 129 spin_lock_irqsave(&p->lock, flags); 130 130 idr_remove(&p->pool, id);