Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

coccinelle: irqf_oneshot: reduce the severity due to false positives

The IRQF_ONESHOT should be present for threaded IRQ using default
primary handler. However intetrupt of many child devices, e.g. children
of MFD, is nested thus the IRQF_ONESHOT is not needed. The coccinelle
message about error misleads submitters and reviewers about the severity
of the issue, so make it a warning and mention possible false positive.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

authored by

Krzysztof Kozlowski and committed by
Julia Lawall
5d2db9bb 7845daa8

+2 -2
+2 -2
scripts/coccinelle/misc/irqf_oneshot.cocci
··· 103 103 @script:python depends on org@ 104 104 p << match.p; 105 105 @@ 106 - msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" 106 + msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)" 107 107 coccilib.org.print_todo(p[0],msg) 108 108 109 109 @script:python depends on report@ 110 110 p << match.p; 111 111 @@ 112 - msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" 112 + msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)" 113 113 coccilib.report.print_report(p[0],msg)