timer: Remove users of TIMER_DEFERRED_INITIALIZER

This removes uses of TIMER_DEFERRED_INITIALIZER and chooses a location
to call timer_setup() from before add_timer() or mod_timer() is called.
Adjusts callbacks to use from_timer() as needed.

Signed-off-by: Kees Cook <[e-mail]>
Signed-off-by: Thomas Gleixner <[e-mail]>
Cc: [e-mail]
Cc: Petr Mladek <[e-mail]>
Cc: Benjamin Herrenschmidt <[e-mail]>
Cc: Lai Jiangshan <[e-mail]>
Cc: Sebastian Reichel <[e-mail]>
Cc: Kalle Valo <[e-mail]>
Cc: Paul Mackerras <[e-mail]>
Cc: Pavel Machek <[e-mail]>
Cc: [e-mail]
Cc: Chris Metcalf <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: "James E.J. Bottomley" <[e-mail]>
Cc: Wim Van Sebroeck <[e-mail]>
Cc: Michael Ellerman <[e-mail]>
Cc: Ursula Braun <[e-mail]>
Cc: Geert Uytterhoeven <[e-mail]>
Cc: Viresh Kumar <[e-mail]>
Cc: Harish Patil <[e-mail]>
Cc: Stephen Boyd <[e-mail]>
Cc: Guenter Roeck <[e-mail]>
Cc: Manish Chopra <[e-mail]>
Cc: Len Brown <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: [e-mail]
Cc: Heiko Carstens <[e-mail]>
Cc: Martin Schwidefsky <[e-mail]>
Cc: Julian Wiedmann <[e-mail]>
Cc: John Stultz <[e-mail]>
Cc: Mark Gross <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: "Martin K. Petersen" <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: "Rafael J. Wysocki" <[e-mail]>
Cc: Oleg Nesterov <[e-mail]>
Cc: Ralf Baechle <[e-mail]>
Cc: Stefan Richter <[e-mail]>
Cc: Michael Reed <[e-mail]>
Cc: [e-mail]
Cc: Tejun Heo <[e-mail]>
Cc: Andrew Morton <[e-mail]>
Cc: [e-mail]
Cc: Sudip Mukherjee <[e-mail]>
Link: https://lkml.kernel.org/r/[e-mail]

arch/s390/kernel/lgr.c

···
 /*
  * LGR timer callback
  */
-static void lgr_timer_fn(unsigned long ignored)
+static void lgr_timer_fn(struct timer_list *unused)
 {
 	lgr_info_log();
 	lgr_timer_set();
 }
 
-static struct timer_list lgr_timer =
-	TIMER_DEFERRED_INITIALIZER(lgr_timer_fn, 0, 0);
+static struct timer_list lgr_timer;
 
 /*
  * Setup next LGR timer
···
 	debug_register_view(lgr_dbf, &debug_hex_ascii_view);
 	lgr_info_get(&lgr_info_last);
 	debug_event(lgr_dbf, 1, &lgr_info_last, sizeof(lgr_info_last));
+	timer_setup(&lgr_timer, lgr_timer_fn, TIMER_DEFERRABLE);
 	lgr_timer_set();
 	return 0;
 }

arch/s390/kernel/topology.c

···
 	flush_work(&topology_work);
 }
 
-static void topology_timer_fn(unsigned long ignored)
+static void topology_timer_fn(struct timer_list *unused)
 {
 	if (ptf(PTF_CHECK))
 		topology_schedule_update();
 	set_topology_timer();
 }
 
-static struct timer_list topology_timer =
-	TIMER_DEFERRED_INITIALIZER(topology_timer_fn, 0, 0);
+static struct timer_list topology_timer;
 
 static atomic_t topology_poll = ATOMIC_INIT(0);
 
···
 
 static int __init topology_init(void)
 {
+	timer_setup(&topology_timer, topology_timer_fn, TIMER_DEFERRABLE);
 	if (MACHINE_HAS_TOPOLOGY)
 		set_topology_timer();
 	else

kernel/workqueue.c

···
  */
 #ifdef CONFIG_WQ_WATCHDOG
 
-static void wq_watchdog_timer_fn(unsigned long data);
-
 static unsigned long wq_watchdog_thresh = 30;
-static struct timer_list wq_watchdog_timer =
-	TIMER_DEFERRED_INITIALIZER(wq_watchdog_timer_fn, 0, 0);
+static struct timer_list wq_watchdog_timer;
 
 static unsigned long wq_watchdog_touched = INITIAL_JIFFIES;
 static DEFINE_PER_CPU(unsigned long, wq_watchdog_touched_cpu) = INITIAL_JIFFIES;
···
 		per_cpu(wq_watchdog_touched_cpu, cpu) = jiffies;
 }
 
-static void wq_watchdog_timer_fn(unsigned long data)
+static void wq_watchdog_timer_fn(struct timer_list *unused)
 {
 	unsigned long thresh = READ_ONCE(wq_watchdog_thresh) * HZ;
 	bool lockup_detected = false;
···
 
 static void wq_watchdog_init(void)
 {
+	timer_setup(&wq_watchdog_timer, wq_watchdog_timer_fn, TIMER_DEFERRABLE);
 	wq_watchdog_set_thresh(wq_watchdog_thresh);
 }