Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/clone3: ksft_exit functions do not return

After commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that
unconditionally call exit() as __noreturn"), ksft_exit_...() functions
are marked as __noreturn, which means the return type should not be
'int' but 'void' because they are not returning anything (and never were
since exit() has always been called).

To facilitate updating the return type of these functions, remove
'return' before the calls to ksft_exit_{pass,fail}(), as __noreturn
prevents the compiler from warning that a caller of the ksft_exit
functions does not return a value because the program will terminate
upon calling these functions.

Just removing 'return' would have resulted in

!ret ? ksft_exit_pass() : ksft_exit_fail();

so convert that into the more idiomatic

if (ret)
ksft_exit_fail();
ksft_exit_pass();

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

Nathan Chancellor and committed by
Shuah Khan
5ca61106 5b1c8b1e

+4 -2
+1 -1
tools/testing/selftests/clone3/clone3_clear_sighand.c
··· 120 120 121 121 test_clone3_clear_sighand(); 122 122 123 - return ksft_exit_pass(); 123 + ksft_exit_pass(); 124 124 }
+3 -1
tools/testing/selftests/clone3/clone3_set_tid.c
··· 412 412 out: 413 413 ret = 0; 414 414 415 - return !ret ? ksft_exit_pass() : ksft_exit_fail(); 415 + if (ret) 416 + ksft_exit_fail(); 417 + ksft_exit_pass(); 416 418 }