Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sunrpc: update nextcheck time when adding new cache entries

The cache_detail structure uses a "nextcheck" field to control hash table
scanning intervals. When a table scan begins, nextcheck is set to current
time plus 1800 seconds. During scanning, if cache_detail is not empty and
a cache entry's expiry time is earlier than the current nextcheck, the
nextcheck is updated to that expiry time.

This mechanism ensures that:
1) Empty cache_details are scanned every 1800 seconds to avoid unnecessary
scans
2) Non-empty cache_details are scanned based on the earliest expiry time
found

However, when adding a new cache entry to an empty cache_detail, the
nextcheck time was not being updated, remaining at 1800 seconds. This
could delay cache cleanup for up to 1800 seconds, potentially blocking
threads(such as nfsd) that are waiting for cache cleanup.

Fix this by updating the nextcheck time whenever a new cache entry is
added.

Signed-off-by: Long Li <leo.lilong@huawei.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

authored by

Long Li and committed by
Chuck Lever
5ca00634 b53a4297

+2
+2
net/sunrpc/cache.c
··· 135 135 136 136 hlist_add_head_rcu(&new->cache_list, head); 137 137 detail->entries++; 138 + if (detail->nextcheck > new->expiry_time) 139 + detail->nextcheck = new->expiry_time + 1; 138 140 cache_get(new); 139 141 spin_unlock(&detail->hash_lock); 140 142