Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower()

Bitwise AND was intended instead of OR. With the current code the
condition is always true.

Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Pin-yen Lin <treapking@chromium.org>
Acked-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/aK8Au3CgZSTvfEJ6@stanley.mountain

authored by

Dan Carpenter and committed by
Douglas Anderson
5c76c794 1e00a12d

+1 -1
+1 -1
drivers/hid/i2c-hid/i2c-hid-core.c
··· 1189 1189 struct device *dev = &ihid->client->dev; 1190 1190 int ret; 1191 1191 1192 - if (ihid->hid->initial_quirks | HID_QUIRK_POWER_ON_AFTER_BACKLIGHT) 1192 + if (ihid->hid->initial_quirks & HID_QUIRK_POWER_ON_AFTER_BACKLIGHT) 1193 1193 ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_enable_funcs; 1194 1194 else 1195 1195 ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_prepare_funcs;