Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/bpf: adjust global_func15 test to validate prog exit precision

Add one more subtest to global_func15 selftest to validate that
verifier properly marks r0 as precise and avoids erroneous state pruning
of the branch that has return value outside of expected [0, 1] value.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20231202175705.885270-11-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

authored by

Andrii Nakryiko and committed by
Alexei Starovoitov
5c19e1d0 e02dea15

+32
+32
tools/testing/selftests/bpf/progs/test_global_func15.c
··· 22 22 23 23 return v; 24 24 } 25 + 26 + SEC("cgroup_skb/ingress") 27 + __log_level(2) __flag(BPF_F_TEST_STATE_FREQ) 28 + __failure 29 + /* check that fallthrough code path marks r0 as precise */ 30 + __msg("mark_precise: frame0: regs=r0 stack= before 2: (b7) r0 = 1") 31 + /* check that branch code path marks r0 as precise */ 32 + __msg("mark_precise: frame0: regs=r0 stack= before 0: (85) call bpf_get_prandom_u32#7") 33 + __msg("At program exit the register R0 has ") 34 + __naked int global_func15_tricky_pruning(void) 35 + { 36 + asm volatile ( 37 + "call %[bpf_get_prandom_u32];" 38 + "if r0 s> 1000 goto 1f;" 39 + "r0 = 1;" 40 + "1:" 41 + "goto +0;" /* checkpoint */ 42 + /* cgroup_skb/ingress program is expected to return [0, 1] 43 + * values, so branch above makes sure that in a fallthrough 44 + * case we have a valid 1 stored in R0 register, but in 45 + * a branch case we assign some random value to R0. So if 46 + * there is something wrong with precision tracking for R0 at 47 + * program exit, we might erronenously prune branch case, 48 + * because R0 in fallthrough case is imprecise (and thus any 49 + * value is valid from POV of verifier is_state_equal() logic) 50 + */ 51 + "exit;" 52 + : 53 + : __imm(bpf_get_prandom_u32) 54 + : __clobber_common 55 + ); 56 + }