Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: remove bindings for pinconf options needing more thought

Some options currently take arguments in unspecified driver-specific units.
As pointed out by Stephen Warren, driver specific values should not be part
of generic devicetree bindings describing the hardware.

Therefore remove the critical bindings again, before they become part of
an official release.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Heiko Stübner and committed by
Linus Walleij
5b81d55c a7b3bf55

-13
-10
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
··· 154 154 drive-strength - sink or source at most X mA 155 155 input-schmitt-enable - enable schmitt-trigger mode 156 156 input-schmitt-disable - disable schmitt-trigger mode 157 - input-schmitt - run in schmitt-trigger mode with hysteresis X 158 157 input-debounce - debounce mode with debound time X 159 - power-source - select power source X 160 - slew-rate - use slew-rate X 161 158 low-power-enable - enable low power mode 162 159 low-power-disable - disable low power mode 163 160 output-low - set the pin to output mode with low level ··· 167 170 168 171 - drive-strength takes as argument the target strength in mA. 169 172 170 - - input-schmitt takes as argument the adjustable hysteresis in a 171 - driver-specific format 172 - 173 173 - input-debounce takes the debounce time in usec as argument 174 174 or 0 to disable debouncing 175 - 176 - - power-source argument is the custom value describing the source to select 177 - 178 - - slew-rate takes as argument the target rate in a driver-specific format 179 175 180 176 All parameters not listed here, do not take an argument. 181 177
-3
drivers/pinctrl/pinconf-generic.c
··· 161 161 { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 0 }, 162 162 { "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 }, 163 163 { "input-schmitt-disable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 0 }, 164 - { "input-schmitt", PIN_CONFIG_INPUT_SCHMITT, 0 }, 165 164 { "input-debounce", PIN_CONFIG_INPUT_DEBOUNCE, 0 }, 166 - { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, 167 - { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 }, 168 165 { "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 }, 169 166 { "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 }, 170 167 { "output-low", PIN_CONFIG_OUTPUT, 0, },