Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/exynos: simplify set_pixfmt() in DECON and FIMD drivers

DRM core already checks the validity of the pixelformat.

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Signed-off-by: Inki Dae <inki.dae@samsung.com>

authored by

Tobias Jakobi and committed by
Inki Dae
5b7b1b7f ac60944c

+3 -16
+1 -3
drivers/gpu/drm/exynos/exynos5433_drm_decon.c
··· 279 279 val |= WINCONx_BURSTLEN_16WORD; 280 280 break; 281 281 case DRM_FORMAT_ARGB8888: 282 + default: 282 283 val |= WINCONx_BPPMODE_32BPP_A8888; 283 284 val |= WINCONx_WSWP_F | WINCONx_BLD_PIX_F | WINCONx_ALPHA_SEL_F; 284 285 val |= WINCONx_BURSTLEN_16WORD; 285 286 break; 286 - default: 287 - DRM_ERROR("Proper pixel format is not set\n"); 288 - return; 289 287 } 290 288 291 289 DRM_DEBUG_KMS("cpp = %u\n", fb->format->cpp[0]);
+1 -6
drivers/gpu/drm/exynos/exynos7_drm_decon.c
··· 309 309 val |= WINCONx_BURSTLEN_16WORD; 310 310 break; 311 311 case DRM_FORMAT_BGRA8888: 312 + default: 312 313 val |= WINCONx_BPPMODE_32BPP_BGRA | WINCONx_BLD_PIX | 313 314 WINCONx_ALPHA_SEL; 314 - val |= WINCONx_BURSTLEN_16WORD; 315 - break; 316 - default: 317 - DRM_DEBUG_KMS("invalid pixel size so using unpacked 24bpp.\n"); 318 - 319 - val |= WINCONx_BPPMODE_24BPP_xRGB; 320 315 val |= WINCONx_BURSTLEN_16WORD; 321 316 break; 322 317 }
+1 -7
drivers/gpu/drm/exynos/exynos_drm_fimd.c
··· 583 583 val |= WINCONx_BURSTLEN_16WORD; 584 584 break; 585 585 case DRM_FORMAT_ARGB8888: 586 + default: 586 587 val |= WINCON1_BPPMODE_25BPP_A1888 587 588 | WINCON1_BLD_PIX | WINCON1_ALPHA_SEL; 588 - val |= WINCONx_WSWP; 589 - val |= WINCONx_BURSTLEN_16WORD; 590 - break; 591 - default: 592 - DRM_DEBUG_KMS("invalid pixel size so using unpacked 24bpp.\n"); 593 - 594 - val |= WINCON0_BPPMODE_24BPP_888; 595 589 val |= WINCONx_WSWP; 596 590 val |= WINCONx_BURSTLEN_16WORD; 597 591 break;