Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mlxsw: core: Enable devlink reload only on probe

Call devlink enable only during probe time and avoid deadlock
during reload.

Reported-by: Shalom Toledo <shalomt@mellanox.com>
Fixes: a0c76345e3d3 ("devlink: disallow reload operation during device cleanup")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Tested-by: Shalom Toledo <shalomt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jiri Pirko and committed by
David S. Miller
5b67a3ed 1287723a

+3 -2
+3 -2
drivers/net/ethernet/mellanox/mlxsw/core.c
··· 1198 1198 if (err) 1199 1199 goto err_thermal_init; 1200 1200 1201 - if (mlxsw_driver->params_register) { 1201 + if (mlxsw_driver->params_register) 1202 1202 devlink_params_publish(devlink); 1203 + 1204 + if (!reload) 1203 1205 devlink_reload_enable(devlink); 1204 - } 1205 1206 1206 1207 return 0; 1207 1208