Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

s390: do not clobber personality flags in sys_32_personality()

There are multiple errors in how sys_32_personality() handles personality
flags stored in top three bytes.

- directly comparing current->personality against PER_LINUX32 doesn't work
in cases when any of the personality flags stored in the top three bytes
are used.
- directly forcefully setting personality to PER_LINUX32 or PER_LINUX
discards any flags stored in the top three bytes

Fix the first one by properly using personality() macro to compare only
PER_MASK bytes.
Fix the second one by setting only the bits that should be set, instead of
overwriting the whole value.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

authored by

Jiri Kosina and committed by
Martin Schwidefsky
5ab37e1b c63cb468

+5 -4
+5 -4
arch/s390/kernel/sys_s390.c
··· 81 81 { 82 82 unsigned int ret; 83 83 84 - if (current->personality == PER_LINUX32 && personality == PER_LINUX) 85 - personality = PER_LINUX32; 84 + if (personality(current->personality) == PER_LINUX32 && 85 + personality(personality) == PER_LINUX) 86 + personality |= PER_LINUX32; 86 87 ret = sys_personality(personality); 87 - if (ret == PER_LINUX32) 88 - ret = PER_LINUX; 88 + if (personality(ret) == PER_LINUX32) 89 + ret &= ~PER_LINUX32; 89 90 90 91 return ret; 91 92 }