Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/68328fb: Initialize fb_ops to fbdev I/O-memory helpers

Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-3-tzimmermann@suse.de

+3 -6
+2 -3
drivers/video/fbdev/68328fb.c
··· 95 95 96 96 static const struct fb_ops mc68x328fb_ops = { 97 97 .owner = THIS_MODULE, 98 + __FB_DEFAULT_IOMEM_OPS_RDWR, 98 99 .fb_check_var = mc68x328fb_check_var, 99 100 .fb_set_par = mc68x328fb_set_par, 100 101 .fb_setcolreg = mc68x328fb_setcolreg, 101 102 .fb_pan_display = mc68x328fb_pan_display, 102 - .fb_fillrect = cfb_fillrect, 103 - .fb_copyarea = cfb_copyarea, 104 - .fb_imageblit = cfb_imageblit, 103 + __FB_DEFAULT_IOMEM_OPS_DRAW, 105 104 .fb_mmap = mc68x328fb_mmap, 106 105 }; 107 106
+1 -3
drivers/video/fbdev/Kconfig
··· 1541 1541 config FB_68328 1542 1542 bool "Motorola 68328 native frame buffer support" 1543 1543 depends on (FB = y) && (M68328 || M68EZ328 || M68VZ328) 1544 - select FB_CFB_FILLRECT 1545 - select FB_CFB_COPYAREA 1546 - select FB_CFB_IMAGEBLIT 1544 + select FB_IOMEM_HELPERS 1547 1545 help 1548 1546 Say Y here if you want to support the built-in frame buffer of 1549 1547 the Motorola 68328 CPU family.