Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lkdtm: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

+2 -11
+2 -11
drivers/misc/lkdtm/core.c
··· 429 429 430 430 /* Register debugfs interface */ 431 431 lkdtm_debugfs_root = debugfs_create_dir("provoke-crash", NULL); 432 - if (!lkdtm_debugfs_root) { 433 - pr_err("creating root dir failed\n"); 434 - return -ENODEV; 435 - } 436 432 437 433 /* Install debugfs trigger files. */ 438 434 for (i = 0; i < ARRAY_SIZE(crashpoints); i++) { 439 435 struct crashpoint *cur = &crashpoints[i]; 440 - struct dentry *de; 441 436 442 - de = debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, 443 - cur, &cur->fops); 444 - if (de == NULL) { 445 - pr_err("could not create crashpoint %s\n", cur->name); 446 - goto out_err; 447 - } 437 + debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, cur, 438 + &cur->fops); 448 439 } 449 440 450 441 /* Install crashpoint if one was selected. */