Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bonding: use pr_debug instead of own macros

Use pr_debug() instead of own macros.

Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Holger Eitzenberger and committed by
David S. Miller
5a03cdb7 ef65583d

+82 -98
+29 -31
drivers/net/bonding/bond_3ad.c
··· 20 20 * 21 21 */ 22 22 23 - //#define BONDING_DEBUG 1 24 - 25 23 #include <linux/skbuff.h> 26 24 #include <linux/if_ether.h> 27 25 #include <linux/netdevice.h> ··· 379 381 } 380 382 } 381 383 382 - dprintk("Port %d Received link speed %d update from adapter\n", port->actor_port_number, speed); 384 + pr_debug("Port %d Received link speed %d update from adapter\n", port->actor_port_number, speed); 383 385 return speed; 384 386 } 385 387 ··· 405 407 switch (slave->duplex) { 406 408 case DUPLEX_FULL: 407 409 retval=0x1; 408 - dprintk("Port %d Received status full duplex update from adapter\n", port->actor_port_number); 410 + pr_debug("Port %d Received status full duplex update from adapter\n", port->actor_port_number); 409 411 break; 410 412 case DUPLEX_HALF: 411 413 default: 412 414 retval=0x0; 413 - dprintk("Port %d Received status NOT full duplex update from adapter\n", port->actor_port_number); 415 + pr_debug("Port %d Received status NOT full duplex update from adapter\n", port->actor_port_number); 414 416 break; 415 417 } 416 418 } ··· 1017 1019 1018 1020 // check if the state machine was changed 1019 1021 if (port->sm_mux_state != last_state) { 1020 - dprintk("Mux Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_mux_state); 1022 + pr_debug("Mux Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_mux_state); 1021 1023 switch (port->sm_mux_state) { 1022 1024 case AD_MUX_DETACHED: 1023 1025 __detach_bond_from_agg(port); ··· 1116 1118 1117 1119 // check if the State machine was changed or new lacpdu arrived 1118 1120 if ((port->sm_rx_state != last_state) || (lacpdu)) { 1119 - dprintk("Rx Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_rx_state); 1121 + pr_debug("Rx Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_rx_state); 1120 1122 switch (port->sm_rx_state) { 1121 1123 case AD_RX_INITIALIZE: 1122 1124 if (!(port->actor_oper_port_key & AD_DUPLEX_KEY_BITS)) { ··· 1203 1205 __update_lacpdu_from_port(port); 1204 1206 // send the lacpdu 1205 1207 if (ad_lacpdu_send(port) >= 0) { 1206 - dprintk("Sent LACPDU on port %d\n", port->actor_port_number); 1208 + pr_debug("Sent LACPDU on port %d\n", port->actor_port_number); 1207 1209 // mark ntt as false, so it will not be sent again until demanded 1208 1210 port->ntt = 0; 1209 1211 } ··· 1276 1278 1277 1279 // check if the state machine was changed 1278 1280 if (port->sm_periodic_state != last_state) { 1279 - dprintk("Periodic Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_periodic_state); 1281 + pr_debug("Periodic Machine: Port=%d, Last State=%d, Curr State=%d\n", port->actor_port_number, last_state, port->sm_periodic_state); 1280 1282 switch (port->sm_periodic_state) { 1281 1283 case AD_NO_PERIODIC: 1282 1284 port->sm_periodic_timer_counter = 0; // zero timer ··· 1333 1335 port->next_port_in_aggregator=NULL; 1334 1336 port->actor_port_aggregator_identifier=0; 1335 1337 1336 - dprintk("Port %d left LAG %d\n", port->actor_port_number, temp_aggregator->aggregator_identifier); 1338 + pr_debug("Port %d left LAG %d\n", port->actor_port_number, temp_aggregator->aggregator_identifier); 1337 1339 // if the aggregator is empty, clear its parameters, and set it ready to be attached 1338 1340 if (!temp_aggregator->lag_ports) { 1339 1341 ad_clear_agg(temp_aggregator); ··· 1376 1378 port->next_port_in_aggregator=aggregator->lag_ports; 1377 1379 port->aggregator->num_of_ports++; 1378 1380 aggregator->lag_ports=port; 1379 - dprintk("Port %d joined LAG %d(existing LAG)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1381 + pr_debug("Port %d joined LAG %d(existing LAG)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1380 1382 1381 1383 // mark this port as selected 1382 1384 port->sm_vars |= AD_PORT_SELECTED; ··· 1413 1415 // mark this port as selected 1414 1416 port->sm_vars |= AD_PORT_SELECTED; 1415 1417 1416 - dprintk("Port %d joined LAG %d(new LAG)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1418 + pr_debug("Port %d joined LAG %d(new LAG)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1417 1419 } else { 1418 1420 printk(KERN_ERR DRV_NAME ": %s: Port %d (on %s) did not find a suitable aggregator\n", 1419 1421 port->slave->dev->master->name, ··· 1572 1574 1573 1575 // if there is new best aggregator, activate it 1574 1576 if (best) { 1575 - dprintk("best Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1577 + pr_debug("best Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1576 1578 best->aggregator_identifier, best->num_of_ports, 1577 1579 best->actor_oper_aggregator_key, 1578 1580 best->partner_oper_aggregator_key, 1579 1581 best->is_individual, best->is_active); 1580 - dprintk("best ports %p slave %p %s\n", 1582 + pr_debug("best ports %p slave %p %s\n", 1581 1583 best->lag_ports, best->slave, 1582 1584 best->slave ? best->slave->dev->name : "NULL"); 1583 1585 1584 1586 for (agg = __get_first_agg(best->lag_ports); agg; 1585 1587 agg = __get_next_agg(agg)) { 1586 1588 1587 - dprintk("Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1589 + pr_debug("Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1588 1590 agg->aggregator_identifier, agg->num_of_ports, 1589 1591 agg->actor_oper_aggregator_key, 1590 1592 agg->partner_oper_aggregator_key, ··· 1600 1602 } 1601 1603 1602 1604 best->is_active = 1; 1603 - dprintk("LAG %d chosen as the active LAG\n", 1605 + pr_debug("LAG %d chosen as the active LAG\n", 1604 1606 best->aggregator_identifier); 1605 - dprintk("Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1607 + pr_debug("Agg=%d; P=%d; a k=%d; p k=%d; Ind=%d; Act=%d\n", 1606 1608 best->aggregator_identifier, best->num_of_ports, 1607 1609 best->actor_oper_aggregator_key, 1608 1610 best->partner_oper_aggregator_key, ··· 1660 1662 aggregator->lag_ports = NULL; 1661 1663 aggregator->is_active = 0; 1662 1664 aggregator->num_of_ports = 0; 1663 - dprintk("LAG %d was cleared\n", aggregator->aggregator_identifier); 1665 + pr_debug("LAG %d was cleared\n", aggregator->aggregator_identifier); 1664 1666 } 1665 1667 } 1666 1668 ··· 1745 1747 static void ad_enable_collecting_distributing(struct port *port) 1746 1748 { 1747 1749 if (port->aggregator->is_active) { 1748 - dprintk("Enabling port %d(LAG %d)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1750 + pr_debug("Enabling port %d(LAG %d)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1749 1751 __enable_port(port); 1750 1752 } 1751 1753 } ··· 1758 1760 static void ad_disable_collecting_distributing(struct port *port) 1759 1761 { 1760 1762 if (port->aggregator && MAC_ADDRESS_COMPARE(&(port->aggregator->partner_system), &(null_mac_addr))) { 1761 - dprintk("Disabling port %d(LAG %d)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1763 + pr_debug("Disabling port %d(LAG %d)\n", port->actor_port_number, port->aggregator->aggregator_identifier); 1762 1764 __disable_port(port); 1763 1765 } 1764 1766 } ··· 1796 1798 1797 1799 // send the marker information 1798 1800 if (ad_marker_send(port, &marker) >= 0) { 1799 - dprintk("Sent Marker Information on port %d\n", port->actor_port_number); 1801 + pr_debug("Sent Marker Information on port %d\n", port->actor_port_number); 1800 1802 } 1801 1803 } 1802 1804 #endif ··· 1820 1822 // send the marker response 1821 1823 1822 1824 if (ad_marker_send(port, &marker) >= 0) { 1823 - dprintk("Sent Marker Response on port %d\n", port->actor_port_number); 1825 + pr_debug("Sent Marker Response on port %d\n", port->actor_port_number); 1824 1826 } 1825 1827 } 1826 1828 ··· 2034 2036 return; 2035 2037 } 2036 2038 2037 - dprintk("Unbinding Link Aggregation Group %d\n", aggregator->aggregator_identifier); 2039 + pr_debug("Unbinding Link Aggregation Group %d\n", aggregator->aggregator_identifier); 2038 2040 2039 2041 /* Tell the partner that this port is not suitable for aggregation */ 2040 2042 port->actor_oper_port_state &= ~AD_STATE_AGGREGATION; ··· 2058 2060 // if new aggregator found, copy the aggregator's parameters 2059 2061 // and connect the related lag_ports to the new aggregator 2060 2062 if ((new_aggregator) && ((!new_aggregator->lag_ports) || ((new_aggregator->lag_ports == port) && !new_aggregator->lag_ports->next_port_in_aggregator))) { 2061 - dprintk("Some port(s) related to LAG %d - replaceing with LAG %d\n", aggregator->aggregator_identifier, new_aggregator->aggregator_identifier); 2063 + pr_debug("Some port(s) related to LAG %d - replaceing with LAG %d\n", aggregator->aggregator_identifier, new_aggregator->aggregator_identifier); 2062 2064 2063 2065 if ((new_aggregator->lag_ports == port) && new_aggregator->is_active) { 2064 2066 printk(KERN_INFO DRV_NAME ": %s: Removing an active aggregator\n", ··· 2109 2111 } 2110 2112 } 2111 2113 2112 - dprintk("Unbinding port %d\n", port->actor_port_number); 2114 + pr_debug("Unbinding port %d\n", port->actor_port_number); 2113 2115 // find the aggregator that this port is connected to 2114 2116 temp_aggregator = __get_first_agg(port); 2115 2117 for (; temp_aggregator; temp_aggregator = __get_next_agg(temp_aggregator)) { ··· 2240 2242 2241 2243 switch (lacpdu->subtype) { 2242 2244 case AD_TYPE_LACPDU: 2243 - dprintk("Received LACPDU on port %d\n", port->actor_port_number); 2245 + pr_debug("Received LACPDU on port %d\n", port->actor_port_number); 2244 2246 ad_rx_machine(lacpdu, port); 2245 2247 break; 2246 2248 ··· 2249 2251 2250 2252 switch (((struct bond_marker *)lacpdu)->tlv_type) { 2251 2253 case AD_MARKER_INFORMATION_SUBTYPE: 2252 - dprintk("Received Marker Information on port %d\n", port->actor_port_number); 2254 + pr_debug("Received Marker Information on port %d\n", port->actor_port_number); 2253 2255 ad_marker_info_received((struct bond_marker *)lacpdu, port); 2254 2256 break; 2255 2257 2256 2258 case AD_MARKER_RESPONSE_SUBTYPE: 2257 - dprintk("Received Marker Response on port %d\n", port->actor_port_number); 2259 + pr_debug("Received Marker Response on port %d\n", port->actor_port_number); 2258 2260 ad_marker_response_received((struct bond_marker *)lacpdu, port); 2259 2261 break; 2260 2262 2261 2263 default: 2262 - dprintk("Received an unknown Marker subtype on slot %d\n", port->actor_port_number); 2264 + pr_debug("Received an unknown Marker subtype on slot %d\n", port->actor_port_number); 2263 2265 } 2264 2266 } 2265 2267 } ··· 2287 2289 2288 2290 port->actor_admin_port_key &= ~AD_SPEED_KEY_BITS; 2289 2291 port->actor_oper_port_key=port->actor_admin_port_key |= (__get_link_speed(port) << 1); 2290 - dprintk("Port %d changed speed\n", port->actor_port_number); 2292 + pr_debug("Port %d changed speed\n", port->actor_port_number); 2291 2293 // there is no need to reselect a new aggregator, just signal the 2292 2294 // state machines to reinitialize 2293 2295 port->sm_vars |= AD_PORT_BEGIN; ··· 2315 2317 2316 2318 port->actor_admin_port_key &= ~AD_DUPLEX_KEY_BITS; 2317 2319 port->actor_oper_port_key=port->actor_admin_port_key |= __get_duplex(port); 2318 - dprintk("Port %d changed duplex\n", port->actor_port_number); 2320 + pr_debug("Port %d changed duplex\n", port->actor_port_number); 2319 2321 // there is no need to reselect a new aggregator, just signal the 2320 2322 // state machines to reinitialize 2321 2323 port->sm_vars |= AD_PORT_BEGIN;
+5 -7
drivers/net/bonding/bond_alb.c
··· 20 20 * 21 21 */ 22 22 23 - //#define BONDING_DEBUG 1 24 - 25 23 #include <linux/skbuff.h> 26 24 #include <linux/netdevice.h> 27 25 #include <linux/etherdevice.h> ··· 359 361 goto out; 360 362 361 363 if (!arp) { 362 - dprintk("Packet has no ARP data\n"); 364 + pr_debug("Packet has no ARP data\n"); 363 365 goto out; 364 366 } 365 367 366 368 if (skb->len < sizeof(struct arp_pkt)) { 367 - dprintk("Packet is too small to be an ARP\n"); 369 + pr_debug("Packet is too small to be an ARP\n"); 368 370 goto out; 369 371 } 370 372 ··· 374 376 bond_dev->name); 375 377 bond = netdev_priv(bond_dev); 376 378 rlb_update_entry_from_arp(bond, arp); 377 - dprintk("Server received an ARP Reply from client\n"); 379 + pr_debug("Server received an ARP Reply from client\n"); 378 380 } 379 381 380 382 res = NET_RX_SUCCESS; ··· 728 730 if (tx_slave) { 729 731 memcpy(arp->mac_src,tx_slave->dev->dev_addr, ETH_ALEN); 730 732 } 731 - dprintk("Server sent ARP Reply packet\n"); 733 + pr_debug("Server sent ARP Reply packet\n"); 732 734 } else if (arp->op_code == htons(ARPOP_REQUEST)) { 733 735 /* Create an entry in the rx_hashtbl for this client as a 734 736 * place holder. ··· 748 750 * updated with their assigned mac. 749 751 */ 750 752 rlb_req_update_subnet_clients(bond, arp->ip_src); 751 - dprintk("Server sent ARP Request packet\n"); 753 + pr_debug("Server sent ARP Request packet\n"); 752 754 } 753 755 754 756 return tx_slave;
+2 -4
drivers/net/bonding/bond_ipv6.c
··· 20 20 * 21 21 */ 22 22 23 - //#define BONDING_DEBUG 1 24 - 25 23 #include <linux/types.h> 26 24 #include <linux/if_vlan.h> 27 25 #include <net/ipv6.h> ··· 72 74 73 75 addrconf_addr_solict_mult(daddr, &mcaddr); 74 76 75 - dprintk("ipv6 na on slave %s: dest %pI6, src %pI6\n", 77 + pr_debug("ipv6 na on slave %s: dest %pI6, src %pI6\n", 76 78 slave_dev->name, &mcaddr, daddr); 77 79 78 80 skb = ndisc_build_skb(slave_dev, &mcaddr, daddr, &icmp6h, daddr, ··· 108 110 struct inet6_dev *idev; 109 111 int is_router; 110 112 111 - dprintk("bond_send_unsol_na: bond %s slave %s\n", bond->dev->name, 113 + pr_debug("bond_send_unsol_na: bond %s slave %s\n", bond->dev->name, 112 114 slave ? slave->dev->name : "NULL"); 113 115 114 116 if (!slave || !bond->send_unsol_na ||
+45 -47
drivers/net/bonding/bond_main.c
··· 31 31 * 32 32 */ 33 33 34 - //#define BONDING_DEBUG 1 35 - 36 34 #include <linux/kernel.h> 37 35 #include <linux/module.h> 38 36 #include <linux/types.h> ··· 246 248 { 247 249 struct vlan_entry *vlan; 248 250 249 - dprintk("bond: %s, vlan id %d\n", 251 + pr_debug("bond: %s, vlan id %d\n", 250 252 (bond ? bond->dev->name: "None"), vlan_id); 251 253 252 254 vlan = kzalloc(sizeof(struct vlan_entry), GFP_KERNEL); ··· 263 265 264 266 write_unlock_bh(&bond->lock); 265 267 266 - dprintk("added VLAN ID %d on bond %s\n", vlan_id, bond->dev->name); 268 + pr_debug("added VLAN ID %d on bond %s\n", vlan_id, bond->dev->name); 267 269 268 270 return 0; 269 271 } ··· 280 282 struct vlan_entry *vlan; 281 283 int res = -ENODEV; 282 284 283 - dprintk("bond: %s, vlan id %d\n", bond->dev->name, vlan_id); 285 + pr_debug("bond: %s, vlan id %d\n", bond->dev->name, vlan_id); 284 286 285 287 write_lock_bh(&bond->lock); 286 288 ··· 291 293 if (bond_is_lb(bond)) 292 294 bond_alb_clear_vlan(bond, vlan_id); 293 295 294 - dprintk("removed VLAN ID %d from bond %s\n", vlan_id, 296 + pr_debug("removed VLAN ID %d from bond %s\n", vlan_id, 295 297 bond->dev->name); 296 298 297 299 kfree(vlan); ··· 311 313 } 312 314 } 313 315 314 - dprintk("couldn't find VLAN ID %d in bond %s\n", vlan_id, 316 + pr_debug("couldn't find VLAN ID %d in bond %s\n", vlan_id, 315 317 bond->dev->name); 316 318 317 319 out: ··· 335 337 336 338 bond_for_each_slave(bond, slave, i) { 337 339 if (slave->dev->features & NETIF_F_VLAN_CHALLENGED) { 338 - dprintk("found VLAN challenged slave - %s\n", 340 + pr_debug("found VLAN challenged slave - %s\n", 339 341 slave->dev->name); 340 342 return 1; 341 343 } 342 344 } 343 345 344 - dprintk("no VLAN challenged slaves found\n"); 346 + pr_debug("no VLAN challenged slaves found\n"); 345 347 return 0; 346 348 } 347 349 ··· 1317 1319 static int bond_sethwaddr(struct net_device *bond_dev, 1318 1320 struct net_device *slave_dev) 1319 1321 { 1320 - dprintk("bond_dev=%p\n", bond_dev); 1321 - dprintk("slave_dev=%p\n", slave_dev); 1322 - dprintk("slave_dev->addr_len=%d\n", slave_dev->addr_len); 1322 + pr_debug("bond_dev=%p\n", bond_dev); 1323 + pr_debug("slave_dev=%p\n", slave_dev); 1324 + pr_debug("slave_dev->addr_len=%d\n", slave_dev->addr_len); 1323 1325 memcpy(bond_dev->dev_addr, slave_dev->dev_addr, slave_dev->addr_len); 1324 1326 return 0; 1325 1327 } ··· 1410 1412 1411 1413 /* already enslaved */ 1412 1414 if (slave_dev->flags & IFF_SLAVE) { 1413 - dprintk("Error, Device was already enslaved\n"); 1415 + pr_debug("Error, Device was already enslaved\n"); 1414 1416 return -EBUSY; 1415 1417 } 1416 1418 1417 1419 /* vlan challenged mutual exclusion */ 1418 1420 /* no need to lock since we're protected by rtnl_lock */ 1419 1421 if (slave_dev->features & NETIF_F_VLAN_CHALLENGED) { 1420 - dprintk("%s: NETIF_F_VLAN_CHALLENGED\n", slave_dev->name); 1422 + pr_debug("%s: NETIF_F_VLAN_CHALLENGED\n", slave_dev->name); 1421 1423 if (!list_empty(&bond->vlan_list)) { 1422 1424 printk(KERN_ERR DRV_NAME 1423 1425 ": %s: Error: cannot enslave VLAN " ··· 1435 1437 bond_dev->features |= NETIF_F_VLAN_CHALLENGED; 1436 1438 } 1437 1439 } else { 1438 - dprintk("%s: ! NETIF_F_VLAN_CHALLENGED\n", slave_dev->name); 1440 + pr_debug("%s: ! NETIF_F_VLAN_CHALLENGED\n", slave_dev->name); 1439 1441 if (bond->slave_cnt == 0) { 1440 1442 /* First slave, and it is not VLAN challenged, 1441 1443 * so remove the block of adding VLANs over the bond. ··· 1523 1525 addr.sa_family = slave_dev->type; 1524 1526 res = dev_set_mac_address(slave_dev, &addr); 1525 1527 if (res) { 1526 - dprintk("Error %d calling set_mac_address\n", res); 1528 + pr_debug("Error %d calling set_mac_address\n", res); 1527 1529 goto err_free; 1528 1530 } 1529 1531 } 1530 1532 1531 1533 res = netdev_set_master(slave_dev, bond_dev); 1532 1534 if (res) { 1533 - dprintk("Error %d calling netdev_set_master\n", res); 1535 + pr_debug("Error %d calling netdev_set_master\n", res); 1534 1536 goto err_restore_mac; 1535 1537 } 1536 1538 /* open the slave since the application closed it */ 1537 1539 res = dev_open(slave_dev); 1538 1540 if (res) { 1539 - dprintk("Openning slave %s failed\n", slave_dev->name); 1541 + pr_debug("Openning slave %s failed\n", slave_dev->name); 1540 1542 goto err_unset_master; 1541 1543 } 1542 1544 ··· 1641 1643 if (!bond->params.miimon || 1642 1644 (bond_check_dev_link(bond, slave_dev, 0) == BMSR_LSTATUS)) { 1643 1645 if (bond->params.updelay) { 1644 - dprintk("Initial state of slave_dev is " 1646 + pr_debug("Initial state of slave_dev is " 1645 1647 "BOND_LINK_BACK\n"); 1646 1648 new_slave->link = BOND_LINK_BACK; 1647 1649 new_slave->delay = bond->params.updelay; 1648 1650 } else { 1649 - dprintk("Initial state of slave_dev is " 1651 + pr_debug("Initial state of slave_dev is " 1650 1652 "BOND_LINK_UP\n"); 1651 1653 new_slave->link = BOND_LINK_UP; 1652 1654 } 1653 1655 new_slave->jiffies = jiffies; 1654 1656 } else { 1655 - dprintk("Initial state of slave_dev is " 1657 + pr_debug("Initial state of slave_dev is " 1656 1658 "BOND_LINK_DOWN\n"); 1657 1659 new_slave->link = BOND_LINK_DOWN; 1658 1660 } ··· 1713 1715 bond_set_slave_inactive_flags(new_slave); 1714 1716 break; 1715 1717 default: 1716 - dprintk("This slave is always active in trunk mode\n"); 1718 + pr_debug("This slave is always active in trunk mode\n"); 1717 1719 1718 1720 /* always active in trunk mode */ 1719 1721 new_slave->state = BOND_STATE_ACTIVE; ··· 2534 2536 { 2535 2537 struct sk_buff *skb; 2536 2538 2537 - dprintk("arp %d on slave %s: dst %x src %x vid %d\n", arp_op, 2539 + pr_debug("arp %d on slave %s: dst %x src %x vid %d\n", arp_op, 2538 2540 slave_dev->name, dest_ip, src_ip, vlan_id); 2539 2541 2540 2542 skb = arp_create(arp_op, ETH_P_ARP, dest_ip, slave_dev, src_ip, ··· 2567 2569 for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) { 2568 2570 if (!targets[i]) 2569 2571 continue; 2570 - dprintk("basa: target %x\n", targets[i]); 2572 + pr_debug("basa: target %x\n", targets[i]); 2571 2573 if (list_empty(&bond->vlan_list)) { 2572 - dprintk("basa: empty vlan: arp_send\n"); 2574 + pr_debug("basa: empty vlan: arp_send\n"); 2573 2575 bond_arp_send(slave->dev, ARPOP_REQUEST, targets[i], 2574 2576 bond->master_ip, 0); 2575 2577 continue; ··· 2599 2601 */ 2600 2602 if (rt->u.dst.dev == bond->dev) { 2601 2603 ip_rt_put(rt); 2602 - dprintk("basa: rtdev == bond->dev: arp_send\n"); 2604 + pr_debug("basa: rtdev == bond->dev: arp_send\n"); 2603 2605 bond_arp_send(slave->dev, ARPOP_REQUEST, targets[i], 2604 2606 bond->master_ip, 0); 2605 2607 continue; ··· 2610 2612 vlan_dev = vlan_group_get_device(bond->vlgrp, vlan->vlan_id); 2611 2613 if (vlan_dev == rt->u.dst.dev) { 2612 2614 vlan_id = vlan->vlan_id; 2613 - dprintk("basa: vlan match on %s %d\n", 2615 + pr_debug("basa: vlan match on %s %d\n", 2614 2616 vlan_dev->name, vlan_id); 2615 2617 break; 2616 2618 } ··· 2645 2647 struct vlan_entry *vlan; 2646 2648 struct net_device *vlan_dev; 2647 2649 2648 - dprintk("bond_send_grat_arp: bond %s slave %s\n", bond->dev->name, 2650 + pr_debug("bond_send_grat_arp: bond %s slave %s\n", bond->dev->name, 2649 2651 slave ? slave->dev->name : "NULL"); 2650 2652 2651 2653 if (!slave || !bond->send_grat_arp || ··· 2675 2677 2676 2678 targets = bond->params.arp_targets; 2677 2679 for (i = 0; (i < BOND_MAX_ARP_TARGETS) && targets[i]; i++) { 2678 - dprintk("bva: sip %pI4 tip %pI4 t[%d] %pI4 bhti(tip) %d\n", 2680 + pr_debug("bva: sip %pI4 tip %pI4 t[%d] %pI4 bhti(tip) %d\n", 2679 2681 &sip, &tip, i, &targets[i], bond_has_this_ip(bond, tip)); 2680 2682 if (sip == targets[i]) { 2681 2683 if (bond_has_this_ip(bond, tip)) ··· 2702 2704 bond = netdev_priv(dev); 2703 2705 read_lock(&bond->lock); 2704 2706 2705 - dprintk("bond_arp_rcv: bond %s skb->dev %s orig_dev %s\n", 2707 + pr_debug("bond_arp_rcv: bond %s skb->dev %s orig_dev %s\n", 2706 2708 bond->dev->name, skb->dev ? skb->dev->name : "NULL", 2707 2709 orig_dev ? orig_dev->name : "NULL"); 2708 2710 ··· 2728 2730 arp_ptr += 4 + dev->addr_len; 2729 2731 memcpy(&tip, arp_ptr, 4); 2730 2732 2731 - dprintk("bond_arp_rcv: %s %s/%d av %d sv %d sip %pI4 tip %pI4\n", 2733 + pr_debug("bond_arp_rcv: %s %s/%d av %d sv %d sip %pI4 tip %pI4\n", 2732 2734 bond->dev->name, slave->dev->name, slave->state, 2733 2735 bond->params.arp_validate, slave_do_arp_validate(bond, slave), 2734 2736 &sip, &tip); ··· 3593 3595 if (dev_net(event_dev) != &init_net) 3594 3596 return NOTIFY_DONE; 3595 3597 3596 - dprintk("event_dev: %s, event: %lx\n", 3598 + pr_debug("event_dev: %s, event: %lx\n", 3597 3599 (event_dev ? event_dev->name : "None"), 3598 3600 event); 3599 3601 ··· 3601 3603 return NOTIFY_DONE; 3602 3604 3603 3605 if (event_dev->flags & IFF_MASTER) { 3604 - dprintk("IFF_MASTER\n"); 3606 + pr_debug("IFF_MASTER\n"); 3605 3607 return bond_master_netdev_event(event, event_dev); 3606 3608 } 3607 3609 3608 3610 if (event_dev->flags & IFF_SLAVE) { 3609 - dprintk("IFF_SLAVE\n"); 3611 + pr_debug("IFF_SLAVE\n"); 3610 3612 return bond_slave_netdev_event(event, event_dev); 3611 3613 } 3612 3614 ··· 3935 3937 struct mii_ioctl_data *mii = NULL; 3936 3938 int res = 0; 3937 3939 3938 - dprintk("bond_ioctl: master=%s, cmd=%d\n", 3940 + pr_debug("bond_ioctl: master=%s, cmd=%d\n", 3939 3941 bond_dev->name, cmd); 3940 3942 3941 3943 switch (cmd) { ··· 4013 4015 down_write(&(bonding_rwsem)); 4014 4016 slave_dev = dev_get_by_name(&init_net, ifr->ifr_slave); 4015 4017 4016 - dprintk("slave_dev=%p: \n", slave_dev); 4018 + pr_debug("slave_dev=%p: \n", slave_dev); 4017 4019 4018 4020 if (!slave_dev) { 4019 4021 res = -ENODEV; 4020 4022 } else { 4021 - dprintk("slave_dev->name=%s: \n", slave_dev->name); 4023 + pr_debug("slave_dev->name=%s: \n", slave_dev->name); 4022 4024 switch (cmd) { 4023 4025 case BOND_ENSLAVE_OLD: 4024 4026 case SIOCBONDENSLAVE: ··· 4129 4131 int res = 0; 4130 4132 int i; 4131 4133 4132 - dprintk("bond=%p, name=%s, new_mtu=%d\n", bond, 4134 + pr_debug("bond=%p, name=%s, new_mtu=%d\n", bond, 4133 4135 (bond_dev ? bond_dev->name : "None"), new_mtu); 4134 4136 4135 4137 /* Can't hold bond->lock with bh disabled here since ··· 4148 4150 */ 4149 4151 4150 4152 bond_for_each_slave(bond, slave, i) { 4151 - dprintk("s %p s->p %p c_m %p\n", slave, 4153 + pr_debug("s %p s->p %p c_m %p\n", slave, 4152 4154 slave->prev, slave->dev->change_mtu); 4153 4155 4154 4156 res = dev_set_mtu(slave->dev, new_mtu); ··· 4162 4164 * means changing their mtu from timer context, which 4163 4165 * is probably not a good idea. 4164 4166 */ 4165 - dprintk("err %d %s\n", res, slave->dev->name); 4167 + pr_debug("err %d %s\n", res, slave->dev->name); 4166 4168 goto unwind; 4167 4169 } 4168 4170 } ··· 4179 4181 4180 4182 tmp_res = dev_set_mtu(slave->dev, bond_dev->mtu); 4181 4183 if (tmp_res) { 4182 - dprintk("unwind err %d dev %s\n", tmp_res, 4184 + pr_debug("unwind err %d dev %s\n", tmp_res, 4183 4185 slave->dev->name); 4184 4186 } 4185 4187 } ··· 4206 4208 return bond_alb_set_mac_address(bond_dev, addr); 4207 4209 4208 4210 4209 - dprintk("bond=%p, name=%s\n", bond, (bond_dev ? bond_dev->name : "None")); 4211 + pr_debug("bond=%p, name=%s\n", bond, (bond_dev ? bond_dev->name : "None")); 4210 4212 4211 4213 /* 4212 4214 * If fail_over_mac is set to active, do nothing and return ··· 4236 4238 4237 4239 bond_for_each_slave(bond, slave, i) { 4238 4240 const struct net_device_ops *slave_ops = slave->dev->netdev_ops; 4239 - dprintk("slave %p %s\n", slave, slave->dev->name); 4241 + pr_debug("slave %p %s\n", slave, slave->dev->name); 4240 4242 4241 4243 if (slave_ops->ndo_set_mac_address == NULL) { 4242 4244 res = -EOPNOTSUPP; 4243 - dprintk("EOPNOTSUPP %s\n", slave->dev->name); 4245 + pr_debug("EOPNOTSUPP %s\n", slave->dev->name); 4244 4246 goto unwind; 4245 4247 } 4246 4248 ··· 4252 4254 * breakage anyway until ARP finish 4253 4255 * updating, so... 4254 4256 */ 4255 - dprintk("err %d %s\n", res, slave->dev->name); 4257 + pr_debug("err %d %s\n", res, slave->dev->name); 4256 4258 goto unwind; 4257 4259 } 4258 4260 } ··· 4272 4274 4273 4275 tmp_res = dev_set_mac_address(slave->dev, &tmp_sa); 4274 4276 if (tmp_res) { 4275 - dprintk("unwind err %d dev %s\n", tmp_res, 4277 + pr_debug("unwind err %d dev %s\n", tmp_res, 4276 4278 slave->dev->name); 4277 4279 } 4278 4280 } ··· 4591 4593 { 4592 4594 struct bonding *bond = netdev_priv(bond_dev); 4593 4595 4594 - dprintk("Begin bond_init for %s\n", bond_dev->name); 4596 + pr_debug("Begin bond_init for %s\n", bond_dev->name); 4595 4597 4596 4598 /* initialize rwlocks */ 4597 4599 rwlock_init(&bond->lock);
+1 -1
drivers/net/bonding/bond_sysfs.c
··· 36 36 #include <linux/rtnetlink.h> 37 37 #include <net/net_namespace.h> 38 38 39 - /* #define BONDING_DEBUG 1 */ 40 39 #include "bonding.h" 40 + 41 41 #define to_dev(obj) container_of(obj,struct device,kobj) 42 42 #define to_bond(cd) ((struct bonding *)(netdev_priv(to_net_dev(cd)))) 43 43
-8
drivers/net/bonding/bonding.h
··· 32 32 33 33 extern struct list_head bond_dev_list; 34 34 35 - #ifdef BONDING_DEBUG 36 - #define dprintk(fmt, args...) \ 37 - printk(KERN_DEBUG \ 38 - DRV_NAME ": %s() %d: " fmt, __func__, __LINE__ , ## args ) 39 - #else 40 - #define dprintk(fmt, args...) 41 - #endif /* BONDING_DEBUG */ 42 - 43 35 #define IS_UP(dev) \ 44 36 ((((dev)->flags & IFF_UP) == IFF_UP) && \ 45 37 netif_running(dev) && \