Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ext2: cache NULL when both default_acl and acl are NULL

default_acl and acl of newly created inode will be initiated as
ACL_NOT_CACHED in vfs function inode_init_always() and later will be
updated by calling xxx_init_acl() in specific filesystems. However,
when default_acl and acl are NULL, then they keep the value of
ACL_NOT_CACHED. This patch changes the code to cache NULL for acl /
default_acl in this case to save unnecessary ACL lookup in future.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jan Kara <jack@suse.cz>

authored by

Chengguang Xu and committed by
Jan Kara
59fed3bf 849fe89c

+4
+4
fs/ext2/acl.c
··· 256 256 if (default_acl) { 257 257 error = __ext2_set_acl(inode, default_acl, ACL_TYPE_DEFAULT); 258 258 posix_acl_release(default_acl); 259 + } else { 260 + inode->i_default_acl = NULL; 259 261 } 260 262 if (acl) { 261 263 if (!error) 262 264 error = __ext2_set_acl(inode, acl, ACL_TYPE_ACCESS); 263 265 posix_acl_release(acl); 266 + } else { 267 + inode->i_acl = NULL; 264 268 } 265 269 return error; 266 270 }