tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

wifi: cfg80211: use strscpy to replace strlcpy

The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: XueBing Chen <chenxuebing@jari.cn>
Link: https://lore.kernel.org/r/2d2fcbf7.e33.181eda8e70e.Coremail.chenxuebing@jari.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

authored by

XueBing Chen and committed by
Johannes Berg 59e8ef18 51d3cfaf

+6 -6
+6 -6
net/wireless/ethtool.c
··· 10 10 struct device *pdev = wiphy_dev(wdev->wiphy); 11 11 12 12 if (pdev->driver) 13 - strlcpy(info->driver, pdev->driver->name, 13 + strscpy(info->driver, pdev->driver->name, 14 14 sizeof(info->driver)); 15 15 else 16 - strlcpy(info->driver, "N/A", sizeof(info->driver)); 16 + strscpy(info->driver, "N/A", sizeof(info->driver)); 17 17 18 - strlcpy(info->version, init_utsname()->release, sizeof(info->version)); 18 + strscpy(info->version, init_utsname()->release, sizeof(info->version)); 19 19 20 20 if (wdev->wiphy->fw_version[0]) 21 - strlcpy(info->fw_version, wdev->wiphy->fw_version, 21 + strscpy(info->fw_version, wdev->wiphy->fw_version, 22 22 sizeof(info->fw_version)); 23 23 else 24 - strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); 24 + strscpy(info->fw_version, "N/A", sizeof(info->fw_version)); 25 25 26 - strlcpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)), 26 + strscpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)), 27 27 sizeof(info->bus_info)); 28 28 } 29 29 EXPORT_SYMBOL(cfg80211_get_drvinfo);