Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

matroxfb: fix size of memcpy

hw->DACreg has a size of 80 bytes and MGADACbpp32 has 21. So when
memcpy copies MGADACbpp32 to hw->DACreg it copies 80 bytes but
only 21 bytes are valid.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

authored by

Sudip Mukherjee and committed by
Tomi Valkeinen
59921b23 d8ed9e87

+1 -1
+1 -1
drivers/video/fbdev/matrox/matroxfb_Ti3026.c
··· 372 372 373 373 DBG(__func__) 374 374 375 - memcpy(hw->DACreg, MGADACbpp32, sizeof(hw->DACreg)); 375 + memcpy(hw->DACreg, MGADACbpp32, sizeof(MGADACbpp32)); 376 376 switch (minfo->fbcon.var.bits_per_pixel) { 377 377 case 4: hw->DACreg[POS3026_XLATCHCTRL] = TVP3026_XLATCHCTRL_16_1; /* or _8_1, they are same */ 378 378 hw->DACreg[POS3026_XTRUECOLORCTRL] = TVP3026_XTRUECOLORCTRL_PSEUDOCOLOR;