Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: dvb-frontends: rtl2832: Stop direct calls to queue num_buffers field

Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
This allows us to change how the number of buffers is computed in the
future.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
CC: Antti Palosaari <crope@iki.fi>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

authored by

Benjamin Gaignard and committed by
Mauro Carvalho Chehab
595f445b b3b5d2e2

+3 -2
+3 -2
drivers/media/dvb-frontends/rtl2832_sdr.c
··· 439 439 { 440 440 struct rtl2832_sdr_dev *dev = vb2_get_drv_priv(vq); 441 441 struct platform_device *pdev = dev->pdev; 442 + unsigned int q_num_bufs = vb2_get_num_buffers(vq); 442 443 443 444 dev_dbg(&pdev->dev, "nbuffers=%d\n", *nbuffers); 444 445 445 446 /* Need at least 8 buffers */ 446 - if (vq->num_buffers + *nbuffers < 8) 447 - *nbuffers = 8 - vq->num_buffers; 447 + if (q_num_bufs + *nbuffers < 8) 448 + *nbuffers = 8 - q_num_bufs; 448 449 *nplanes = 1; 449 450 sizes[0] = PAGE_ALIGN(dev->buffersize); 450 451 dev_dbg(&pdev->dev, "nbuffers=%d sizes[0]=%d\n", *nbuffers, sizes[0]);