Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: enetc: do not print error log if addr is 0

A value of 0 for addr indicates that the IEB_LBCR register does not
need to be configured, as its default value is 0. However, the driver
will print an error log if addr is 0, so this issue needs to be fixed.

Fixes: 50bfd9c06f0f ("net: enetc: set external PHY address in IERB for i.MX94 ENETC")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251222022628.4016403-1-wei.fang@nxp.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Wei Fang and committed by
Paolo Abeni
5939b6db 99537d5c

+7 -1
+7 -1
drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
··· 577 577 } 578 578 579 579 addr = netc_get_phy_addr(np); 580 - if (addr <= 0) { 580 + if (addr < 0) { 581 581 dev_err(dev, "Failed to get PHY address\n"); 582 582 return addr; 583 583 } 584 + 585 + /* The default value of LaBCR[MDIO_PHYAD_PRTAD] is 0, 586 + * so no need to set the register. 587 + */ 588 + if (!addr) 589 + return 0; 584 590 585 591 if (phy_mask & BIT(addr)) { 586 592 dev_err(dev,