Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: ab8500_fg: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
59016f4c c5b08e1b

+2 -4
+2 -4
drivers/power/supply/ab8500_fg.c
··· 3227 3227 return component_add(dev, &ab8500_fg_component_ops); 3228 3228 } 3229 3229 3230 - static int ab8500_fg_remove(struct platform_device *pdev) 3230 + static void ab8500_fg_remove(struct platform_device *pdev) 3231 3231 { 3232 3232 struct ab8500_fg *di = platform_get_drvdata(pdev); 3233 3233 ··· 3236 3236 list_del(&di->node); 3237 3237 ab8500_fg_sysfs_exit(di); 3238 3238 ab8500_fg_sysfs_psy_remove_attrs(di); 3239 - 3240 - return 0; 3241 3239 } 3242 3240 3243 3241 static SIMPLE_DEV_PM_OPS(ab8500_fg_pm_ops, ab8500_fg_suspend, ab8500_fg_resume); ··· 3248 3250 3249 3251 struct platform_driver ab8500_fg_driver = { 3250 3252 .probe = ab8500_fg_probe, 3251 - .remove = ab8500_fg_remove, 3253 + .remove_new = ab8500_fg_remove, 3252 3254 .driver = { 3253 3255 .name = "ab8500-fg", 3254 3256 .of_match_table = ab8500_fg_match,