Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: cdc-acm: fix break reporting

A recent change that started reporting break events forgot to push the
event to the line discipline, which meant that a detected break would
not be reported until further characters had been receive (the port
could even have been closed and reopened in between).

Fixes: 08dff274edda ("cdc-acm: fix BREAK rx code path adding necessary calls")
Cc: stable@vger.kernel.org
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210929090937.7410-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman
58fc1daa 65a205e6

+3
+3
drivers/usb/class/cdc-acm.c
··· 340 340 acm->iocount.overrun++; 341 341 spin_unlock_irqrestore(&acm->read_lock, flags); 342 342 343 + if (newctrl & ACM_CTRL_BRK) 344 + tty_flip_buffer_push(&acm->port); 345 + 343 346 if (difference) 344 347 wake_up_all(&acm->wioctl); 345 348