Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

igb: Avoid uninitialized advertised variable in eee_set_cur

eee_get_cur assumes that the output data is already zeroed. It can
read-modify-write the advertised field:

if (ipcnfg & E1000_IPCNFG_EEE_100M_AN)
2594 edata->advertised |= ADVERTISED_100baseT_Full;

This is ok for the normal ethtool eee_get call, which always
zeroes the input data before.

But eee_set_cur also calls eee_get_cur and it did not zero the input
field. Later on it then compares agsinst the field, which can contain partial
stack garbage.

Zero the input field in eee_set_cur() too.

Cc: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Andi Kleen and committed by
David S. Miller
58e4e1f6 52f77ba9

+2
+2
drivers/net/ethernet/intel/igb/igb_ethtool.c
··· 2655 2655 (hw->phy.media_type != e1000_media_type_copper)) 2656 2656 return -EOPNOTSUPP; 2657 2657 2658 + memset(&eee_curr, 0, sizeof(struct ethtool_eee)); 2659 + 2658 2660 ret_val = igb_get_eee(netdev, &eee_curr); 2659 2661 if (ret_val) 2660 2662 return ret_val;