Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: sc18is602: Remove sc18is602_setup() because it is done by spi core

The checking for spi->mode is done in the implementation of spi_setup().
Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
the code is equivent to checking if spi->max_speed_hz is 0.
Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
if t->speed_hz is set. So return error in sc18is602_setup() when
spi->max_speed_hz is 0 does not make sense.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@linaro.org>

authored by

Axel Lin and committed by
Mark Brown
589f6a90 38dbfb59

-9
-9
drivers/spi/spi-sc18is602.c
··· 245 245 return status; 246 246 } 247 247 248 - static int sc18is602_setup(struct spi_device *spi) 249 - { 250 - if (spi->mode & ~(SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST)) 251 - return -EINVAL; 252 - 253 - return sc18is602_check_transfer(spi, NULL, 0); 254 - } 255 - 256 248 static int sc18is602_probe(struct i2c_client *client, 257 249 const struct i2c_device_id *id) 258 250 { ··· 298 306 master->bus_num = client->adapter->nr; 299 307 master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST; 300 308 master->bits_per_word_mask = SPI_BPW_MASK(8); 301 - master->setup = sc18is602_setup; 302 309 master->transfer_one_message = sc18is602_transfer_one; 303 310 master->dev.of_node = np; 304 311