Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: vt6655: Remove unused code inside switch case

This patch removes dead code in private_ioctl function and
iwctl_siwmode function, in file ioctl.c.

Inside switch, for a case no code gets executed
after break.

This was detected by smatch.

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Tapasweni Pathak and committed by
Greg Kroah-Hartman
586e8b68 3f8ddea0

-49
-40
drivers/staging/vt6655/ioctl.c
··· 45 45 int result = 0; 46 46 PWLAN_IE_SSID pItemSSID; 47 47 SCmdBSSJoin sJoinCmd; 48 - SCmdZoneTypeSet sZoneTypeCmd; 49 48 SCmdScan sScanCmd; 50 49 SCmdStartAP sStartAPCmd; 51 50 SCmdSetWEP sWEPCmd; ··· 105 106 case WLAN_CMD_ZONETYPE_SET: 106 107 /* mike add :can't support. */ 107 108 result = -EOPNOTSUPP; 108 - break; 109 - 110 - if (copy_from_user(&sZoneTypeCmd, pReq->data, sizeof(SCmdZoneTypeSet))) { 111 - result = -EFAULT; 112 - break; 113 - } 114 - 115 - if (sZoneTypeCmd.bWrite == true) { 116 - /* write zonetype */ 117 - if (sZoneTypeCmd.ZoneType == ZoneType_USA) { 118 - /* set to USA */ 119 - pr_debug("set_ZoneType:USA\n"); 120 - } else if (sZoneTypeCmd.ZoneType == ZoneType_Japan) { 121 - /* set to Japan */ 122 - pr_debug("set_ZoneType:Japan\n"); 123 - } else if (sZoneTypeCmd.ZoneType == ZoneType_Europe) { 124 - /* set to Europe */ 125 - pr_debug("set_ZoneType:Europe\n"); 126 - } 127 - } else { 128 - /* read zonetype */ 129 - unsigned char zonetype = 0; 130 - 131 - if (zonetype == 0x00) { /* USA */ 132 - sZoneTypeCmd.ZoneType = ZoneType_USA; 133 - } else if (zonetype == 0x01) { /* Japan */ 134 - sZoneTypeCmd.ZoneType = ZoneType_Japan; 135 - } else if (zonetype == 0x02) { /* Europe */ 136 - sZoneTypeCmd.ZoneType = ZoneType_Europe; 137 - } else { /* Unknown ZoneType */ 138 - pr_err("Error:ZoneType[%x] Unknown ???\n", zonetype); 139 - result = -EFAULT; 140 - break; 141 - } 142 - if (copy_to_user(pReq->data, &sZoneTypeCmd, sizeof(SCmdZoneTypeSet))) { 143 - result = -EFAULT; 144 - break; 145 - } 146 - } 147 109 break; 148 110 149 111 case WLAN_CMD_BSS_JOIN:
-9
drivers/staging/vt6655/iwctl.c
··· 464 464 rc = -EOPNOTSUPP; 465 465 break; 466 466 467 - if (pMgmt->eConfigMode != WMAC_CONFIG_AP) { 468 - pMgmt->eConfigMode = WMAC_CONFIG_AP; 469 - if (pDevice->flags & DEVICE_FLAGS_OPENED) 470 - pDevice->bCommit = true; 471 - 472 - } 473 - pr_debug("set mode to Access Point\n"); 474 - break; 475 - 476 467 case IW_MODE_REPEAT: 477 468 pMgmt->eConfigMode = WMAC_CONFIG_ESS_STA; 478 469 rc = -EOPNOTSUPP;