Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amdgpu: ensure 0 is returned for success in jpeg_v2_5_wait_for_idle

In the cases where adev->jpeg.num_jpeg_inst is zero or the condition
adev->jpeg.harvest_config & (1 << i) is always non-zero the variable
ret is never set to an error condition and the function returns
an uninitialized value in ret. Since the only exit condition at
the end if the function is a success then explicitly return
0 rather than a potentially uninitialized value in ret.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 14f43e8f88c5 ("drm/amdgpu: move JPEG2.5 out from VCN2.5")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Colin Ian King and committed by
Alex Deucher
57f01856 6a8987a8

+1 -1
+1 -1
drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c
··· 462 462 return ret; 463 463 } 464 464 465 - return ret; 465 + return 0; 466 466 } 467 467 468 468 static int jpeg_v2_5_set_clockgating_state(void *handle,