Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: radio: si470x: Fix DRIVER_AUTHOR macro definition

The DRIVER_AUTHOR macro incorrectly included a semicolon in its
string literal definition. Right now, this wasn't causing any real
problem, but coming changes to the MODULE_INFO() macro make this more
sensitive. Specifically, when used with MODULE_AUTHOR(), this created
syntax errors during macro expansion:

MODULE_AUTHOR(DRIVER_AUTHOR);

expands to:

MODULE_INFO(author, "Joonyoung Shim <jy0922.shim@samsung.com>";)
^
syntax error

Remove the trailing semicolon from the DRIVER_AUTHOR definition.
Semicolons should only appear at the point of use, not in the macro
definition.

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Tested-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>

authored by

Kees Cook and committed by
Daniel Gomez
57e98537 9de2198a

+1 -1
+1 -1
drivers/media/radio/si470x/radio-si470x-i2c.c
··· 10 10 11 11 12 12 /* driver definitions */ 13 - #define DRIVER_AUTHOR "Joonyoung Shim <jy0922.shim@samsung.com>"; 13 + #define DRIVER_AUTHOR "Joonyoung Shim <jy0922.shim@samsung.com>" 14 14 #define DRIVER_CARD "Silicon Labs Si470x FM Radio" 15 15 #define DRIVER_DESC "I2C radio driver for Si470x FM Radio Receivers" 16 16 #define DRIVER_VERSION "1.0.2"