Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: sstfb: Updated logging to fix set but not used warnings

Fix set but not used warnings by introducing no_printk variants
for the internal logging system for this driver.

Fix a new warning that popped up now that logging was checked for
correct printf format strings.

A more invasive fix had been to replace all the internal logging with
standard logging primitives - thats for another day.

v2:
- Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-20-sam@ravnborg.org

+3 -3
+1 -1
drivers/video/fbdev/sstfb.c
··· 1390 1390 fix->smem_start, info->screen_base, 1391 1391 fix->smem_len >> 20); 1392 1392 1393 - f_ddprintk("regbase_virt: %#lx\n", par->mmio_vbase); 1393 + f_ddprintk("regbase_virt: %p\n", par->mmio_vbase); 1394 1394 f_ddprintk("membase_phys: %#lx\n", fix->smem_start); 1395 1395 f_ddprintk("fbbase_virt: %p\n", info->screen_base); 1396 1396
+2 -2
include/video/sstfb.h
··· 23 23 # define SST_DEBUG_FUNC 1 24 24 # define SST_DEBUG_VAR 1 25 25 #else 26 - # define dprintk(X...) 26 + # define dprintk(X...) no_printk(X) 27 27 # define SST_DEBUG_REG 0 28 28 # define SST_DEBUG_FUNC 0 29 29 # define SST_DEBUG_VAR 0 ··· 48 48 #if (SST_DEBUG_FUNC > 1) 49 49 # define f_ddprintk(X...) dprintk(" " X) 50 50 #else 51 - # define f_ddprintk(X...) 51 + # define f_ddprintk(X...) no_printk(X) 52 52 #endif 53 53 #if (SST_DEBUG_FUNC > 2) 54 54 # define f_dddprintk(X...) dprintk(" " X)