Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Use 'E' instead of 'X' for unsigned module taint flag.

Takashi Iwai <tiwai@suse.de> says:
> The letter 'X' has been already used for SUSE kernels for very long
> time, to indicate the external supported modules. Can the new flag be
> changed to another letter for avoiding conflict...?
> (BTW, we also use 'N' for "no support", too.)

Note: this code should be cleaned up, so we don't have such maps in
three places!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

+6 -6
+1 -1
Documentation/ABI/testing/sysfs-module
··· 49 49 O - out-of-tree module 50 50 F - force-loaded module 51 51 C - staging driver module 52 - X - unsigned module 52 + E - unsigned module
+1 -1
Documentation/module-signing.txt
··· 54 54 If this is off (ie. "permissive"), then modules for which the key is not 55 55 available and modules that are unsigned are permitted, but the kernel will 56 56 be marked as being tainted, and the concerned modules will be marked as 57 - tainted, shown with the character 'X'. 57 + tainted, shown with the character 'E'. 58 58 59 59 If this is on (ie. "restrictive"), only modules that have a valid 60 60 signature that can be verified by a public key in the kernel's possession
+1 -1
Documentation/oops-tracing.txt
··· 265 265 266 266 13: 'O' if an externally-built ("out-of-tree") module has been loaded. 267 267 268 - 14: 'X' if an unsigned module has been loaded in a kernel supporting 268 + 14: 'E' if an unsigned module has been loaded in a kernel supporting 269 269 module signature. 270 270 271 271 The primary reason for the 'Tainted: ' string is to tell kernel
+1 -1
kernel/module.c
··· 1014 1014 if (mod->taints & (1 << TAINT_CRAP)) 1015 1015 buf[l++] = 'C'; 1016 1016 if (mod->taints & (1 << TAINT_UNSIGNED_MODULE)) 1017 - buf[l++] = 'X'; 1017 + buf[l++] = 'E'; 1018 1018 /* 1019 1019 * TAINT_FORCED_RMMOD: could be added. 1020 1020 * TAINT_UNSAFE_SMP, TAINT_MACHINE_CHECK, TAINT_BAD_PAGE don't
+2 -2
kernel/panic.c
··· 210 210 { TAINT_CRAP, 'C', ' ' }, 211 211 { TAINT_FIRMWARE_WORKAROUND, 'I', ' ' }, 212 212 { TAINT_OOT_MODULE, 'O', ' ' }, 213 - { TAINT_UNSIGNED_MODULE, 'X', ' ' }, 213 + { TAINT_UNSIGNED_MODULE, 'E', ' ' }, 214 214 }; 215 215 216 216 /** ··· 229 229 * 'C' - modules from drivers/staging are loaded. 230 230 * 'I' - Working around severe firmware bug. 231 231 * 'O' - Out-of-tree module has been loaded. 232 - * 'X' - Unsigned module has been loaded. 232 + * 'E' - Unsigned module has been loaded. 233 233 * 234 234 * The string is overwritten by the next call to print_tainted(). 235 235 */