Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: pinctrl: mcp23s08: Clarify gpiospec flags cell usage

The pinctrl-mcp23s08 driver doesn't provide a specific gpiospec
of_xlate() function, causing the gpiolib-of's of_gpio_simple_xlate()
function to be used instead, which takes the gpiospec's second cell as
the flags specifier according to 'include/dt-bindings/gpio/gpio.h'.

The pinctrl-mcp23s08 bindings document was mentioning that the flags
were unused, which is not accurate because values in that second cell
are indeed used by the gpiolib-of's of_gpio_simple_xlate() for
configuring the gpio (e.g. its polarity).

This way, replace the "flags currently unused" reference in the
dt-bindings document with references to the appropriate files specifying
the possible flag values and gpiospec description.

CC: devicetree@vger.kernel.org
Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Ricardo Silva and committed by
Linus Walleij
574e6995 e61941d1

+3 -1
+3 -1
Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
··· 18 18 removed. 19 19 - #gpio-cells : Should be two. 20 20 - first cell is the pin number 21 - - second cell is used to specify flags. Flags are currently unused. 21 + - second cell is used to specify flags as described in 22 + 'Documentation/devicetree/bindings/gpio/gpio.txt'. Allowed values defined by 23 + 'include/dt-bindings/gpio/gpio.h' (e.g. GPIO_ACTIVE_LOW). 22 24 - gpio-controller : Marks the device node as a GPIO controller. 23 25 - reg : For an address on its bus. I2C uses this a the I2C address of the chip. 24 26 SPI uses this to specify the chipselect line which the chip is