Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

zero i_uid/i_gid on inode allocation

... and don't bother in callers. Don't bother with zeroing i_blocks,
while we are at it - it's already been zeroed.

i_mode is not worth the effort; it has no common default value.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 56ff5efa acfa4380

+2 -66
-1
arch/powerpc/platforms/cell/spufs/inode.c
··· 97 97 inode->i_mode = mode; 98 98 inode->i_uid = current_fsuid(); 99 99 inode->i_gid = current_fsgid(); 100 - inode->i_blocks = 0; 101 100 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 102 101 out: 103 102 return inode;
-1
arch/s390/hypfs/inode.c
··· 106 106 ret->i_mode = mode; 107 107 ret->i_uid = hypfs_info->uid; 108 108 ret->i_gid = hypfs_info->gid; 109 - ret->i_blocks = 0; 110 109 ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME; 111 110 if (mode & S_IFDIR) 112 111 ret->i_nlink = 2;
-3
drivers/infiniband/hw/ipath/ipath_fs.c
··· 57 57 } 58 58 59 59 inode->i_mode = mode; 60 - inode->i_uid = 0; 61 - inode->i_gid = 0; 62 - inode->i_blocks = 0; 63 60 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 64 61 inode->i_private = data; 65 62 if ((mode & S_IFMT) == S_IFDIR) {
-2
drivers/isdn/capi/capifs.c
··· 111 111 goto fail; 112 112 inode->i_ino = 1; 113 113 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 114 - inode->i_blocks = 0; 115 - inode->i_uid = inode->i_gid = 0; 116 114 inode->i_mode = S_IFDIR | S_IRUGO | S_IXUGO | S_IWUSR; 117 115 inode->i_op = &simple_dir_inode_operations; 118 116 inode->i_fop = &simple_dir_operations;
-2
drivers/misc/ibmasm/ibmasmfs.c
··· 146 146 147 147 if (ret) { 148 148 ret->i_mode = mode; 149 - ret->i_uid = ret->i_gid = 0; 150 - ret->i_blocks = 0; 151 149 ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME; 152 150 } 153 151 return ret;
-3
drivers/oprofile/oprofilefs.c
··· 29 29 30 30 if (inode) { 31 31 inode->i_mode = mode; 32 - inode->i_uid = 0; 33 - inode->i_gid = 0; 34 - inode->i_blocks = 0; 35 32 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 36 33 } 37 34 return inode;
-1
drivers/usb/core/inode.c
··· 279 279 inode->i_mode = mode; 280 280 inode->i_uid = current_fsuid(); 281 281 inode->i_gid = current_fsgid(); 282 - inode->i_blocks = 0; 283 282 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 284 283 switch (mode & S_IFMT) { 285 284 default:
-1
drivers/usb/gadget/inode.c
··· 2001 2001 inode->i_mode = mode; 2002 2002 inode->i_uid = default_uid; 2003 2003 inode->i_gid = default_gid; 2004 - inode->i_blocks = 0; 2005 2004 inode->i_atime = inode->i_mtime = inode->i_ctime 2006 2005 = CURRENT_TIME; 2007 2006 inode->i_private = data;
-2
fs/autofs/inode.c
··· 251 251 inode->i_mode = S_IFDIR | S_IRUGO | S_IXUGO; 252 252 inode->i_nlink = 2; 253 253 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 254 - inode->i_blocks = 0; 255 254 256 255 if (ino == AUTOFS_ROOT_INO) { 257 256 inode->i_mode = S_IFDIR | S_IRUGO | S_IXUGO | S_IWUSR; 258 257 inode->i_op = &autofs_root_inode_operations; 259 258 inode->i_fop = &autofs_root_operations; 260 - inode->i_uid = inode->i_gid = 0; /* Changed in read_super */ 261 259 goto done; 262 260 } 263 261
-4
fs/autofs4/inode.c
··· 455 455 if (sb->s_root) { 456 456 inode->i_uid = sb->s_root->d_inode->i_uid; 457 457 inode->i_gid = sb->s_root->d_inode->i_gid; 458 - } else { 459 - inode->i_uid = 0; 460 - inode->i_gid = 0; 461 458 } 462 - inode->i_blocks = 0; 463 459 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 464 460 465 461 if (S_ISDIR(inf->mode)) {
-3
fs/binfmt_misc.c
··· 496 496 497 497 if (inode) { 498 498 inode->i_mode = mode; 499 - inode->i_uid = 0; 500 - inode->i_gid = 0; 501 - inode->i_blocks = 0; 502 499 inode->i_atime = inode->i_mtime = inode->i_ctime = 503 500 current_fs_time(inode->i_sb); 504 501 }
-3
fs/configfs/inode.c
··· 117 117 static inline void set_default_inode_attr(struct inode * inode, mode_t mode) 118 118 { 119 119 inode->i_mode = mode; 120 - inode->i_uid = 0; 121 - inode->i_gid = 0; 122 120 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 123 121 } 124 122 ··· 134 136 { 135 137 struct inode * inode = new_inode(configfs_sb); 136 138 if (inode) { 137 - inode->i_blocks = 0; 138 139 inode->i_mapping->a_ops = &configfs_aops; 139 140 inode->i_mapping->backing_dev_info = &configfs_backing_dev_info; 140 141 inode->i_op = &configfs_inode_operations;
-2
fs/cramfs/inode.c
··· 83 83 inode->i_op = &page_symlink_inode_operations; 84 84 inode->i_data.a_ops = &cramfs_aops; 85 85 } else { 86 - inode->i_size = 0; 87 - inode->i_blocks = 0; 88 86 init_special_inode(inode, inode->i_mode, 89 87 old_decode_dev(cramfs_inode->size)); 90 88 }
-3
fs/debugfs/inode.c
··· 37 37 38 38 if (inode) { 39 39 inode->i_mode = mode; 40 - inode->i_uid = 0; 41 - inode->i_gid = 0; 42 - inode->i_blocks = 0; 43 40 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 44 41 switch (mode & S_IFMT) { 45 42 default:
-4
fs/devpts/inode.c
··· 189 189 } 190 190 191 191 inode->i_ino = 2; 192 - inode->i_uid = inode->i_gid = 0; 193 - inode->i_blocks = 0; 194 192 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 195 193 196 194 mode = S_IFCHR|opts->ptmxmode; ··· 298 300 goto free_fsi; 299 301 inode->i_ino = 1; 300 302 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 301 - inode->i_blocks = 0; 302 - inode->i_uid = inode->i_gid = 0; 303 303 inode->i_mode = S_IFDIR | S_IRUGO | S_IXUGO | S_IWUSR; 304 304 inode->i_op = &simple_dir_inode_operations; 305 305 inode->i_fop = &simple_dir_operations;
-1
fs/hugetlbfs/inode.c
··· 506 506 inode->i_mode = mode; 507 507 inode->i_uid = uid; 508 508 inode->i_gid = gid; 509 - inode->i_blocks = 0; 510 509 inode->i_mapping->a_ops = &hugetlbfs_aops; 511 510 inode->i_mapping->backing_dev_info =&hugetlbfs_backing_dev_info; 512 511 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+2
fs/inode.c
··· 131 131 inode->i_op = &empty_iops; 132 132 inode->i_fop = &empty_fops; 133 133 inode->i_nlink = 1; 134 + inode->i_uid = 0; 135 + inode->i_gid = 0; 134 136 atomic_set(&inode->i_writecount, 0); 135 137 inode->i_size = 0; 136 138 inode->i_blocks = 0;
-5
fs/libfs.c
··· 231 231 */ 232 232 root->i_ino = 1; 233 233 root->i_mode = S_IFDIR | S_IRUSR | S_IWUSR; 234 - root->i_uid = root->i_gid = 0; 235 234 root->i_atime = root->i_mtime = root->i_ctime = CURRENT_TIME; 236 235 dentry = d_alloc(NULL, &d_name); 237 236 if (!dentry) { ··· 435 436 */ 436 437 inode->i_ino = 1; 437 438 inode->i_mode = S_IFDIR | 0755; 438 - inode->i_uid = inode->i_gid = 0; 439 - inode->i_blocks = 0; 440 439 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 441 440 inode->i_op = &simple_dir_inode_operations; 442 441 inode->i_fop = &simple_dir_operations; ··· 461 464 if (!inode) 462 465 goto out; 463 466 inode->i_mode = S_IFREG | files->mode; 464 - inode->i_uid = inode->i_gid = 0; 465 - inode->i_blocks = 0; 466 467 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 467 468 inode->i_fop = files->ops; 468 469 inode->i_ino = i;
-2
fs/ocfs2/dlm/dlmfs.c
··· 341 341 inode->i_mode = mode; 342 342 inode->i_uid = current_fsuid(); 343 343 inode->i_gid = current_fsgid(); 344 - inode->i_blocks = 0; 345 344 inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info; 346 345 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 347 346 inc_nlink(inode); ··· 366 367 inode->i_mode = mode; 367 368 inode->i_uid = current_fsuid(); 368 369 inode->i_gid = current_fsgid(); 369 - inode->i_blocks = 0; 370 370 inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info; 371 371 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 372 372
-1
fs/omfs/inode.c
··· 39 39 inode->i_mode = mode; 40 40 inode->i_uid = current_fsuid(); 41 41 inode->i_gid = current_fsgid(); 42 - inode->i_blocks = 0; 43 42 inode->i_mapping->a_ops = &omfs_aops; 44 43 45 44 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
-3
fs/openpromfs/inode.c
··· 256 256 break; 257 257 } 258 258 259 - inode->i_gid = 0; 260 - inode->i_uid = 0; 261 - 262 259 d_add(dentry, inode); 263 260 return NULL; 264 261 }
-4
fs/proc/base.c
··· 1426 1426 if (!ei->pid) 1427 1427 goto out_unlock; 1428 1428 1429 - inode->i_uid = 0; 1430 - inode->i_gid = 0; 1431 1429 if (task_dumpable(task)) { 1432 1430 rcu_read_lock(); 1433 1431 cred = __task_cred(task); ··· 2347 2349 if (!ei->pid) 2348 2350 goto out_iput; 2349 2351 2350 - inode->i_uid = 0; 2351 - inode->i_gid = 0; 2352 2352 inode->i_mode = p->mode; 2353 2353 if (S_ISDIR(inode->i_mode)) 2354 2354 inode->i_nlink = 2;
-1
fs/proc/proc_sysctl.c
··· 31 31 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 32 32 inode->i_flags |= S_PRIVATE; /* tell selinux to ignore this inode */ 33 33 inode->i_mode = table->mode; 34 - inode->i_uid = inode->i_gid = 0; 35 34 if (!table->child) { 36 35 inode->i_mode |= S_IFREG; 37 36 inode->i_op = &proc_sys_inode_operations;
-1
fs/ramfs/inode.c
··· 57 57 inode->i_mode = mode; 58 58 inode->i_uid = current_fsuid(); 59 59 inode->i_gid = current_fsgid(); 60 - inode->i_blocks = 0; 61 60 inode->i_mapping->a_ops = &ramfs_aops; 62 61 inode->i_mapping->backing_dev_info = &ramfs_backing_dev_info; 63 62 mapping_set_gfp_mask(inode->i_mapping, GFP_HIGHUSER);
-1
fs/romfs/inode.c
··· 524 524 i->i_size = be32_to_cpu(ri.size); 525 525 i->i_mtime.tv_sec = i->i_atime.tv_sec = i->i_ctime.tv_sec = 0; 526 526 i->i_mtime.tv_nsec = i->i_atime.tv_nsec = i->i_ctime.tv_nsec = 0; 527 - i->i_uid = i->i_gid = 0; 528 527 529 528 /* Precalculate the data offset */ 530 529 ino = romfs_strnlen(i, ino+ROMFH_SIZE, ROMFS_MAXFN);
-3
fs/sysfs/inode.c
··· 107 107 static inline void set_default_inode_attr(struct inode * inode, mode_t mode) 108 108 { 109 109 inode->i_mode = mode; 110 - inode->i_uid = 0; 111 - inode->i_gid = 0; 112 110 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 113 111 } 114 112 ··· 147 149 { 148 150 struct bin_attribute *bin_attr; 149 151 150 - inode->i_blocks = 0; 151 152 inode->i_mapping->a_ops = &sysfs_aops; 152 153 inode->i_mapping->backing_dev_info = &sysfs_backing_dev_info; 153 154 inode->i_op = &sysfs_inode_operations;
-1
ipc/mqueue.c
··· 120 120 inode->i_mode = mode; 121 121 inode->i_uid = current_fsuid(); 122 122 inode->i_gid = current_fsgid(); 123 - inode->i_blocks = 0; 124 123 inode->i_mtime = inode->i_ctime = inode->i_atime = 125 124 CURRENT_TIME; 126 125
-1
kernel/cgroup.c
··· 573 573 inode->i_mode = mode; 574 574 inode->i_uid = current_fsuid(); 575 575 inode->i_gid = current_fsgid(); 576 - inode->i_blocks = 0; 577 576 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 578 577 inode->i_mapping->backing_dev_info = &cgroup_backing_dev_info; 579 578 }
-2
net/sunrpc/rpc_pipe.c
··· 522 522 if (!inode) 523 523 return NULL; 524 524 inode->i_mode = mode; 525 - inode->i_uid = inode->i_gid = 0; 526 - inode->i_blocks = 0; 527 525 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 528 526 switch(mode & S_IFMT) { 529 527 case S_IFDIR:
-3
security/inode.c
··· 61 61 62 62 if (inode) { 63 63 inode->i_mode = mode; 64 - inode->i_uid = 0; 65 - inode->i_gid = 0; 66 - inode->i_blocks = 0; 67 64 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; 68 65 switch (mode & S_IFMT) { 69 66 default:
-2
security/selinux/selinuxfs.c
··· 847 847 848 848 if (ret) { 849 849 ret->i_mode = mode; 850 - ret->i_uid = ret->i_gid = 0; 851 - ret->i_blocks = 0; 852 850 ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME; 853 851 } 854 852 return ret;