Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

can: netns: remove "can_" prefix from members struct netns_can

This patch improves the code reability by removing the redundant "can_"
prefix from the members of struct netns_can (as the struct netns_can itself
is the member "can" of the struct net.)

The conversion is done with:

sed -i \
-e "s/struct can_dev_rcv_lists \*can_rx_alldev_list;/struct can_dev_rcv_lists *rx_alldev_list;/" \
-e "s/spinlock_t can_rcvlists_lock;/spinlock_t rcvlists_lock;/" \
-e "s/struct timer_list can_stattimer;/struct timer_list stattimer; /" \
-e "s/can\.can_rx_alldev_list/can.rx_alldev_list/g" \
-e "s/can\.can_rcvlists_lock/can.rcvlists_lock/g" \
-e "s/can\.can_stattimer/can.stattimer/g" \
include/net/netns/can.h \
net/can/*.[ch]

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

+27 -27
+3 -3
include/net/netns/can.h
··· 28 28 #endif 29 29 30 30 /* receive filters subscribed for 'all' CAN devices */ 31 - struct can_dev_rcv_lists *can_rx_alldev_list; 32 - spinlock_t can_rcvlists_lock; 33 - struct timer_list can_stattimer;/* timer for statistics update */ 31 + struct can_dev_rcv_lists *rx_alldev_list; 32 + spinlock_t rcvlists_lock; 33 + struct timer_list stattimer; /* timer for statistics update */ 34 34 struct can_pkg_stats *pkg_stats; 35 35 struct can_rcv_lists_stats *rcv_lists_stats; 36 36
+17 -17
net/can/af_can.c
··· 302 302 struct net_device *dev) 303 303 { 304 304 if (!dev) 305 - return net->can.can_rx_alldev_list; 305 + return net->can.rx_alldev_list; 306 306 else 307 307 return (struct can_dev_rcv_lists *)dev->ml_priv; 308 308 } ··· 456 456 if (!r) 457 457 return -ENOMEM; 458 458 459 - spin_lock(&net->can.can_rcvlists_lock); 459 + spin_lock(&net->can.rcvlists_lock); 460 460 461 461 d = find_dev_rcv_lists(net, dev); 462 462 if (d) { ··· 481 481 err = -ENODEV; 482 482 } 483 483 484 - spin_unlock(&net->can.can_rcvlists_lock); 484 + spin_unlock(&net->can.rcvlists_lock); 485 485 486 486 return err; 487 487 } ··· 524 524 if (dev && !net_eq(net, dev_net(dev))) 525 525 return; 526 526 527 - spin_lock(&net->can.can_rcvlists_lock); 527 + spin_lock(&net->can.rcvlists_lock); 528 528 529 529 d = find_dev_rcv_lists(net, dev); 530 530 if (!d) { ··· 569 569 } 570 570 571 571 out: 572 - spin_unlock(&net->can.can_rcvlists_lock); 572 + spin_unlock(&net->can.rcvlists_lock); 573 573 574 574 /* schedule the receiver item for deletion */ 575 575 if (r) { ··· 669 669 rcu_read_lock(); 670 670 671 671 /* deliver the packet to sockets listening on all devices */ 672 - matches = can_rcv_filter(net->can.can_rx_alldev_list, skb); 672 + matches = can_rcv_filter(net->can.rx_alldev_list, skb); 673 673 674 674 /* find receive list for this device */ 675 675 d = find_dev_rcv_lists(net, dev); ··· 807 807 break; 808 808 809 809 case NETDEV_UNREGISTER: 810 - spin_lock(&dev_net(dev)->can.can_rcvlists_lock); 810 + spin_lock(&dev_net(dev)->can.rcvlists_lock); 811 811 812 812 d = dev->ml_priv; 813 813 if (d) { ··· 822 822 dev->name); 823 823 } 824 824 825 - spin_unlock(&dev_net(dev)->can.can_rcvlists_lock); 825 + spin_unlock(&dev_net(dev)->can.rcvlists_lock); 826 826 827 827 break; 828 828 } ··· 832 832 833 833 static int can_pernet_init(struct net *net) 834 834 { 835 - spin_lock_init(&net->can.can_rcvlists_lock); 836 - net->can.can_rx_alldev_list = 837 - kzalloc(sizeof(*net->can.can_rx_alldev_list), GFP_KERNEL); 838 - if (!net->can.can_rx_alldev_list) 835 + spin_lock_init(&net->can.rcvlists_lock); 836 + net->can.rx_alldev_list = 837 + kzalloc(sizeof(*net->can.rx_alldev_list), GFP_KERNEL); 838 + if (!net->can.rx_alldev_list) 839 839 goto out; 840 840 net->can.pkg_stats = kzalloc(sizeof(*net->can.pkg_stats), GFP_KERNEL); 841 841 if (!net->can.pkg_stats) ··· 847 847 if (IS_ENABLED(CONFIG_PROC_FS)) { 848 848 /* the statistics are updated every second (timer triggered) */ 849 849 if (stats_timer) { 850 - timer_setup(&net->can.can_stattimer, can_stat_update, 850 + timer_setup(&net->can.stattimer, can_stat_update, 851 851 0); 852 - mod_timer(&net->can.can_stattimer, 852 + mod_timer(&net->can.stattimer, 853 853 round_jiffies(jiffies + HZ)); 854 854 } 855 855 net->can.pkg_stats->jiffies_init = jiffies; ··· 861 861 out_free_pkg_stats: 862 862 kfree(net->can.pkg_stats); 863 863 out_free_rx_alldev_list: 864 - kfree(net->can.can_rx_alldev_list); 864 + kfree(net->can.rx_alldev_list); 865 865 out: 866 866 return -ENOMEM; 867 867 } ··· 873 873 if (IS_ENABLED(CONFIG_PROC_FS)) { 874 874 can_remove_proc(net); 875 875 if (stats_timer) 876 - del_timer_sync(&net->can.can_stattimer); 876 + del_timer_sync(&net->can.stattimer); 877 877 } 878 878 879 879 /* remove created dev_rcv_lists from still registered CAN devices */ ··· 889 889 } 890 890 rcu_read_unlock(); 891 891 892 - kfree(net->can.can_rx_alldev_list); 892 + kfree(net->can.rx_alldev_list); 893 893 kfree(net->can.pkg_stats); 894 894 kfree(net->can.rcv_lists_stats); 895 895 }
+7 -7
net/can/proc.c
··· 118 118 119 119 void can_stat_update(struct timer_list *t) 120 120 { 121 - struct net *net = from_timer(net, t, can.can_stattimer); 121 + struct net *net = from_timer(net, t, can.stattimer); 122 122 struct can_pkg_stats *pkg_stats = net->can.pkg_stats; 123 123 unsigned long j = jiffies; /* snapshot */ 124 124 ··· 177 177 pkg_stats->matches_delta = 0; 178 178 179 179 /* restart timer (one second) */ 180 - mod_timer(&net->can.can_stattimer, round_jiffies(jiffies + HZ)); 180 + mod_timer(&net->can.stattimer, round_jiffies(jiffies + HZ)); 181 181 } 182 182 183 183 /* ··· 222 222 223 223 seq_putc(m, '\n'); 224 224 225 - if (net->can.can_stattimer.function == can_stat_update) { 225 + if (net->can.stattimer.function == can_stat_update) { 226 226 seq_printf(m, " %8ld %% total match ratio (RXMR)\n", 227 227 pkg_stats->total_rx_match_ratio); 228 228 ··· 279 279 280 280 user_reset = 1; 281 281 282 - if (net->can.can_stattimer.function == can_stat_update) { 282 + if (net->can.stattimer.function == can_stat_update) { 283 283 seq_printf(m, "Scheduled statistic reset #%ld.\n", 284 284 rcv_lists_stats->stats_reset + 1); 285 285 } else { ··· 323 323 rcu_read_lock(); 324 324 325 325 /* receive list for 'all' CAN devices (dev == NULL) */ 326 - d = net->can.can_rx_alldev_list; 326 + d = net->can.rx_alldev_list; 327 327 can_rcvlist_proc_show_one(m, idx, NULL, d); 328 328 329 329 /* receive list for registered CAN devices */ ··· 375 375 rcu_read_lock(); 376 376 377 377 /* sff receive list for 'all' CAN devices (dev == NULL) */ 378 - d = net->can.can_rx_alldev_list; 378 + d = net->can.rx_alldev_list; 379 379 can_rcvlist_proc_show_array(m, NULL, d->rx_sff, ARRAY_SIZE(d->rx_sff)); 380 380 381 381 /* sff receive list for registered CAN devices */ ··· 405 405 rcu_read_lock(); 406 406 407 407 /* eff receive list for 'all' CAN devices (dev == NULL) */ 408 - d = net->can.can_rx_alldev_list; 408 + d = net->can.rx_alldev_list; 409 409 can_rcvlist_proc_show_array(m, NULL, d->rx_eff, ARRAY_SIZE(d->rx_eff)); 410 410 411 411 /* eff receive list for registered CAN devices */