Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sh: clkfwk: setup clock parent from current register value

Some clocks can select its parent clock by CPG register.
But it might have been modified by boot-loader or something.
This patch removed fixed initial parent clock,
and setup it from their current register settings.
It works on div6 reparent clocks for now.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

authored by

Kuninori Morimoto and committed by
Paul Mundt
56242a1f a9098b37

+46 -8
+3 -3
arch/arm/mach-shmobile/clock-sh7372.c
··· 411 411 }; 412 412 413 413 static struct clk div6_reparent_clks[DIV6_REPARENT_NR] = { 414 - [DIV6_HDMI] = SH_CLK_DIV6_EXT(&pllc1_div2_clk, HDMICKCR, 0, 414 + [DIV6_HDMI] = SH_CLK_DIV6_EXT(HDMICKCR, 0, 415 415 hdmi_parent, ARRAY_SIZE(hdmi_parent), 6, 2), 416 - [DIV6_FSIA] = SH_CLK_DIV6_EXT(&pllc1_div2_clk, FSIACKCR, 0, 416 + [DIV6_FSIA] = SH_CLK_DIV6_EXT(FSIACKCR, 0, 417 417 fsiackcr_parent, ARRAY_SIZE(fsiackcr_parent), 6, 2), 418 - [DIV6_FSIB] = SH_CLK_DIV6_EXT(&pllc1_div2_clk, FSIBCKCR, 0, 418 + [DIV6_FSIB] = SH_CLK_DIV6_EXT(FSIBCKCR, 0, 419 419 fsibckcr_parent, ARRAY_SIZE(fsibckcr_parent), 6, 2), 420 420 }; 421 421
+2 -2
arch/sh/kernel/cpu/sh4a/clock-sh7724.c
··· 189 189 }; 190 190 191 191 static struct clk div6_reparent_clks[DIV6_REPARENT_NR] = { 192 - [DIV6_FA] = SH_CLK_DIV6_EXT(&div3_clk, FCLKACR, 0, 192 + [DIV6_FA] = SH_CLK_DIV6_EXT(FCLKACR, 0, 193 193 fclkacr_parent, ARRAY_SIZE(fclkacr_parent), 6, 2), 194 - [DIV6_FB] = SH_CLK_DIV6_EXT(&div3_clk, FCLKBCR, 0, 194 + [DIV6_FB] = SH_CLK_DIV6_EXT(FCLKBCR, 0, 195 195 fclkbcr_parent, ARRAY_SIZE(fclkbcr_parent), 6, 2), 196 196 }; 197 197
+35
drivers/sh/clk/cpg.c
··· 167 167 .set_parent = sh_clk_div6_set_parent, 168 168 }; 169 169 170 + static int __init sh_clk_init_parent(struct clk *clk) 171 + { 172 + u32 val; 173 + 174 + if (clk->parent) 175 + return 0; 176 + 177 + if (!clk->parent_table || !clk->parent_num) 178 + return 0; 179 + 180 + if (!clk->src_width) { 181 + pr_err("sh_clk_init_parent: cannot select parent clock\n"); 182 + return -EINVAL; 183 + } 184 + 185 + val = (__raw_readl(clk->enable_reg) >> clk->src_shift); 186 + val &= (1 << clk->src_width) - 1; 187 + 188 + if (val >= clk->parent_num) { 189 + pr_err("sh_clk_init_parent: parent table size failed\n"); 190 + return -EINVAL; 191 + } 192 + 193 + clk->parent = clk->parent_table[val]; 194 + if (!clk->parent) { 195 + pr_err("sh_clk_init_parent: unable to set parent"); 196 + return -EINVAL; 197 + } 198 + 199 + return 0; 200 + } 201 + 170 202 static int __init sh_clk_div6_register_ops(struct clk *clks, int nr, 171 203 struct clk_ops *ops) 172 204 { ··· 222 190 clkp->ops = ops; 223 191 clkp->freq_table = freq_table + (k * freq_table_size); 224 192 clkp->freq_table[nr_divs].frequency = CPUFREQ_TABLE_END; 193 + ret = sh_clk_init_parent(clkp); 194 + if (ret < 0) 195 + break; 225 196 226 197 ret = clk_register(clkp); 227 198 }
+6 -3
include/linux/sh_clk.h
··· 131 131 int sh_clk_div4_reparent_register(struct clk *clks, int nr, 132 132 struct clk_div4_table *table); 133 133 134 - #define SH_CLK_DIV6_EXT(_parent, _reg, _flags, _parents, \ 134 + #define SH_CLK_DIV6_EXT(_reg, _flags, _parents, \ 135 135 _num_parents, _src_shift, _src_width) \ 136 136 { \ 137 - .parent = _parent, \ 138 137 .enable_reg = (void __iomem *)_reg, \ 139 138 .flags = _flags, \ 140 139 .parent_table = _parents, \ ··· 143 144 } 144 145 145 146 #define SH_CLK_DIV6(_parent, _reg, _flags) \ 146 - SH_CLK_DIV6_EXT(_parent, _reg, _flags, NULL, 0, 0, 0) 147 + { \ 148 + .parent = _parent, \ 149 + .enable_reg = (void __iomem *)_reg, \ 150 + .flags = _flags, \ 151 + } 147 152 148 153 int sh_clk_div6_register(struct clk *clks, int nr); 149 154 int sh_clk_div6_reparent_register(struct clk *clks, int nr);