Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide

Pull IDE update from David Miller:
"Two small IDE layer adjustments"

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide:
drivers: ide: Fix mostly harmless off-by-one hardcoded value
IDE: Deletion of an unnecessary check before the function call "module_put"

+3 -4
+2 -2
drivers/ide/ide-floppy.c
··· 487 487 * it. It should be fixed as of version 1.9, but to be on the safe side 488 488 * we'll leave the limitation below for the 2.2.x tree. 489 489 */ 490 - if (!strncmp((char *)&id[ATA_ID_PROD], "IOMEGA ZIP 100 ATAPI", 20)) { 490 + if (strstarts((char *)&id[ATA_ID_PROD], "IOMEGA ZIP 100 ATAPI")) { 491 491 drive->atapi_flags |= IDE_AFLAG_ZIP_DRIVE; 492 492 /* This value will be visible in the /proc/ide/hdx/settings */ 493 493 drive->pc_delay = IDEFLOPPY_PC_DELAY; ··· 498 498 * Guess what? The IOMEGA Clik! drive also needs the above fix. It makes 499 499 * nasty clicking noises without it, so please don't remove this. 500 500 */ 501 - if (strncmp((char *)&id[ATA_ID_PROD], "IOMEGA Clik!", 11) == 0) { 501 + if (strstarts((char *)&id[ATA_ID_PROD], "IOMEGA Clik!")) { 502 502 blk_queue_max_hw_sectors(drive->queue, 64); 503 503 drive->atapi_flags |= IDE_AFLAG_CLIK_DRIVE; 504 504 /* IOMEGA Clik! drives do not support lock/unlock commands */
+1 -2
drivers/ide/ide.c
··· 101 101 struct device *host_dev = drive->hwif->host->dev[0]; 102 102 struct module *module = host_dev ? host_dev->driver->owner : NULL; 103 103 104 - if (module) 105 - module_put(module); 104 + module_put(module); 106 105 #endif 107 106 put_device(&drive->gendev); 108 107 }