Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

serial: mvebu-uart: fix tx lost characters at power off

Commit c685af1108d7 ("serial: mvebu-uart: fix tx lost characters") fixed tx
lost characters at low baud rates but started causing tx lost characters
when kernel is going to power off or reboot.

TX_EMP tells us when transmit queue is empty therefore all characters were
transmitted. TX_RDY tells us when CPU can send a new character.

Therefore we need to use different check prior transmitting new character
and different check after all characters were sent.

This patch splits polling code into two functions: wait_for_xmitr() which
waits for TX_RDY and wait_for_xmite() which waits for TX_EMP.

When rebooting A3720 platform without this patch on UART is print only:
[ 42.699�

And with this patch on UART is full output:
[ 39.530216] reboot: Restarting system

Fixes: c685af1108d7 ("serial: mvebu-uart: fix tx lost characters")
Signed-off-by: Pali Rohár <pali@kernel.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201223191931.18343-1-pali@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Pali Rohár and committed by
Greg Kroah-Hartman
54ca955b 5c8fe583

+9 -1
+9 -1
drivers/tty/serial/mvebu-uart.c
··· 648 648 (val & STAT_TX_RDY(port)), 1, 10000); 649 649 } 650 650 651 + static void wait_for_xmite(struct uart_port *port) 652 + { 653 + u32 val; 654 + 655 + readl_poll_timeout_atomic(port->membase + UART_STAT, val, 656 + (val & STAT_TX_EMP), 1, 10000); 657 + } 658 + 651 659 static void mvebu_uart_console_putchar(struct uart_port *port, int ch) 652 660 { 653 661 wait_for_xmitr(port); ··· 683 675 684 676 uart_console_write(port, s, count, mvebu_uart_console_putchar); 685 677 686 - wait_for_xmitr(port); 678 + wait_for_xmite(port); 687 679 688 680 if (ier) 689 681 writel(ier, port->membase + UART_CTRL(port));