Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf evsel: Uninline the is_function_event method

So that we don't have to carry a string.h header in evsel.h

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-2lwpm2aytdvvgo626zuat6et@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

+19 -17
+18
tools/perf/util/evsel.c
··· 200 200 evsel->attr.read_format |= PERF_FORMAT_ID; 201 201 } 202 202 203 + /** 204 + * perf_evsel__is_function_event - Return whether given evsel is a function 205 + * trace event 206 + * 207 + * @evsel - evsel selector to be tested 208 + * 209 + * Return %true if event is function trace event 210 + */ 211 + bool perf_evsel__is_function_event(struct perf_evsel *evsel) 212 + { 213 + #define FUNCTION_EVENT "ftrace:function" 214 + 215 + return evsel->name && 216 + !strncmp(FUNCTION_EVENT, evsel->name, sizeof(FUNCTION_EVENT)); 217 + 218 + #undef FUNCTION_EVENT 219 + } 220 + 203 221 void perf_evsel__init(struct perf_evsel *evsel, 204 222 struct perf_event_attr *attr, int idx) 205 223 {
+1 -17
tools/perf/util/evsel.h
··· 355 355 return perf_evsel__is_group_leader(evsel) && evsel->nr_members > 1; 356 356 } 357 357 358 - /** 359 - * perf_evsel__is_function_event - Return whether given evsel is a function 360 - * trace event 361 - * 362 - * @evsel - evsel selector to be tested 363 - * 364 - * Return %true if event is function trace event 365 - */ 366 - static inline bool perf_evsel__is_function_event(struct perf_evsel *evsel) 367 - { 368 - #define FUNCTION_EVENT "ftrace:function" 369 - 370 - return evsel->name && 371 - !strncmp(FUNCTION_EVENT, evsel->name, sizeof(FUNCTION_EVENT)); 372 - 373 - #undef FUNCTION_EVENT 374 - } 358 + bool perf_evsel__is_function_event(struct perf_evsel *evsel); 375 359 376 360 static inline bool perf_evsel__is_bpf_output(struct perf_evsel *evsel) 377 361 {