Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/chrome: chromeos_pstore: Add ecc_size module parameter

On ChromiumOS devices, the `ecc_size` is set to 0 (check dmesg | grep ecc 
to see `ecc: 0`): this disables ECC for ramoops region, even when 
`ramoops.ecc=1` is given to kernel command line parameter.

Introduce `ecc_size` module parameter to provide a method to turn on ECC
for ramoops and set different values of ecc_size per devices.

A large `ecc_size` value can cause a kernel panic due to a constraint in
Reed-Solomon code library. The validation for this constraint should
belong to the common pstore RAM layer, not in each individual driver. So
this check is handled by a separate patch [1].

[1] https://lore.kernel.org/lkml/20250620054757.1006729-1-naoyatezuka@chromium.org

Signed-off-by: Naoya Tezuka <naoyatezuka@chromium.org>
Link: https://lore.kernel.org/r/20250620062822.1018798-1-naoyatezuka@chromium.org
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>

authored by

Naoya Tezuka and committed by
Tzung-Bi Shih
545daf90 8866f4e5

+7
+7
drivers/platform/chrome/chromeos_pstore.c
··· 9 9 #include <linux/platform_device.h> 10 10 #include <linux/pstore_ram.h> 11 11 12 + static int ecc_size; 13 + module_param(ecc_size, int, 0400); 14 + MODULE_PARM_DESC(ecc_size, "ECC parity data size in bytes. A positive value enables ECC for the ramoops region."); 15 + 12 16 static const struct dmi_system_id chromeos_pstore_dmi_table[] __initconst = { 13 17 { 14 18 /* ··· 120 116 static int __init chromeos_pstore_init(void) 121 117 { 122 118 bool acpi_dev_found; 119 + 120 + if (ecc_size > 0) 121 + chromeos_ramoops_data.ecc_info.ecc_size = ecc_size; 123 122 124 123 /* First check ACPI for non-hardcoded values from firmware. */ 125 124 acpi_dev_found = chromeos_check_acpi();