Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

serial: 8250: document doubled "type == PORT_8250_CIR" check

The check for "port.type == PORT_8250_CIR" is present twice in
serial8250_register_8250_port(). The latter was already tried to be
dropped by 1104321a7b3b ("serial: Delete dead code for CIR serial
ports") and then reverted by 9527b82ae3af ("Revert "serial: Delete dead
code for CIR serial ports"").

Document this weirdness with a reason.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Link: https://lore.kernel.org/all/aFcDOx1bdB34I5hS@surfacebook.localdomain/
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20250624080641.509959-5-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jiri Slaby (SUSE) and committed by
Greg Kroah-Hartman
543a5af3 2721fc7a

+2
+2
drivers/tty/serial/8250/8250_core.c
··· 717 717 nr_uarts++; 718 718 } 719 719 720 + /* Check if it is CIR already. We check this below again, see there why. */ 720 721 if (uart->port.type == PORT_8250_CIR) { 721 722 ret = -ENODEV; 722 723 goto unlock; ··· 816 815 if (up->dl_write) 817 816 uart->dl_write = up->dl_write; 818 817 818 + /* Check the type (again)! It might have changed by the port.type assignment above. */ 819 819 if (uart->port.type != PORT_8250_CIR) { 820 820 if (uart_console_registered(&uart->port)) 821 821 pm_runtime_get_sync(uart->port.dev);