Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: dwc3: core: Call dwc3_core_get_phy() before initializing phys

commit f54edb539c116 ("usb: dwc3: core: initialize ULPI before trying to
get the PHY") moved call to dwc3_core_get_phy() from dwc3_probe() to
dwc3_core_init() after dwc3_core_soft_reset(). But
dwc3_core_soft_reset() calls phy_init(), therefore dwc3_core_get_phy()
needs to be called before dwc3_core_soft_reset().

Fix this by moving call to dwc3_core_get_phy() before
dwc3_core_soft_reset().

This fixes the following abort seen on DRA7xx platforms
[ 24.769118] usb usb2: SerialNumber: xhci-hcd.1.auto
[ 24.781144] hub 2-0:1.0: USB hub found
[ 24.787836] hub 2-0:1.0: 1 port detected
[ 24.809939] Unhandled fault: imprecise external abort (0x1406) at 0x00000000

Reported-by: Carlos Hernandez <ceh@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

authored by

Vignesh R and committed by
Felipe Balbi
541768b0 5771a8c0

+4 -4
+4 -4
drivers/usb/dwc3/core.c
··· 766 766 dwc->maximum_speed = USB_SPEED_HIGH; 767 767 } 768 768 769 + ret = dwc3_core_get_phy(dwc); 770 + if (ret) 771 + goto err0; 772 + 769 773 ret = dwc3_core_soft_reset(dwc); 770 774 if (ret) 771 775 goto err0; 772 776 773 777 ret = dwc3_phy_setup(dwc); 774 - if (ret) 775 - goto err0; 776 - 777 - ret = dwc3_core_get_phy(dwc); 778 778 if (ret) 779 779 goto err0; 780 780