Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

caif: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Cc: Richard Fontana <rfontana@redhat.com>
Cc: Steve Winslow <swinslow@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Greg Kroah-Hartman and committed by
David S. Miller
53f6f391 6f20a697

+11 -21
+10 -16
drivers/net/caif/caif_serial.c
··· 94 94 } 95 95 static inline void debugfs_init(struct ser_device *ser, struct tty_struct *tty) 96 96 { 97 - ser->debugfs_tty_dir = 98 - debugfs_create_dir(tty->name, debugfsdir); 99 - if (!IS_ERR(ser->debugfs_tty_dir)) { 100 - debugfs_create_blob("last_tx_msg", 0400, 101 - ser->debugfs_tty_dir, 102 - &ser->tx_blob); 97 + ser->debugfs_tty_dir = debugfs_create_dir(tty->name, debugfsdir); 103 98 104 - debugfs_create_blob("last_rx_msg", 0400, 105 - ser->debugfs_tty_dir, 106 - &ser->rx_blob); 99 + debugfs_create_blob("last_tx_msg", 0400, ser->debugfs_tty_dir, 100 + &ser->tx_blob); 107 101 108 - debugfs_create_x32("ser_state", 0400, 109 - ser->debugfs_tty_dir, 110 - (u32 *)&ser->state); 102 + debugfs_create_blob("last_rx_msg", 0400, ser->debugfs_tty_dir, 103 + &ser->rx_blob); 111 104 112 - debugfs_create_x8("tty_status", 0400, 113 - ser->debugfs_tty_dir, 114 - &ser->tty_status); 105 + debugfs_create_x32("ser_state", 0400, ser->debugfs_tty_dir, 106 + (u32 *)&ser->state); 115 107 116 - } 108 + debugfs_create_x8("tty_status", 0400, ser->debugfs_tty_dir, 109 + &ser->tty_status); 110 + 117 111 ser->tx_blob.data = ser->tx_data; 118 112 ser->tx_blob.size = 0; 119 113 ser->rx_blob.data = ser->rx_data;
+1 -5
drivers/net/caif/caif_virtio.c
··· 623 623 /* Create debugfs counters for the device */ 624 624 static inline void debugfs_init(struct cfv_info *cfv) 625 625 { 626 - cfv->debugfs = 627 - debugfs_create_dir(netdev_name(cfv->ndev), NULL); 628 - 629 - if (IS_ERR(cfv->debugfs)) 630 - return; 626 + cfv->debugfs = debugfs_create_dir(netdev_name(cfv->ndev), NULL); 631 627 632 628 debugfs_create_u32("rx-napi-complete", 0400, cfv->debugfs, 633 629 &cfv->stats.rx_napi_complete);