tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

mt76: improve mcu error logging

Dump mcu command code in hex and related prefix to help debugging

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

authored by

Lorenzo Bianconi and committed by
Felix Fietkau 53d35b1a a8333801

+8 -10
+2 -3
drivers/net/wireless/mediatek/mt76/mt7603/mcu.c
··· 21 21 struct mt7603_mcu_rxd *rxd; 22 22 23 23 if (!skb) { 24 - dev_err(mdev->dev, 25 - "MCU message %d (seq %d) timed out\n", 26 - cmd, seq); 24 + dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n", 25 + abs(cmd), seq); 27 26 dev->mcu_hang = MT7603_WATCHDOG_TIMEOUT; 28 27 return -ETIMEDOUT; 29 28 }
+2 -2
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
··· 175 175 int ret = 0; 176 176 177 177 if (!skb) { 178 - dev_err(mdev->dev, "Message %ld (seq %d) timeout\n", 179 - cmd & MCU_CMD_MASK, seq); 178 + dev_err(mdev->dev, "Message %08x (seq %d) timeout\n", 179 + cmd, seq); 180 180 return -ETIMEDOUT; 181 181 } 182 182
+2 -3
drivers/net/wireless/mediatek/mt76/mt76x02_mcu.c
··· 17 17 u32 *rxfce; 18 18 19 19 if (!skb) { 20 - dev_err(mdev->dev, 21 - "MCU message %d (seq %d) timed out\n", cmd, 22 - seq); 20 + dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n", 21 + abs(cmd), seq); 23 22 dev->mcu_timeout = 1; 24 23 return -ETIMEDOUT; 25 24 }
+1 -1
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
··· 217 217 int ret = 0; 218 218 219 219 if (!skb) { 220 - dev_err(mdev->dev, "Message %d (seq %d) timeout\n", 220 + dev_err(mdev->dev, "Message %08x (seq %d) timeout\n", 221 221 cmd, seq); 222 222 return -ETIMEDOUT; 223 223 }
+1 -1
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
··· 160 160 int ret = 0; 161 161 162 162 if (!skb) { 163 - dev_err(mdev->dev, "Message %d (seq %d) timeout\n", 163 + dev_err(mdev->dev, "Message %08x (seq %d) timeout\n", 164 164 cmd, seq); 165 165 return -ETIMEDOUT; 166 166 }