Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: generic: test-component: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-86-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
53946256 b7f036b9

+2 -4
+2 -4
sound/soc/generic/test-component.c
··· 635 635 return 0; 636 636 } 637 637 638 - static int test_driver_remove(struct platform_device *pdev) 638 + static void test_driver_remove(struct platform_device *pdev) 639 639 { 640 640 mile_stone_x(&pdev->dev); 641 - 642 - return 0; 643 641 } 644 642 645 643 static struct platform_driver test_driver = { ··· 646 648 .of_match_table = test_of_match, 647 649 }, 648 650 .probe = test_driver_probe, 649 - .remove = test_driver_remove, 651 + .remove_new = test_driver_remove, 650 652 }; 651 653 module_platform_driver(test_driver); 652 654