ipvs: Avoid unnecessary calls to skb_is_gso_sctp

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

In the context of the SCTP SNAT/DNAT handler, these calls can only
return true.

Fixes: e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets")
Signed-off-by: Ismael Luceno <iluceno@suse.de>
Acked-by: Julian Anastasov <ja@ssi.bg>
Acked-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

authored by

Ismael Luceno and committed by

Pablo Neira Ayuso 2 years ago 53796b03 e169285f

+2 -2

1 changed file

expand all

net

netfilter

ipvs

ip_vs_proto_sctp.c

+2 -2

net/netfilter/ipvs/ip_vs_proto_sctp.c

··· 126 126 if (sctph->source != cp->vport || payload_csum || 127 127 skb->ip_summed == CHECKSUM_PARTIAL) { 128 128 sctph->source = cp->vport; 129 - if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb)) 129 + if (!skb_is_gso(skb)) 130 130 sctp_nat_csum(skb, sctph, sctphoff); 131 131 } else { 132 132 skb->ip_summed = CHECKSUM_UNNECESSARY; ··· 175 175 (skb->ip_summed == CHECKSUM_PARTIAL && 176 176 !(skb_dst(skb)->dev->features & NETIF_F_SCTP_CRC))) { 177 177 sctph->dest = cp->dport; 178 - if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb)) 178 + if (!skb_is_gso(skb)) 179 179 sctp_nat_csum(skb, sctph, sctphoff); 180 180 } else if (skb->ip_summed != CHECKSUM_PARTIAL) { 181 181 skb->ip_summed = CHECKSUM_UNNECESSARY;