Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Bluetooth: clean up rfcomm code

Remove dead code and unused rfcomm thread events

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>

authored by

Andrei Emeltchenko and committed by
Gustavo F. Padovan
534c92fd ab3e5715

+14 -20
-5
include/net/bluetooth/rfcomm.h
··· 213 213 #define RFCOMM_DEFER_SETUP 8 214 214 215 215 /* Scheduling flags and events */ 216 - #define RFCOMM_SCHED_STATE 0 217 - #define RFCOMM_SCHED_RX 1 218 - #define RFCOMM_SCHED_TX 2 219 - #define RFCOMM_SCHED_TIMEO 3 220 - #define RFCOMM_SCHED_AUTH 4 221 216 #define RFCOMM_SCHED_WAKEUP 31 222 217 223 218 /* MSC exchange flags */
+14 -15
net/bluetooth/rfcomm/core.c
··· 113 113 #define __get_rpn_stop_bits(line) (((line) >> 2) & 0x1) 114 114 #define __get_rpn_parity(line) (((line) >> 3) & 0x7) 115 115 116 - static inline void rfcomm_schedule(uint event) 116 + static inline void rfcomm_schedule(void) 117 117 { 118 118 if (!rfcomm_thread) 119 119 return; 120 - //set_bit(event, &rfcomm_event); 121 120 set_bit(RFCOMM_SCHED_WAKEUP, &rfcomm_event); 122 121 wake_up_process(rfcomm_thread); 123 122 } ··· 202 203 static void rfcomm_l2state_change(struct sock *sk) 203 204 { 204 205 BT_DBG("%p state %d", sk, sk->sk_state); 205 - rfcomm_schedule(RFCOMM_SCHED_STATE); 206 + rfcomm_schedule(); 206 207 } 207 208 208 209 static void rfcomm_l2data_ready(struct sock *sk, int bytes) 209 210 { 210 211 BT_DBG("%p bytes %d", sk, bytes); 211 - rfcomm_schedule(RFCOMM_SCHED_RX); 212 + rfcomm_schedule(); 212 213 } 213 214 214 215 static int rfcomm_l2sock_create(struct socket **sock) ··· 254 255 BT_DBG("session %p state %ld", s, s->state); 255 256 256 257 set_bit(RFCOMM_TIMED_OUT, &s->flags); 257 - rfcomm_schedule(RFCOMM_SCHED_TIMEO); 258 + rfcomm_schedule(); 258 259 } 259 260 260 261 static void rfcomm_session_set_timer(struct rfcomm_session *s, long timeout) ··· 282 283 283 284 set_bit(RFCOMM_TIMED_OUT, &d->flags); 284 285 rfcomm_dlc_put(d); 285 - rfcomm_schedule(RFCOMM_SCHED_TIMEO); 286 + rfcomm_schedule(); 286 287 } 287 288 288 289 static void rfcomm_dlc_set_timer(struct rfcomm_dlc *d, long timeout) ··· 464 465 case BT_CONFIG: 465 466 if (test_and_clear_bit(RFCOMM_DEFER_SETUP, &d->flags)) { 466 467 set_bit(RFCOMM_AUTH_REJECT, &d->flags); 467 - rfcomm_schedule(RFCOMM_SCHED_AUTH); 468 + rfcomm_schedule(); 468 469 break; 469 470 } 470 471 /* Fall through */ ··· 484 485 case BT_CONNECT2: 485 486 if (test_and_clear_bit(RFCOMM_DEFER_SETUP, &d->flags)) { 486 487 set_bit(RFCOMM_AUTH_REJECT, &d->flags); 487 - rfcomm_schedule(RFCOMM_SCHED_AUTH); 488 + rfcomm_schedule(); 488 489 break; 489 490 } 490 491 /* Fall through */ ··· 532 533 skb_queue_tail(&d->tx_queue, skb); 533 534 534 535 if (!test_bit(RFCOMM_TX_THROTTLED, &d->flags)) 535 - rfcomm_schedule(RFCOMM_SCHED_TX); 536 + rfcomm_schedule(); 536 537 return len; 537 538 } 538 539 ··· 544 545 d->v24_sig |= RFCOMM_V24_FC; 545 546 set_bit(RFCOMM_MSC_PENDING, &d->flags); 546 547 } 547 - rfcomm_schedule(RFCOMM_SCHED_TX); 548 + rfcomm_schedule(); 548 549 } 549 550 550 551 void __rfcomm_dlc_unthrottle(struct rfcomm_dlc *d) ··· 555 556 d->v24_sig &= ~RFCOMM_V24_FC; 556 557 set_bit(RFCOMM_MSC_PENDING, &d->flags); 557 558 } 558 - rfcomm_schedule(RFCOMM_SCHED_TX); 559 + rfcomm_schedule(); 559 560 } 560 561 561 562 /* ··· 576 577 d->v24_sig = v24_sig; 577 578 578 579 if (!test_and_set_bit(RFCOMM_MSC_PENDING, &d->flags)) 579 - rfcomm_schedule(RFCOMM_SCHED_TX); 580 + rfcomm_schedule(); 580 581 581 582 return 0; 582 583 } ··· 815 816 cmd->fcs = __fcs2((u8 *) cmd); 816 817 817 818 skb_queue_tail(&d->tx_queue, skb); 818 - rfcomm_schedule(RFCOMM_SCHED_TX); 819 + rfcomm_schedule(); 819 820 return 0; 820 821 } 821 822 ··· 1883 1884 * L2CAP MTU minus UIH header and FCS. */ 1884 1885 s->mtu = min(l2cap_pi(nsock->sk)->omtu, l2cap_pi(nsock->sk)->imtu) - 5; 1885 1886 1886 - rfcomm_schedule(RFCOMM_SCHED_RX); 1887 + rfcomm_schedule(); 1887 1888 } else 1888 1889 sock_release(nsock); 1889 1890 } ··· 2092 2093 2093 2094 rfcomm_session_put(s); 2094 2095 2095 - rfcomm_schedule(RFCOMM_SCHED_AUTH); 2096 + rfcomm_schedule(); 2096 2097 } 2097 2098 2098 2099 static struct hci_cb rfcomm_cb = {